Remove testId

This commit is contained in:
Rémi de Juvigny 2023-05-02 16:20:32 +02:00
parent 6895240a6f
commit 2f480c7ab9
3 changed files with 7 additions and 5 deletions

View File

@ -1,5 +1,5 @@
import React from 'react';
import { act, render, screen } from '@testing-library/react';
import { act, render, screen, within } from '@testing-library/react';
import userEvent from '@testing-library/user-event';
import { ThemeProvider, lightTheme } from '@strapi/design-system';
import { IntlProvider } from 'react-intl';
@ -91,7 +91,9 @@ describe('BulkActionsBar', () => {
await act(async () => {
await user.click(screen.getByRole('button', { name: /\bpublish\b/i }));
await user.click(screen.getByTestId('confirm-publish'));
await user.click(
within(screen.getByRole('dialog')).getByRole('button', { name: /\bpublish\b/i })
);
});
expect(onConfirmPublishAll).toHaveBeenCalledWith([]);
@ -103,7 +105,9 @@ describe('BulkActionsBar', () => {
await act(async () => {
await user.click(screen.getByRole('button', { name: /\bunpublish\b/i }));
await user.click(screen.getByTestId('confirm-unpublish'));
await user.click(
within(screen.getByRole('dialog')).getByRole('button', { name: /\bunpublish\b/i })
);
});
expect(onConfirmUnpublishAll).toHaveBeenCalledWith([]);

View File

@ -31,7 +31,6 @@ const ConfirmDialogPublishAll = ({ isOpen, onToggleDialog, isConfirmButtonLoadin
onClick={onConfirm}
variant="secondary"
startIcon={<Check />}
data-testid="confirm-publish"
loading={isConfirmButtonLoading}
>
{formatMessage({

View File

@ -38,7 +38,6 @@ const ConfirmDialogUnpublishAll = ({
onClick={onConfirm}
variant="secondary"
startIcon={<Check />}
data-testid="confirm-unpublish"
loading={isConfirmButtonLoading}
>
{formatMessage({