finally drop temp table

This commit is contained in:
Pierre Noël 2022-11-15 18:57:13 +01:00
parent e2234ed9f1
commit 306d5c4abc

View File

@ -295,6 +295,7 @@ const cleanOrderColumnsForOldDatabases = async ({
if (hasOrderColumn(attribute) && id) { if (hasOrderColumn(attribute) && id) {
const tempOrderTableName = `tempOrderTableName_${now}`; const tempOrderTableName = `tempOrderTableName_${now}`;
try {
await db.connection await db.connection
.raw( .raw(
` `
@ -324,10 +325,16 @@ const cleanOrderColumnsForOldDatabases = async ({
[joinTable.name, tempOrderTableName, orderColumnName] [joinTable.name, tempOrderTableName, orderColumnName]
) )
.transacting(trx); .transacting(trx);
await db.connection.raw(`DROP TEMPORARY TABLE ${tempOrderTableName}`).transacting(trx); } finally {
await db.connection
.raw(`DROP TEMPORARY TABLE IF EXISTS ${tempOrderTableName}`)
.transacting(trx);
} }
}
if (hasInverseOrderColumn(attribute) && !isEmpty(inverseRelIds)) { if (hasInverseOrderColumn(attribute) && !isEmpty(inverseRelIds)) {
const tempInvOrderTableName = `tempInvOrderTableName_${now}`; const tempInvOrderTableName = `tempInvOrderTableName_${now}`;
try {
await db.connection await db.connection
.raw( .raw(
` `
@ -363,7 +370,11 @@ const cleanOrderColumnsForOldDatabases = async ({
[joinTable.name, tempInvOrderTableName, inverseOrderColumnName] [joinTable.name, tempInvOrderTableName, inverseOrderColumnName]
) )
.transacting(trx); .transacting(trx);
await db.connection.raw(`DROP TEMPORARY TABLE ${tempInvOrderTableName}`).transacting(trx); } finally {
await db.connection
.raw(`DROP TEMPORARY TABLE IF EXISTS ${tempInvOrderTableName}`)
.transacting(trx);
}
} }
}; };