Refactor code to run the query only when necessary

This commit is contained in:
harimkims 2021-12-22 17:58:22 +09:00
parent 84130ab541
commit 32e4aec852

View File

@ -194,10 +194,8 @@ const findEntityAndCheckPermissions = async (ability, action, model, id) => {
const pm = strapi.admin.services.permission.createPermissionsManager({ ability, action, model });
const author = await strapi.admin.services.user.findOne(
_.get(file, [CREATED_BY_ATTRIBUTE, 'id'], ''),
['roles']
);
const creatorId = _.get(file, [CREATED_BY_ATTRIBUTE, 'id']);
const author = creatorId ? await strapi.admin.services.user.findOne(creatorId, ['roles']) : null;
const fileWithRoles = _.set(_.cloneDeep(file), 'createdBy', author);