yujunjun/strapi
1
0
Fork 0
mirror of https://github.com/strapi/strapi.git synced 2025-12-29 08:04:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: apply review feedbacks and add refactoring todo

Browse Source
This commit is contained in:
Alexandre Bodin 2024-01-16 10:57:44 +01:00
parent fe983aff15
commit 37b3dbf893
3 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
packages/core/admin/admin/src/content-manager/pages/EditSettingsView/components/GenericInput.tsx
View File

@ -10,6 +10,7 @@ interface GenericInputProps extends Record<string, unknown> {
label: string;
}
// TODO: refactor this to be actually typesafe instead of casting
const GenericInput = ({
type,
options,

3
packages/core/admin/admin/src/content-manager/pages/EditSettingsView/components/LayoutDndProvider.tsx
View File

@ -24,7 +24,8 @@ export interface LayoutDndProviderProps {
children?: React.ReactNode;
}
const LayoutDndContext = React.createContext<LayoutDndProviderProps>(
// TODO: refactor this to be actually typesafe instead of casting
const LayoutDndContext = React.createContext<Omit<LayoutDndProviderProps, 'children'>>(
null as unknown as LayoutDndProviderProps
);

1
packages/core/admin/admin/src/content-manager/pages/EditSettingsView/components/ModalForm.tsx
View File

@ -126,6 +126,7 @@ const ModalForm = ({ onMetaChange, onSizeChange }: ModalFormProps) => {
value={fieldForm?.size}
name="size"
onChange={(value) => {
// TODO: refactor this to be actually typesafe instead of casting
onSizeChange({ name: selectedField, value: value as number });
}}
label={formatMessage({