From ee63110d864ae2ddb82541beb9c73a57628a9b22 Mon Sep 17 00:00:00 2001
From: ronronscelestes <julie.plantey@gmail.com>
Date: Tue, 2 Nov 2021 19:01:30 +0100
Subject: [PATCH 1/2] fixed ellipsis on name and description in settings role
 LV

---
 .../pages/Roles/ListPage/components/RoleRow/index.js   | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/packages/core/admin/admin/src/pages/SettingsPage/pages/Roles/ListPage/components/RoleRow/index.js b/packages/core/admin/admin/src/pages/SettingsPage/pages/Roles/ListPage/components/RoleRow/index.js
index d199414044..0eb3b95d97 100644
--- a/packages/core/admin/admin/src/pages/SettingsPage/pages/Roles/ListPage/components/RoleRow/index.js
+++ b/packages/core/admin/admin/src/pages/SettingsPage/pages/Roles/ListPage/components/RoleRow/index.js
@@ -3,7 +3,7 @@ import PropTypes from 'prop-types';
 import { Box } from '@strapi/design-system/Box';
 import { Flex } from '@strapi/design-system/Flex';
 import { Td, Tr } from '@strapi/design-system/Table';
-import { Text } from '@strapi/design-system/Text';
+import { Text, EllipsisText } from '@strapi/design-system/Text';
 import { IconButton } from '@strapi/design-system/IconButton';
 import { stopPropagation, onRowClick } from '@strapi/helper-plugin';
 import { useIntl } from 'react-intl';
@@ -26,11 +26,11 @@ const RoleRow = ({ id, name, description, usersCount, icons }) => {
         fn: icons[1].onClick,
       })}
     >
-      <Td>
-        <Text textColor="neutral800">{name}</Text>
+      <Td maxWidth={`${130 / 16}rem`}>
+        <EllipsisText textColor="neutral800">{name}</EllipsisText>
       </Td>
-      <Td>
-        <Text textColor="neutral800">{description}</Text>
+      <Td maxWidth={`${250 / 16}rem`}>
+        <EllipsisText textColor="neutral800">{description}</EllipsisText>
       </Td>
       <Td>
         <Text textColor="neutral800">{usersCountText}</Text>

From 6d5a0d27a5dd64985992f31b5f7fbbba0c3a615e Mon Sep 17 00:00:00 2001
From: ronronscelestes <julie.plantey@gmail.com>
Date: Wed, 3 Nov 2021 10:56:21 +0100
Subject: [PATCH 2/2] feedback fix

---
 .../pages/Roles/ListPage/components/RoleRow/index.js        | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/packages/core/admin/admin/src/pages/SettingsPage/pages/Roles/ListPage/components/RoleRow/index.js b/packages/core/admin/admin/src/pages/SettingsPage/pages/Roles/ListPage/components/RoleRow/index.js
index 0eb3b95d97..eaef194057 100644
--- a/packages/core/admin/admin/src/pages/SettingsPage/pages/Roles/ListPage/components/RoleRow/index.js
+++ b/packages/core/admin/admin/src/pages/SettingsPage/pages/Roles/ListPage/components/RoleRow/index.js
@@ -5,7 +5,7 @@ import { Flex } from '@strapi/design-system/Flex';
 import { Td, Tr } from '@strapi/design-system/Table';
 import { Text, EllipsisText } from '@strapi/design-system/Text';
 import { IconButton } from '@strapi/design-system/IconButton';
-import { stopPropagation, onRowClick } from '@strapi/helper-plugin';
+import { stopPropagation, onRowClick, pxToRem } from '@strapi/helper-plugin';
 import { useIntl } from 'react-intl';
 
 const RoleRow = ({ id, name, description, usersCount, icons }) => {
@@ -26,10 +26,10 @@ const RoleRow = ({ id, name, description, usersCount, icons }) => {
         fn: icons[1].onClick,
       })}
     >
-      <Td maxWidth={`${130 / 16}rem`}>
+      <Td maxWidth={pxToRem(130)}>
         <EllipsisText textColor="neutral800">{name}</EllipsisText>
       </Td>
-      <Td maxWidth={`${250 / 16}rem`}>
+      <Td maxWidth={pxToRem(250)}>
         <EllipsisText textColor="neutral800">{description}</EllipsisText>
       </Td>
       <Td>