yujunjun/strapi
1
0
Fork 0
mirror of https://github.com/strapi/strapi.git synced 2025-10-31 18:08:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix PR feedback

Browse Source 
Signed-off-by: soupette <cyril@strapi.io>
This commit is contained in:
soupette 2021-08-19 09:42:19 +02:00
parent 48239ab116
commit 393bf5f1be
9 changed files with 24 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
packages/core/admin/admin/src/utils/createRoute.js
View File

@ -18,8 +18,7 @@ const LazyCompo = ({ loadComponent }) => {
};
loadCompo();
// eslint-disable-next-line react-hooks/exhaustive-deps
}, []);
}, [loadComponent]);
if (Compo) {
return <Compo />;

4
packages/core/admin/ee/admin/pages/SettingsPage/utils/customRoutes.js
View File

@ -2,7 +2,9 @@ const ssoRoutes = strapi.features.isEnabled(strapi.features.SSO)
? [
{
Component: async () => {
const component = await import(/* webpackChunkName: "sso" */ '../SingleSignOn');
const component = await import(
/* webpackChunkName: "sso-settings-page" */ '../SingleSignOn'
);
return component;
},

2
packages/core/email/admin/src/index.js
View File

@ -34,7 +34,7 @@ export default {
to: `/settings/${pluginId}`,
Component: async () => {
const component = await import(
/* webpackChunkName: "email-settings" */ './pages/Settings'
/* webpackChunkName: "email-settings-page" */ './pages/Settings'
);
return component;

2
packages/plugins/documentation/admin/src/index.js
View File

@ -25,7 +25,7 @@ export default {
},
permissions: pluginPermissions.main,
Component: async () => {
const component = await import(/* webpackChunkName: "documentation" */ './pages/App');
const component = await import(/* webpackChunkName: "documentation-page" */ './pages/App');
return component;
},

7
packages/plugins/documentation/admin/src/pages/HomePage/index.js
View File

@ -90,10 +90,17 @@ const HomePage = () => {
setVersionToDelete(null);
};
console.log(data);
if (isLoading) {
return <LoadingIndicatorPage />;
}
// FIXME
if (!data) {
return null;
}
return (
<ContainerFluid className="container-fluid">
<PopUpWarning

2
packages/plugins/i18n/admin/src/index.js
View File

@ -66,7 +66,7 @@ export default {
Component: async () => {
const component = await import(
/* webpackChunkName: "i18n-settings" */ './pages/SettingsPage'
/* webpackChunkName: "i18n-settings-page" */ './pages/SettingsPage'
);
return component;

10
packages/plugins/users-permissions/admin/src/index.js
View File

@ -35,7 +35,9 @@ export default {
id: 'roles',
to: `/settings/${pluginId}/roles`,
Component: async () => {
const component = await import(/* webpackChunkName: "users-roles" */ './pages/Roles');
const component = await import(
/* webpackChunkName: "users-roles-settings-page" */ './pages/Roles'
);
return component;
},
@ -50,7 +52,7 @@ export default {
to: `/settings/${pluginId}/providers`,
Component: async () => {
const component = await import(
/* webpackChunkName: "users-providers" */ './pages/Providers'
/* webpackChunkName: "users-providers-settings-page" */ './pages/Providers'
);
return component;
@ -66,7 +68,7 @@ export default {
to: `/settings/${pluginId}/email-templates`,
Component: async () => {
const component = await import(
/* webpackChunkName: "users-email" */ './pages/EmailTemplates'
/* webpackChunkName: "users-email-settings-page" */ './pages/EmailTemplates'
);
return component;
@ -82,7 +84,7 @@ export default {
to: `/settings/${pluginId}/advanced-settings`,
Component: async () => {
const component = await import(
/* webpackChunkName: "users-advanced-settings" */ './pages/AdvancedSettings'
/* webpackChunkName: "users-advanced-settings-page" */ './pages/AdvancedSettings'
);
return component;

4
packages/plugins/users-permissions/admin/src/pages/AdvancedSettings/index.js
View File

@ -19,7 +19,7 @@ import ListBaselineAlignment from '../../components/ListBaselineAlignment';
import form from './utils/form';
import reducer, { initialState } from './reducer';
const Protected = () => (
const ProtectedAdvancedSettingsPage = () => (
<CheckPagePermissions permissions={pluginPermissions.readAdvancedSettings}>
<AdvancedSettingsPage />
</CheckPagePermissions>
@ -224,4 +224,4 @@ const AdvancedSettingsPage = () => {
);
};
export default Protected;
export default ProtectedAdvancedSettingsPage;

4
packages/plugins/users-permissions/admin/src/pages/EmailTemplates/index.js
View File

@ -23,7 +23,7 @@ import { getRequestURL, getTrad } from '../../utils';
import forms from './utils/forms';
import schema from './utils/schema';
const Protected = () => (
const ProtectedEmailTemplatesPage = () => (
<CheckPagePermissions permissions={pluginPermissions.readEmailTemplates}>
<EmailTemplatesPage />
</CheckPagePermissions>
@ -239,4 +239,4 @@ const EmailTemplatesPage = () => {
);
};
export default Protected;
export default ProtectedEmailTemplatesPage;