From 3da6faac05d917a73dd999982fe890117b6bfb51 Mon Sep 17 00:00:00 2001 From: cyril lopez Date: Fri, 8 Dec 2017 14:40:42 +0100 Subject: [PATCH] Fix feedback PR --- .../config/policies/permissions.js | 3 --- .../services/UsersPermissions.js | 7 +------ 2 files changed, 1 insertion(+), 9 deletions(-) diff --git a/packages/strapi-plugin-users-permissions/config/policies/permissions.js b/packages/strapi-plugin-users-permissions/config/policies/permissions.js index f9fc00dd04..5df755c21e 100644 --- a/packages/strapi-plugin-users-permissions/config/policies/permissions.js +++ b/packages/strapi-plugin-users-permissions/config/policies/permissions.js @@ -18,9 +18,6 @@ module.exports = async (ctx, next) => { } const permission = _.get(strapi.plugins['users-permissions'].config, ['roles', role.toString(), 'permissions', route.plugin || 'application', 'controllers', route.controller, route.action]); - console.log(permission); - console.log('---') - console.log(role); if (!permission) { return await next(); diff --git a/packages/strapi-plugin-users-permissions/services/UsersPermissions.js b/packages/strapi-plugin-users-permissions/services/UsersPermissions.js index 7fec3045d0..2fbcdf4510 100644 --- a/packages/strapi-plugin-users-permissions/services/UsersPermissions.js +++ b/packages/strapi-plugin-users-permissions/services/UsersPermissions.js @@ -14,12 +14,7 @@ const _ = require('lodash'); module.exports = { createRole: (role) => { const appRoles = strapi.plugins['users-permissions'].config.roles; - const highestId = _.last(Object.keys(appRoles).reduce((acc, key) => { - acc.push(_.toNumber(key)); - - return acc; - }, []).sort()) + 1; - + const highestId = Math.max(...Object.keys(appRoles).map(Number)) + 1; const newRole = _.pick(role, ['name', 'description', 'permissions']); _.set(appRoles, highestId.toString(), newRole);