From 405272eadfa25d00e20038d97149bf90a083f9eb Mon Sep 17 00:00:00 2001
From: cyril lopez <cyril.lpz@gmail.com>
Date: Thu, 18 Jan 2018 17:27:59 +0100
Subject: [PATCH] Refacto onChange action

---
 .../admin/src/containers/HomePage/actions.js               | 2 +-
 .../admin/src/containers/HomePage/index.js                 | 7 +------
 .../admin/src/containers/HomePage/reducer.js               | 2 +-
 .../admin/src/containers/HomePage/saga.js                  | 7 +++----
 4 files changed, 6 insertions(+), 12 deletions(-)

diff --git a/packages/strapi-plugin-users-permissions/admin/src/containers/HomePage/actions.js b/packages/strapi-plugin-users-permissions/admin/src/containers/HomePage/actions.js
index 1e55978301..58942b992d 100755
--- a/packages/strapi-plugin-users-permissions/admin/src/containers/HomePage/actions.js
+++ b/packages/strapi-plugin-users-permissions/admin/src/containers/HomePage/actions.js
@@ -55,7 +55,7 @@ export function fetchDataSucceeded(data) {
 export function onChange({ target }) {
   return {
     type: ON_CHANGE,
-    key: target.name,
+    keys: ['modifiedData'].concat(target.name.split('.')),
     value: target.value,
   };
 }
diff --git a/packages/strapi-plugin-users-permissions/admin/src/containers/HomePage/index.js b/packages/strapi-plugin-users-permissions/admin/src/containers/HomePage/index.js
index a9dc2dd7c6..e8448fd963 100755
--- a/packages/strapi-plugin-users-permissions/admin/src/containers/HomePage/index.js
+++ b/packages/strapi-plugin-users-permissions/admin/src/containers/HomePage/index.js
@@ -129,12 +129,7 @@ export class HomePage extends React.Component {
 
     return (
       <div>
-        <form
-          onSubmit={(e) => {
-            e.preventDefault();
-            this.props.submit(match.params.settingType);
-          }}
-        >
+        <form onSubmit={(e) => e.preventDefault()}>
           <div className={cn('container-fluid', styles.containerFluid)}>
             <PluginHeader
               title={{ id: 'users-permissions.HomePage.header.title' }}
diff --git a/packages/strapi-plugin-users-permissions/admin/src/containers/HomePage/reducer.js b/packages/strapi-plugin-users-permissions/admin/src/containers/HomePage/reducer.js
index 4649845e6c..f65b5227e0 100755
--- a/packages/strapi-plugin-users-permissions/admin/src/containers/HomePage/reducer.js
+++ b/packages/strapi-plugin-users-permissions/admin/src/containers/HomePage/reducer.js
@@ -42,7 +42,7 @@ function homePageReducer(state = initialState, action) {
       return state.set('data', List(action.data));
     case ON_CHANGE:
       return state
-        .updateIn(['modifiedData', action.key], () => action.value);
+        .updateIn(action.keys, () => action.value);
     case SET_FORM:
       return state
         .set('initialData', action.form)
diff --git a/packages/strapi-plugin-users-permissions/admin/src/containers/HomePage/saga.js b/packages/strapi-plugin-users-permissions/admin/src/containers/HomePage/saga.js
index 65999c804d..719b3dd03c 100755
--- a/packages/strapi-plugin-users-permissions/admin/src/containers/HomePage/saga.js
+++ b/packages/strapi-plugin-users-permissions/admin/src/containers/HomePage/saga.js
@@ -67,11 +67,10 @@ export function* submitData(action) {
   try {
     const body = yield select(makeSelectModifiedData());
     const opts = { method: 'PUT', body };
-    const response = yield call(request, `/users-permissions/${action.endPoint}`, opts, true);
 
-    if (response.ok) {
-      yield put(submitSucceeded());
-    }
+    yield call(request, `/users-permissions/${action.endPoint}`, opts, true);
+    yield put(submitSucceeded());
+
   } catch(error) {
     strapi.notification.error('notification.error');
   }