yujunjun/strapi
1
0
Fork 0
mirror of https://github.com/strapi/strapi.git synced 2025-11-03 03:17:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix PR feedback

Browse Source 
Signed-off-by: soupette <cyril.lpz@gmail.com>
This commit is contained in:
soupette 2020-01-30 18:18:35 +01:00
parent f6d8f51df3
commit 4153fe9b7b
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
docs/3.0.0-beta.x/plugin-development/frontend-settings-api.md
View File

@ -80,11 +80,11 @@ export default strapi => {
}; };
``` ```
At this point, the plugin creates a new section (**_Super cool setting_**) which will contains two links `Setting page 1` and `Setting page 2` these links doesn't point to any component as the corresponding as not been declared yet. At this point, the plugin creates a new section (**_Super cool setting_**) which will contains two links `Setting page 1` and `Setting page 2` these links don't point to any component as the corresponding one as not been declared yet.
### Declaring the setting Component ### Declaring the setting Component
The exported Setting component which receives `settingsBaseURL` as props in order to generate a dynamic routing which should be used to associated the two endpoints created with their corresponding components. The exported Setting component which receives `settingsBaseURL` as props in order to generate a dynamic routing which should be used to associate the two endpoints created with their corresponding components.
With the configuration from above we could easily create our plugin Settings view. With the configuration from above we could easily create our plugin Settings view.

2
packages/strapi-admin/admin/src/containers/Admin/index.js
View File

@ -183,7 +183,7 @@ export class Admin extends React.Component {
render={props => this.renderRoute(props, Marketplace)} render={props => this.renderRoute(props, Marketplace)}
/> />
<Route <Route
path="/settings/:settingId" path={`${SETTINGS_BASE_URL}/:settingId`}
render={props => this.renderRoute(props, SettingsPage)} render={props => this.renderRoute(props, SettingsPage)}
/> />
<Route <Route