From 506cf9e15b4dd033e2c1523744af97ab97e8aa53 Mon Sep 17 00:00:00 2001 From: Luan Date: Fri, 4 Mar 2022 18:57:14 -0300 Subject: [PATCH] refactor: apply review suggestion of generic parsing --- packages/core/utils/lib/convert-query-params.js | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/packages/core/utils/lib/convert-query-params.js b/packages/core/utils/lib/convert-query-params.js index cd0e428ea4..6e5102b06e 100644 --- a/packages/core/utils/lib/convert-query-params.js +++ b/packages/core/utils/lib/convert-query-params.js @@ -4,7 +4,7 @@ * Converts the standard Strapi REST query params to a more usable format for querying * You can read more here: https://docs.strapi.io/developer-docs/latest/developer-resources/database-apis-reference/rest-api.html#filters */ -const { has, isEmpty, isObject, cloneDeep, get } = require('lodash/fp'); +const { has, isEmpty, isObject, isPlainObject, cloneDeep, get } = require('lodash/fp'); const _ = require('lodash'); const parseType = require('./parse-type'); const contentTypesUtils = require('./content-types'); @@ -286,7 +286,7 @@ const convertFiltersQueryParams = (filters, schema) => { }; const convertAndSanitizeFilters = (filters, schema) => { - if (!isObject(filters)) { + if (!isPlainObject(filters)) { return filters; } @@ -339,11 +339,6 @@ const convertAndSanitizeFilters = (filters, schema) => { } } - // Handle dates - else if (value instanceof Date) { - return filters; - } - // Handle operators else { if (['$null', '$notNull'].includes(key)) { @@ -354,7 +349,7 @@ const convertAndSanitizeFilters = (filters, schema) => { } // Remove empty objects & arrays - if (isObject(filters[key]) && isEmpty(filters[key])) { + if (isPlainObject(filters[key]) && isEmpty(filters[key])) { removeOperator(key); } }