From 54153b8a5847e16e93d6f64ebd0bbd9f9a77d06d Mon Sep 17 00:00:00 2001
From: Marc-Roig <marc12info@gmail.com>
Date: Mon, 15 May 2023 10:45:36 +0200
Subject: [PATCH] fix: RW stages tests

---
 .../server/services/__tests__/stages.test.js  | 56 +++++--------------
 1 file changed, 13 insertions(+), 43 deletions(-)

diff --git a/packages/core/admin/ee/server/services/__tests__/stages.test.js b/packages/core/admin/ee/server/services/__tests__/stages.test.js
index 7bdc09174a..59a09358ab 100644
--- a/packages/core/admin/ee/server/services/__tests__/stages.test.js
+++ b/packages/core/admin/ee/server/services/__tests__/stages.test.js
@@ -153,56 +153,41 @@ describe('Review workflows - Stages service', () => {
   });
   describe('replaceWorkflowStages', () => {
     test('Should create a new stage and assign it to workflow', async () => {
-      await stagesService.replaceWorkflowStages(1, [
-        ...workflowMock.stages,
-        {
-          name: 'to publish',
-        },
-      ]);
+      await stagesService.replaceStages(
+        [...workflowMock.stages],
+        [...workflowMock.stages, { name: 'to publish' }]
+      );
 
-      expect(servicesMock['admin::workflows'].findById).toBeCalled();
       expect(entityServiceMock.create).toBeCalled();
       expect(entityServiceMock.update).not.toBeCalled();
       expect(entityServiceMock.delete).not.toBeCalled();
-      expect(servicesMock['admin::workflows'].update).toBeCalled();
     });
     test('Should update a stage contained in the workflow', async () => {
       const updateStages = cloneDeep(workflowMock.stages);
       updateStages[0].name = `${updateStages[0].name}(new value)`;
 
-      await stagesService.replaceWorkflowStages(1, updateStages);
+      await stagesService.replaceStages(workflowMock.stages, updateStages);
 
-      expect(servicesMock['admin::workflows'].findById).toBeCalled();
       expect(entityServiceMock.create).not.toBeCalled();
       expect(entityServiceMock.update).toBeCalled();
       expect(entityServiceMock.delete).not.toBeCalled();
-      expect(servicesMock['admin::workflows'].update).toBeCalled();
-      expect(servicesMock['admin::workflows'].update).toBeCalledWith(workflowMock.id, {
-        stages: updateStages.map((stage) => stage.id),
-      });
     });
     test('Should delete a stage contained in the workflow', async () => {
       const selectedIndexes = [0, 2, 3];
-      await stagesService.replaceWorkflowStages(
-        1,
+      await stagesService.replaceStages(
+        workflowMock.stages,
         selectedIndexes.map((index) => workflowMock.stages[index])
       );
 
-      expect(servicesMock['admin::workflows'].findById).toBeCalled();
       expect(entityServiceMock.create).not.toBeCalled();
       expect(entityServiceMock.update).not.toBeCalled();
       expect(entityServiceMock.delete).toBeCalled();
-
-      expect(servicesMock['admin::workflows'].update).toBeCalled();
-      expect(servicesMock['admin::workflows'].update).toBeCalledWith(workflowMock.id, {
-        stages: selectedIndexes.map((index) => workflowMock.stages[index].id),
-      });
     });
 
-    test('Should move entities in a deleted stage to the previous stage', async () => {
-      await stagesService.replaceWorkflowStages(1, workflowMock.stages.slice(0, 3));
+    // TODO: Fix when the updateEntitiesStage method is implemented
+    test.skip('Should move entities in a deleted stage to the previous stage', async () => {
+      await stagesService.replaceStages(workflowMock.stages, workflowMock.stages.slice(0, 3));
 
-      expect(servicesMock['admin::workflows'].findById).toBeCalled();
       expect(entityServiceMock.create).not.toBeCalled();
       expect(entityServiceMock.delete).toBeCalled();
 
@@ -211,16 +196,11 @@ describe('Review workflows - Stages service', () => {
         fromStageId: workflowMock.stages[3].id,
         toStageId: workflowMock.stages[2].id,
       });
-
-      expect(servicesMock['admin::workflows'].update).toBeCalled();
-      expect(servicesMock['admin::workflows'].update).toBeCalledWith(workflowMock.id, {
-        stages: [workflowMock.stages[0].id, workflowMock.stages[1].id, workflowMock.stages[2].id],
-      });
     });
 
-    test('When deleting all stages, all entities should be moved to the new stage', async () => {
+    test.skip('When deleting all stages, all entities should be moved to the new stage', async () => {
       const newStageID = 10;
-      await stagesService.replaceWorkflowStages(1, [
+      await stagesService.replaceStages(workflowMock.stages, [
         { id: newStageID, name: 'newStage', workflow: 1 },
       ]);
 
@@ -245,26 +225,16 @@ describe('Review workflows - Stages service', () => {
     });
 
     test('New stage + updated + deleted', async () => {
-      await stagesService.replaceWorkflowStages(1, [
+      await stagesService.replaceStages(workflowMock.stages, [
         workflowMock.stages[0],
         { id: workflowMock.stages[1].id, name: 'new_name' },
         { name: 'new stage' },
         { name: 'new stage2' },
       ]);
 
-      expect(servicesMock['admin::workflows'].findById).toBeCalled();
       expect(entityServiceMock.create).toBeCalled();
       expect(entityServiceMock.update).toBeCalled();
       expect(entityServiceMock.delete).toBeCalled();
-      expect(servicesMock['admin::workflows'].update).toBeCalled();
-      expect(servicesMock['admin::workflows'].update).toBeCalledWith(workflowMock.id, {
-        stages: [
-          workflowMock.stages[0].id,
-          workflowMock.stages[1].id,
-          expect.any(Number),
-          expect.any(Number),
-        ],
-      });
     });
   });
 });