From 587e4450b7c63a5060b60bd93b788986539d6243 Mon Sep 17 00:00:00 2001 From: Virginie Ky Date: Tue, 26 Nov 2019 16:24:53 +0100 Subject: [PATCH] PR review apply --- packages/strapi-admin/admin/src/containers/Admin/saga.js | 4 +--- .../admin/src/components/SettingsViewWrapper/index.js | 4 ++-- .../admin/src/components/SortWrapper/index.js | 8 +------- .../admin/src/components/ListRow/index.js | 2 +- 4 files changed, 5 insertions(+), 13 deletions(-) diff --git a/packages/strapi-admin/admin/src/containers/Admin/saga.js b/packages/strapi-admin/admin/src/containers/Admin/saga.js index b67ed5ab0e..3ad2902db8 100644 --- a/packages/strapi-admin/admin/src/containers/Admin/saga.js +++ b/packages/strapi-admin/admin/src/containers/Admin/saga.js @@ -22,9 +22,7 @@ export function* emitter(action) { } ); } - } catch (err) { - console.log(err); // eslint-disable-line no-console - } + } catch (err) {} } // Individual exports for testing diff --git a/packages/strapi-plugin-content-manager/admin/src/components/SettingsViewWrapper/index.js b/packages/strapi-plugin-content-manager/admin/src/components/SettingsViewWrapper/index.js index a070b19c04..289406f4a0 100644 --- a/packages/strapi-plugin-content-manager/admin/src/components/SettingsViewWrapper/index.js +++ b/packages/strapi-plugin-content-manager/admin/src/components/SettingsViewWrapper/index.js @@ -228,6 +228,7 @@ SettingsViewWrapper.defaultProps = { initialData: {}, isEditSettings: false, modifiedData: {}, + name: '', onConfirmReset: () => {}, onConfirmSubmit: async () => {}, onSubmit: () => {}, @@ -241,7 +242,6 @@ SettingsViewWrapper.defaultProps = { values: {}, }, }, - name: '', }; SettingsViewWrapper.propTypes = { @@ -255,6 +255,7 @@ SettingsViewWrapper.propTypes = { isEditSettings: PropTypes.bool, isLoading: PropTypes.bool.isRequired, modifiedData: PropTypes.object, + name: PropTypes.string, onChange: PropTypes.func.isRequired, onConfirmReset: PropTypes.func, onConfirmSubmit: PropTypes.func, @@ -269,7 +270,6 @@ SettingsViewWrapper.propTypes = { values: PropTypes.object, }), }), - name: PropTypes.string, }; export default withRouter(SettingsViewWrapper); diff --git a/packages/strapi-plugin-content-manager/admin/src/components/SortWrapper/index.js b/packages/strapi-plugin-content-manager/admin/src/components/SortWrapper/index.js index 1409f671fa..5c6befa485 100644 --- a/packages/strapi-plugin-content-manager/admin/src/components/SortWrapper/index.js +++ b/packages/strapi-plugin-content-manager/admin/src/components/SortWrapper/index.js @@ -1,11 +1,5 @@ import styled from 'styled-components'; -const SortWrapper = styled.div` - // &:after { - // content: ''; - // clear: both; - // display: table; - // } -`; +const SortWrapper = styled.div``; export default SortWrapper; diff --git a/packages/strapi-plugin-users-permissions/admin/src/components/ListRow/index.js b/packages/strapi-plugin-users-permissions/admin/src/components/ListRow/index.js index f9add0cf54..8d2955d8ae 100644 --- a/packages/strapi-plugin-users-permissions/admin/src/components/ListRow/index.js +++ b/packages/strapi-plugin-users-permissions/admin/src/components/ListRow/index.js @@ -69,7 +69,7 @@ class ListRow extends React.Component { ); case 'providers': icons.pop(); // Remove the icon-trash - console.log(this.props.item.key); + return (