yujunjun/strapi
1
0
Fork 0
mirror of https://github.com/strapi/strapi.git synced 2026-01-03 10:46:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

cleanup

Browse Source
This commit is contained in:
Ben Irvin 2022-08-01 10:22:32 +02:00
parent b3133075e9
commit 59b34420d7
1 changed files with 3 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
packages/core/permissions/lib/__tests__/permissions.engine.test.js
View File

@ -185,22 +185,8 @@ describe('Permissions Engine', () => {
conditions: undefined,
});
});
// it.only('registers action when conditions are met with subject', async () => {
// const { ability } = await buildEngineWithAbility({
// permissions: [{ action: 'read', subject: 'article', conditions: ['isOwner'] }],
// });
// expect(ability.can('read', 'article')).toBeTruthy();
// expect(ability.can('read', subject('article', { id: 123 }))).toBeTruthy();
// });
});
// TODO: test all hooks are called at the right time and bail correctly
// 'before-format::validate.permission': hooks.createAsyncBailHook(),
// 'format.permission': hooks.createAsyncSeriesWaterfallHook(),
// 'post-format::validate.permission': hooks.createAsyncBailHook(),
// 'before-evaluate.permission': hooks.createAsyncSeriesHook(),
// 'before-register.permission': hooks.createAsyncSeriesHook(),
describe('hooks', () => {
it('format.permission can modify permissions', async () => {
const permissions = [{ action: 'read', subject: 'article' }];
@ -224,8 +210,7 @@ describe('Permissions Engine', () => {
expect(registerFunctions[0]).toBeCalledWith(replacePermission);
});
// TODO: rewrite with mocks
it('validate hooks are called at the right time', async () => {
it('validate hooks are called in the right order', async () => {
const permissions = [{ action: 'update' }, { action: 'delete' }, { action: 'view' }];
const { ability } = await buildEngineWithAbility({
permissions,
@ -314,7 +299,7 @@ describe('Permissions Engine', () => {
expect(called).toEqual('beforeEvaluate');
called = 'beforeRegister';
});
const permissions = [{ action: 'read', subject: 'article' }];
const permissions = [{ action: 'read', subject: 'article', conditions: [allowedCondition] }];
await buildEngineWithAbility({
permissions,
engineHooks: [
@ -338,7 +323,7 @@ describe('Permissions Engine', () => {
expect(beforeRegisterFn).toBeCalledWith({
condition: expect.any(Object),
createRegisterFunction: expect.anything(),
permission: permissions[0],
permission: { ...permissions[0], conditions: undefined },
});
expect(called).toEqual('beforeRegister');
});