feedback improvements handleChange

examples/getstarted/src/api/aanother-test/content-types/aanother-test/schema.json

@@ -0,0 +1,41 @@
+{
+  "kind": "collectionType",
+  "collectionName": "aanother_tests",
+  "info": {
+    "singularName": "aanother-test",
+    "pluralName": "aanother-tests",
+    "displayName": "Aanother test"
+  },
+  "options": {
+    "draftAndPublish": true
+  },
+  "pluginOptions": {},
+  "attributes": {
+    "text": {
+      "type": "string",
+      "unique": true
+    },
+    "email": {
+      "type": "email",
+      "unique": true
+    },
+    "number": {
+      "unique": true,
+      "type": "integer"
+    },
+    "uid": {
+      "type": "uid"
+    },
+    "date": {
+      "unique": true,
+      "type": "date"
+    },
+    "enum": {
+      "type": "enumeration",
+      "enum": [
+        "this",
+        "or that"
+      ]
+    }
+  }
+}

examples/getstarted/src/api/aanother-test/controllers/aanother-test.js

@@ -0,0 +1,9 @@
+'use strict';
+
+/**
+ *  aanother-test controller
+ */
+
+const { createCoreController } = require('@strapi/strapi').factories;
+
+module.exports = createCoreController('api::aanother-test.aanother-test');

examples/getstarted/src/api/aanother-test/routes/aanother-test.js

@@ -0,0 +1,9 @@
+'use strict';
+
+/**
+ * aanother-test router.
+ */
+
+const { createCoreRouter } = require('@strapi/strapi').factories;
+
+module.exports = createCoreRouter('api::aanother-test.aanother-test');

examples/getstarted/src/api/aanother-test/services/aanother-test.js

@@ -0,0 +1,9 @@
+'use strict';
+
+/**
+ * aanother-test service.
+ */
+
+const { createCoreService } = require('@strapi/strapi').factories;
+
+module.exports = createCoreService('api::aanother-test.aanother-test');

packages/core/admin/admin/src/content-manager/components/EditViewDataManagerProvider/index.js

@@ -235,21 +235,12 @@ const EditViewDataManagerProvider = ({
 
       // Allow to reset text, string, email, uid, select/enum, date
       if (
-        (type === 'text' ||
+        ['text', 'string', 'email', 'uid', 'select', 'select-one', 'number'].includes(type) &&
-          type === 'string' ||
+        !value
-          type === 'email' ||
-          type === 'uid' ||
-          type === 'select' ||
-          type === 'select-one') &&
-        value === ''
       ) {
         inputValue = null;
       }
 
-      if (type === 'number' && !value) {
-        inputValue = null;
-      }
-
       if (type === 'password' && !value) {
         dispatch({
           type: 'REMOVE_PASSWORD_FIELD',
@@ -259,6 +250,8 @@ const EditViewDataManagerProvider = ({
         return;
       }
 
+      console.log({ name, inputValue });
+
       dispatch({
         type: 'ON_CHANGE',
         keys: name.split('.'),

packages/core/helper-plugin/lib/src/components/GenericInput/tests/index.test.js

@@ -110,16 +110,5 @@ describe('GenericInput', () => {
         target: { name: 'number', type: 'number', value: 0 },
       });
     });
-
-    test('does call onChange callback with undefined on empty value', () => {
-      const spy = jest.fn();
-      const { input } = setupNumber({ value: 1, onChange: spy });
-
-      fireEvent.change(input, { target: { value: '' } });
-
-      expect(spy).toHaveBeenCalledWith({
-        target: { name: 'number', type: 'number', value: undefined },
-      });
-    });
   });
 });