yujunjun/strapi
1
0
Fork 0
mirror of https://github.com/strapi/strapi.git synced 2025-11-03 19:36:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #10933 from strapi/fix-hopmepage-a11y-issues

Browse Source 
Fix homepage small a11y issues
This commit is contained in:
cyril lopez 2021-09-13 07:00:18 +02:00 committed by GitHub
commit 62c269ba2b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/core/admin/admin/src/pages/HomePage/SocialLinks.js
View File

@ -88,6 +88,8 @@ const SocialLinks = () => {
return ( return (
<Box <Box
as="aside"
aria-labelledby="join-the-community"
background="neutral0" background="neutral0"
hasRadius hasRadius
paddingRight={5} paddingRight={5}
@ -99,7 +101,7 @@ const SocialLinks = () => {
<Box paddingBottom={7}> <Box paddingBottom={7}>
<Stack size={5}> <Stack size={5}>
<Stack size={3}> <Stack size={3}>
<H3> <H3 as="h2" id="join-the-community">
{formatMessage({ {formatMessage({
id: 'app.components.HomePage.community', id: 'app.components.HomePage.community',
defaultMessage: 'Join the community', defaultMessage: 'Join the community',

2
packages/core/admin/admin/src/pages/HomePage/index.js
View File

@ -60,7 +60,7 @@ const HomePage = () => {
</FormattedMessage> </FormattedMessage>
<Main labelledBy="homepage"> <Main labelledBy="homepage">
<LogoContainer> <LogoContainer>
<img alt="Strapi logo" src={Logo} /> <img alt="" aria-hidden src={Logo} />
</LogoContainer> </LogoContainer>
<Box padding={10}> <Box padding={10}>
<Grid> <Grid>

10
packages/core/admin/admin/src/pages/HomePage/tests/index.test.js
View File

@ -917,7 +917,8 @@ describe('Homepage', () => {
<div <div
class="" class=""
> >
<div <aside
aria-labelledby="join-the-community"
class="c34" class="c34"
> >
<div <div
@ -929,11 +930,12 @@ describe('Homepage', () => {
<div <div
class="c36" class="c36"
> >
<h3 <h2
class="c37" class="c37"
id="join-the-community"
> >
Join the community Join the community
</h3> </h2>
<span <span
class="c12 c38" class="c12 c38"
> >
@ -1288,7 +1290,7 @@ describe('Homepage', () => {
</div> </div>
</div> </div>
</div> </div>
</div> </aside>
</div> </div>
</div> </div>
</div> </div>