yujunjun/strapi
1
0
Fork 0
mirror of https://github.com/strapi/strapi.git synced 2025-09-26 00:39:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(helper-plugin): BigInt mistake

Browse Source
This commit is contained in:
Jamie Howard 2023-01-20 08:44:18 +00:00
parent 98fdd17fcd
commit 688baffb9c
3 changed files with 3 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/core/helper-plugin/lib/src/components/GenericInput/index.js
View File

@ -56,7 +56,7 @@ const GenericInput = ({
description, description,
minimum, minimum,
maximum, maximum,
units: getFieldUnits({ type, name, minimum, maximum }), units: getFieldUnits({ type, minimum, maximum }),
}); });
const [showPassword, setShowPassword] = useState(false); const [showPassword, setShowPassword] = useState(false);

5
packages/core/helper-plugin/lib/src/components/GenericInput/utils/getFieldUnits.js
View File

@ -1,12 +1,11 @@
/** /**
* @param {String} type * @param {String} type
* @param {String} name
* @param {Number} minimum * @param {Number} minimum
* @param {Number} maximum * @param {Number} maximum
* @returns {'' | 'characters' | 'character'} * @returns {'' | 'characters' | 'character'}
*/ */
const getFieldUnits = ({ type, name, minimum, maximum }) => { const getFieldUnits = ({ type, minimum, maximum }) => {
if (type === 'number' || name === 'BIGINT') { if (type === 'number') {
return ''; return '';
} }
const plural = Math.max(minimum || 0, maximum || 0) > 1; const plural = Math.max(minimum || 0, maximum || 0) > 1;

4
packages/core/helper-plugin/lib/src/components/GenericInput/utils/tests/getFieldUnits.test.js
View File

@ -6,10 +6,6 @@ describe('Content Manager | Inputs | Utils', () => {
expect(getFieldUnits({ type: 'number' })).toEqual(''); expect(getFieldUnits({ type: 'number' })).toEqual('');
}); });
it('returns <empty string> for BIGINT types', () => {
expect(getFieldUnits({ name: 'BIGINT' })).toEqual('');
});
it('returns "character" when neither minimum or maximum is greater than 1', () => { it('returns "character" when neither minimum or maximum is greater than 1', () => {
expect(getFieldUnits({ type: 'text', minimum: 1, maximum: 1 })).toEqual('character'); expect(getFieldUnits({ type: 'text', minimum: 1, maximum: 1 })).toEqual('character');
}); });