From 7b4ac52a4983b03554d50c36e598f9e6b889a0b1 Mon Sep 17 00:00:00 2001 From: Fernando Chavez Date: Wed, 19 Jun 2024 11:32:59 +0200 Subject: [PATCH] fix(core): disallow required on relation fields on schemas --- packages/core/core/src/services/entity-validator/index.ts | 5 ----- .../core/src/utils/transform-content-types-to-models.ts | 7 +++++++ 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/packages/core/core/src/services/entity-validator/index.ts b/packages/core/core/src/services/entity-validator/index.ts index c356851874..7228fade6e 100644 --- a/packages/core/core/src/services/entity-validator/index.ts +++ b/packages/core/core/src/services/entity-validator/index.ts @@ -216,11 +216,6 @@ const createRelationValidator = validator = yup.mixed(); } - validator = addRequiredValidation(createOrUpdate)(validator, { - attr: { required: !isDraft && attr.required }, - updatedAttribute, - }); - return validator; }; diff --git a/packages/core/core/src/utils/transform-content-types-to-models.ts b/packages/core/core/src/utils/transform-content-types-to-models.ts index 7ad5b4184c..7127ab9d37 100644 --- a/packages/core/core/src/utils/transform-content-types-to-models.ts +++ b/packages/core/core/src/utils/transform-content-types-to-models.ts @@ -158,6 +158,13 @@ export const transformAttribute = ( }, }; } + case 'relation': { + if (attribute.required) { + throw new Error( + `Required relations are not supported, please remove it from ${contentType.collectionName} schema on the attribute ${name}` + ); + } + } default: { return attribute; }