yujunjun/strapi
1
0
Fork 0
mirror of https://github.com/strapi/strapi.git synced 2025-11-03 11:25:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixed tests

Browse Source
This commit is contained in:
Rémi de Juvigny 2021-01-22 18:26:25 +01:00
parent db849d99ba
commit 7e070b0f65
2 changed files with 78 additions and 81 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

157
packages/strapi-plugin-sentry/services/__tests__/sentry.test.js
View File

@ -1,27 +1,34 @@
'use strict';
jest.resetModules();
const INVALID_DSN = 'an_invalid_dsn';
const VALID_DSN = 'a_valid_dsn';
const captureException = jest.fn();
jest.mock('@sentry/node', () => {
return {
init() {
console.log('MOCKING SENTRY INIT');
init(options = {}) {
if (options.dsn !== VALID_DSN) {
throw Error();
}
},
captureException,
withScope(configureScope) {
configureScope();
},
};
});
const sentryService = require('../sentry');
let sentryService = require('../sentry');
const defaultConfig = require('../../config/settings.json');
describe('test', () => {
describe('strapi-plugin-sentry service', () => {
beforeEach(() => {
// Reset Strapi state
global.strapi = {
config: {},
plugins: {
sentry: {
config: {
...defaultConfig,
dsn: 'fakedsn',
},
config: defaultConfig,
},
},
log: {
@ -29,77 +36,69 @@ describe('test', () => {
info: jest.fn(),
},
};
// Reset the plugin resource state
jest.resetModules();
sentryService = require('../sentry');
});
it('init', async () => {
it('disables Sentry when no DSN is provided', () => {
sentryService.init();
expect(strapi.log.info).toHaveBeenCalledWith(expect.stringMatching(/disabled/i));
const instance = sentryService.getInstance();
expect(instance).toBeNull();
});
it('disables Sentry when an invalid DSN is provided', () => {
global.strapi.plugins.sentry.config = {
dsn: INVALID_DSN,
};
sentryService.init();
expect(strapi.log.warn).toHaveBeenCalledWith(expect.stringMatching(/could not set up sentry/i));
const instance = sentryService.getInstance();
expect(instance).toBeNull();
});
it("doesn't send events before init", () => {
sentryService.sendError(Error());
expect(strapi.log.warn).toHaveBeenCalledWith(expect.stringMatching(/cannot send event/i));
});
it('initializes and sends errors', () => {
global.strapi.plugins.sentry.config = {
dsn: VALID_DSN,
};
sentryService.init();
// Saves the instance correctly
const instance = sentryService.getInstance();
expect(instance).not.toBeNull();
// Doesn't allow re-init
sentryService.init();
expect(strapi.log.warn).toHaveBeenCalledWith(expect.stringMatching(/already/i));
// Send error
const error = Error('an error');
const configureScope = jest.fn();
sentryService.sendError(error, configureScope);
expect(configureScope).toHaveBeenCalled();
expect(captureException).toHaveBeenCalled();
});
it('does not not send metadata when the option is disabled', () => {
// Init with metadata option disabled
global.strapi.plugins.sentry.config = {
dsn: VALID_DSN,
sendMetadata: false,
};
sentryService.init();
// Send error
const error = Error('an error');
const configureScope = jest.fn();
sentryService.sendError(error, configureScope);
expect(configureScope).not.toHaveBeenCalled();
});
});
// const Sentry = require('@sentry/node');
// const sentryService = require('../sentry');
// const defaultConfig = require('../../config/settings.json');
// const INVALID_DSN = 'an_invalid_dsn';
// const VALID_DSN = 'a_valid_dsn';
// describe('strapi-plugin-sentry service', () => {
// beforeEach(() => {
// global.strapi = {
// plugins: {
// sentry: {
// config: defaultConfig,
// },
// },
// log: {
// warn: jest.fn(),
// info: jest.fn(),
// },
// };
// });
// it('disables Sentry when no DSN is provided', () => {
// // Sentry.init();
// sentryService.init();
// expect(strapi.log.info).toHaveBeenCalledWith(expect.stringMatching(/disabled/i));
// const instance = sentryService.getInstance();
// expect(instance).toBeNull();
// });
// it('disables Sentry when an invalid DSN is provided', () => {
// global.strapi.plugins.sentry.config = {
// dsn: INVALID_DSN,
// };
// sentryService.init();
// expect(strapi.log.warn).toHaveBeenCalledWith(expect.stringMatching(/could not set up sentry/i));
// const instance = sentryService.getInstance();
// expect(instance).toBeNull();
// });
// it("doesn't send events before init", () => {
// sentryService.sendError(Error());
// expect(strapi.log.warn).toHaveBeenCalledWith(expect.stringMatching(/cannot send event/i));
// });
// it('initializes and sends errors', () => {
// global.strapi.plugins.sentry.config = {
// dsn: VALID_DSN,
// };
// sentryService.init();
// // Saves the instance correctly
// const instance = sentryService.getInstance();
// expect(instance).not.toBeNull();
// // Doesn't allow re-init
// sentryService.init();
// expect(strapi.log.warn).toHaveBeenCalledWith(expect.stringMatching(/already/i));
// const error = Error('an error');
// const configureScope = jest.fn();
// sentryService.sendError(error, configureScope);
// expect(configureScope).toHaveBeenCalled();
// });
// });

2
packages/strapi-plugin-sentry/services/sentry.js
View File

@ -28,7 +28,6 @@ const createSentryService = () => {
try {
// Don't init Sentry if no DSN was provided
if (settings.dsn) {
console.log('should call mock now');
Sentry.init({
dsn: settings.dsn,
environment: strapi.config.environment,
@ -37,7 +36,6 @@ const createSentryService = () => {
instance = Sentry;
isReady = true;
} else {
console.log('no dsn');
strapi.log.info('strapi-plugin-sentry is disabled because no Sentry DSN was provided');
}
} catch (error) {