From 83fdbdebf19f44cea512126cb22b0b78dd38b4ba Mon Sep 17 00:00:00 2001 From: mfrachet Date: Mon, 13 Sep 2021 09:14:43 +0200 Subject: [PATCH] Implicity main / h1 --- .../src/content-manager/pages/App/index.js | 4 +--- .../pages/NoContentType/index.js | 3 +-- .../pages/NoContentType/tests/index.test.js | 4 ++-- .../pages/NoPermissions/index.js | 3 +-- .../pages/NoPermissions/tests/index.test.js | 4 ++-- .../components/ForgotPassword/index.js | 4 ++-- .../components/ForgotPasswordSuccess/index.js | 4 ++-- .../AuthPage/components/Login/BaseLogin.js | 4 ++-- .../components/Login/tests/BaseLogin.test.js | 19 ++++--------------- .../pages/AuthPage/components/Oops/index.js | 4 ++-- .../components/Oops/tests/index.test.js | 4 ++-- .../AuthPage/components/Register/index.js | 4 ++-- .../components/Register/tests/index.test.js | 19 ++++--------------- .../components/ResetPassword/index.js | 4 ++-- .../ResetPassword/tests/index.test.js | 14 +++----------- .../admin/src/pages/HomePage/HomeHeader.js | 6 ++---- .../admin/admin/src/pages/HomePage/index.js | 3 +-- .../src/pages/HomePage/tests/index.test.js | 7 ++++--- .../pages/ApplicationInfosPage/index.js | 4 +--- .../ApplicationInfosPage/tests/index.test.js | 4 ++-- .../pages/Roles/EditPage/index.js | 4 +--- .../tests/__snapshots__/index.test.js.snap | 19 +++---------------- .../pages/Roles/ListPage/index.js | 3 +-- .../pages/Roles/ListPage/tests/index.test.js | 4 ++-- .../pages/Users/EditPage/index.js | 6 ++---- .../pages/Users/ListPage/index.js | 3 +-- .../pages/Users/ListPage/tests/index.test.js | 4 ++-- .../EditView/components/WebhookForm/index.js | 2 -- .../pages/Webhooks/EditView/index.js | 2 +- .../pages/Webhooks/ListView/index.js | 4 +--- .../Webhooks/ListView/tests/index.test.js | 4 ++-- .../AuthPage/components/Providers/index.js | 4 ++-- .../pages/SettingsPage/SingleSignOn/index.js | 3 +-- .../SingleSignOn/tests/index.test.js | 4 ++-- .../pages/Roles/CreatePage/index.js | 4 +--- .../tests/__snapshots__/index.test.js.snap | 19 +++---------------- .../pages/Roles/ListPage/index.js | 3 +-- packages/core/admin/package.json | 4 ++-- .../admin/src/pages/ListView/index.js | 1 - .../PageTemplate/PageTemplate.stories.mdx | 3 +-- packages/core/helper-plugin/package.json | 4 ++-- .../admin/src/pages/SettingsPage/index.js | 3 +-- .../tests/__snapshots__/index.test.js.snap | 4 ++-- .../admin/src/components/LocaleList/index.js | 3 +-- .../FormModal/Input/tests/index.test.js | 10 +--------- .../admin/src/pages/Providers/index.js | 9 +-------- .../src/pages/Providers/tests/index.test.js | 4 ++-- .../admin/src/pages/Roles/EditPage/index.js | 3 +-- .../pages/Roles/EditPage/tests/index.test.js | 4 ++-- .../admin/src/pages/Roles/ListPage/index.js | 4 +--- .../pages/Roles/ListPage/tests/index.test.js | 4 ++-- yarn.lock | 16 ++++++++-------- 52 files changed, 95 insertions(+), 195 deletions(-) diff --git a/packages/core/admin/admin/src/content-manager/pages/App/index.js b/packages/core/admin/admin/src/content-manager/pages/App/index.js index 2b1aebd9c2..1b0b2d7ee4 100644 --- a/packages/core/admin/admin/src/content-manager/pages/App/index.js +++ b/packages/core/admin/admin/src/content-manager/pages/App/index.js @@ -26,12 +26,10 @@ const App = () => { const { pathname } = useLocation(); const { formatMessage } = useIntl(); - // Check with @mfrachet if ok with a11y if (status === 'loading') { return ( -
+
{ useFocusWhenNavigate(); return ( -
+
{ }
{ >

Content

diff --git a/packages/core/admin/admin/src/content-manager/pages/NoPermissions/index.js b/packages/core/admin/admin/src/content-manager/pages/NoPermissions/index.js index f23812991d..825b590dd2 100644 --- a/packages/core/admin/admin/src/content-manager/pages/NoPermissions/index.js +++ b/packages/core/admin/admin/src/content-manager/pages/NoPermissions/index.js @@ -10,9 +10,8 @@ const NoPermissions = () => { useFocusWhenNavigate(); return ( -
+
', () => { }
', () => { >

Content

diff --git a/packages/core/admin/admin/src/pages/AuthPage/components/ForgotPassword/index.js b/packages/core/admin/admin/src/pages/AuthPage/components/ForgotPassword/index.js index 37b0010b59..326406aec6 100644 --- a/packages/core/admin/admin/src/pages/AuthPage/components/ForgotPassword/index.js +++ b/packages/core/admin/admin/src/pages/AuthPage/components/ForgotPassword/index.js @@ -15,7 +15,7 @@ const ForgotPassword = ({ onSubmit, schema }) => { return ( -
+
{ -

+

{formatMessage({ id: 'Auth.form.button.password-forgotten', defaultMessage: 'Password forgotten', diff --git a/packages/core/admin/admin/src/pages/AuthPage/components/ForgotPasswordSuccess/index.js b/packages/core/admin/admin/src/pages/AuthPage/components/ForgotPasswordSuccess/index.js index 4c7d7835b9..78d041f728 100644 --- a/packages/core/admin/admin/src/pages/AuthPage/components/ForgotPasswordSuccess/index.js +++ b/packages/core/admin/admin/src/pages/AuthPage/components/ForgotPasswordSuccess/index.js @@ -12,12 +12,12 @@ const ForgotPasswordSuccess = () => { return ( -
+
-

+

{formatMessage({ id: 'app.containers.AuthPage.ForgotPasswordSuccess.title', defaultMessage: 'Email sent', diff --git a/packages/core/admin/admin/src/pages/AuthPage/components/Login/BaseLogin.js b/packages/core/admin/admin/src/pages/AuthPage/components/Login/BaseLogin.js index 393f1f59b2..d3bdadee08 100644 --- a/packages/core/admin/admin/src/pages/AuthPage/components/Login/BaseLogin.js +++ b/packages/core/admin/admin/src/pages/AuthPage/components/Login/BaseLogin.js @@ -26,7 +26,7 @@ const Login = ({ onSubmit, schema, children }) => { const { formatMessage } = useIntl(); return ( -
+
{ -

+

{formatMessage({ id: 'Auth.form.welcome.title', defaultMessage: 'Welcome back!', diff --git a/packages/core/admin/admin/src/pages/AuthPage/components/Login/tests/BaseLogin.test.js b/packages/core/admin/admin/src/pages/AuthPage/components/Login/tests/BaseLogin.test.js index 3c631bc14a..af7add616b 100644 --- a/packages/core/admin/admin/src/pages/AuthPage/components/Login/tests/BaseLogin.test.js +++ b/packages/core/admin/admin/src/pages/AuthPage/components/Login/tests/BaseLogin.test.js @@ -370,6 +370,7 @@ describe('ADMIN | PAGES | AUTH | BaseLogin', () => { .c19 { border: none; + border-radius: 4px; padding-left: 16px; padding-right: 16px; color: #32324d; @@ -405,12 +406,9 @@ describe('ADMIN | PAGES | AUTH | BaseLogin', () => { color: inherit; } - .c19:focus { - outline: none; - } - .c20 { border: none; + border-radius: 4px; padding-left: 16px; padding-right: 0; color: #32324d; @@ -446,19 +444,10 @@ describe('ADMIN | PAGES | AUTH | BaseLogin', () => { color: inherit; } - .c20:focus { - outline: none; - } - .c18 { border: 1px solid #dcdce4; border-radius: 4px; background: #ffffff; - overflow: hidden; - } - - .c18:focus-within { - border: 1px solid #4945ff; } .c25 { @@ -547,7 +536,7 @@ describe('ADMIN | PAGES | AUTH | BaseLogin', () => { }
{ >

Welcome back!

diff --git a/packages/core/admin/admin/src/pages/AuthPage/components/Oops/index.js b/packages/core/admin/admin/src/pages/AuthPage/components/Oops/index.js index becd70a448..5bf2196d4f 100644 --- a/packages/core/admin/admin/src/pages/AuthPage/components/Oops/index.js +++ b/packages/core/admin/admin/src/pages/AuthPage/components/Oops/index.js @@ -21,12 +21,12 @@ const Oops = () => { return ( -
+
-

+

{formatMessage({ id: 'Auth.components.Oops.title', defaultMessage: 'Oops...' })}

diff --git a/packages/core/admin/admin/src/pages/AuthPage/components/Oops/tests/index.test.js b/packages/core/admin/admin/src/pages/AuthPage/components/Oops/tests/index.test.js index 56ee0510e1..cf558d3f7a 100644 --- a/packages/core/admin/admin/src/pages/AuthPage/components/Oops/tests/index.test.js +++ b/packages/core/admin/admin/src/pages/AuthPage/components/Oops/tests/index.test.js @@ -251,7 +251,7 @@ describe('ADMIN | PAGES | AUTH | Oops', () => { class="c6" >
{ >

Oops...

diff --git a/packages/core/admin/admin/src/pages/AuthPage/components/Register/index.js b/packages/core/admin/admin/src/pages/AuthPage/components/Register/index.js index 66bedac6f4..291a9f0a54 100644 --- a/packages/core/admin/admin/src/pages/AuthPage/components/Register/index.js +++ b/packages/core/admin/admin/src/pages/AuthPage/components/Register/index.js @@ -106,11 +106,11 @@ const Register = ({ fieldsToDisable, noSignin, onSubmit, schema }) => { > {({ values, errors, handleChange }) => (
-
+
-

+

{formatMessage({ id: 'Auth.form.welcome.title', defaultMessage: 'Welcome back!', diff --git a/packages/core/admin/admin/src/pages/AuthPage/components/Register/tests/index.test.js b/packages/core/admin/admin/src/pages/AuthPage/components/Register/tests/index.test.js index 388b58c06b..f11aea25e2 100644 --- a/packages/core/admin/admin/src/pages/AuthPage/components/Register/tests/index.test.js +++ b/packages/core/admin/admin/src/pages/AuthPage/components/Register/tests/index.test.js @@ -376,6 +376,7 @@ describe('ADMIN | PAGES | AUTH | Register', () => { .c29 { border: none; + border-radius: 4px; padding-left: 16px; padding-right: 16px; color: #32324d; @@ -411,12 +412,9 @@ describe('ADMIN | PAGES | AUTH | Register', () => { color: inherit; } - .c29:focus { - outline: none; - } - .c30 { border: none; + border-radius: 4px; padding-left: 16px; padding-right: 0; color: #32324d; @@ -452,19 +450,10 @@ describe('ADMIN | PAGES | AUTH | Register', () => { color: inherit; } - .c30:focus { - outline: none; - } - .c28 { border: 1px solid #dcdce4; border-radius: 4px; background: #ffffff; - overflow: hidden; - } - - .c28:focus-within { - border: 1px solid #4945ff; } .c35 { @@ -635,7 +624,7 @@ describe('ADMIN | PAGES | AUTH | Register', () => { novalidate="" >
{ >

Welcome back!

diff --git a/packages/core/admin/admin/src/pages/AuthPage/components/ResetPassword/index.js b/packages/core/admin/admin/src/pages/AuthPage/components/ResetPassword/index.js index ceab5c59f9..ad1f9c1c1a 100644 --- a/packages/core/admin/admin/src/pages/AuthPage/components/ResetPassword/index.js +++ b/packages/core/admin/admin/src/pages/AuthPage/components/ResetPassword/index.js @@ -19,7 +19,7 @@ const ForgotPassword = ({ onSubmit, schema }) => { return ( -
+
{ -

+

{formatMessage({ id: 'Auth.reset-password.title', defaultMessage: 'Reset password', diff --git a/packages/core/admin/admin/src/pages/AuthPage/components/ResetPassword/tests/index.test.js b/packages/core/admin/admin/src/pages/AuthPage/components/ResetPassword/tests/index.test.js index a4b519d626..0d72d9511f 100644 --- a/packages/core/admin/admin/src/pages/AuthPage/components/ResetPassword/tests/index.test.js +++ b/packages/core/admin/admin/src/pages/AuthPage/components/ResetPassword/tests/index.test.js @@ -319,6 +319,7 @@ describe('ADMIN | PAGES | AUTH | ResetPassword', () => { .c23 { border: none; + border-radius: 4px; padding-left: 16px; padding-right: 0; color: #32324d; @@ -354,19 +355,10 @@ describe('ADMIN | PAGES | AUTH | ResetPassword', () => { color: inherit; } - .c23:focus { - outline: none; - } - .c22 { border: 1px solid #dcdce4; border-radius: 4px; background: #ffffff; - overflow: hidden; - } - - .c22:focus-within { - border: 1px solid #4945ff; } .c18 textarea { @@ -506,7 +498,7 @@ describe('ADMIN | PAGES | AUTH | ResetPassword', () => { class="c0 c8" >
{ >

Reset password

diff --git a/packages/core/admin/admin/src/pages/HomePage/HomeHeader.js b/packages/core/admin/admin/src/pages/HomePage/HomeHeader.js index 6fa3861119..d5660922bc 100644 --- a/packages/core/admin/admin/src/pages/HomePage/HomeHeader.js +++ b/packages/core/admin/admin/src/pages/HomePage/HomeHeader.js @@ -17,14 +17,14 @@ const StackCustom = styled(Stack)` align-items: flex-start; `; -const HomeHeader = ({ hasCreatedContentType, id, onCreateCT }) => { +const HomeHeader = ({ hasCreatedContentType, onCreateCT }) => { const { formatMessage } = useIntl(); return (
-

+

{hasCreatedContentType ? formatMessage({ id: 'app.components.HomePage.welcome.again', @@ -71,13 +71,11 @@ const HomeHeader = ({ hasCreatedContentType, id, onCreateCT }) => { HomeHeader.defaultProps = { hasCreatedContentType: undefined, - id: undefined, onCreateCT: undefined, }; HomeHeader.propTypes = { hasCreatedContentType: PropTypes.bool, - id: PropTypes.string, onCreateCT: PropTypes.func, }; diff --git a/packages/core/admin/admin/src/pages/HomePage/index.js b/packages/core/admin/admin/src/pages/HomePage/index.js index 3f877d89ab..dfdf98cea4 100644 --- a/packages/core/admin/admin/src/pages/HomePage/index.js +++ b/packages/core/admin/admin/src/pages/HomePage/index.js @@ -58,7 +58,7 @@ const HomePage = () => { {title => } -
+
@@ -67,7 +67,6 @@ const HomePage = () => { diff --git a/packages/core/admin/admin/src/pages/HomePage/tests/index.test.js b/packages/core/admin/admin/src/pages/HomePage/tests/index.test.js index a8c339150e..bbb724a91f 100644 --- a/packages/core/admin/admin/src/pages/HomePage/tests/index.test.js +++ b/packages/core/admin/admin/src/pages/HomePage/tests/index.test.js @@ -619,7 +619,7 @@ describe('Homepage', () => { class="c1 c2" >
{ class="c4" >

@@ -653,7 +654,7 @@ describe('Homepage', () => { >

Welcome on board!

diff --git a/packages/core/admin/admin/src/pages/SettingsPage/pages/ApplicationInfosPage/index.js b/packages/core/admin/admin/src/pages/SettingsPage/pages/ApplicationInfosPage/index.js index b06d643a83..cae93c1689 100644 --- a/packages/core/admin/admin/src/pages/SettingsPage/pages/ApplicationInfosPage/index.js +++ b/packages/core/admin/admin/src/pages/SettingsPage/pages/ApplicationInfosPage/index.js @@ -23,10 +23,8 @@ const ApplicationInfosPage = () => { return ( -
+
{ class="c1 c2" >
{ >

Application

diff --git a/packages/core/admin/admin/src/pages/SettingsPage/pages/Roles/EditPage/index.js b/packages/core/admin/admin/src/pages/SettingsPage/pages/Roles/EditPage/index.js index e430c11b51..739f6cabe4 100644 --- a/packages/core/admin/admin/src/pages/SettingsPage/pages/Roles/EditPage/index.js +++ b/packages/core/admin/admin/src/pages/SettingsPage/pages/Roles/EditPage/index.js @@ -86,7 +86,7 @@ const EditPage = () => { const isFormDisabled = role.code === 'strapi-super-admin'; return ( -
+
{ <> } secondaryAction={