From 8babbcb31d3f1bf1d80fde35a990a3d058cf0cb4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?R=C3=A9mi=20de=20Juvigny?= <remi.dejuvigny@strapi.io>
Date: Thu, 12 Jan 2023 16:22:02 +0100
Subject: [PATCH] first mark feedback

---
 .../pages/MarketplacePage/tests/plugins.test.js    |  2 +-
 .../MarketplacePage/utils/useMarketplaceData.js    | 14 +++++++-------
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/packages/core/admin/admin/src/pages/MarketplacePage/tests/plugins.test.js b/packages/core/admin/admin/src/pages/MarketplacePage/tests/plugins.test.js
index 893338c07c..e73ef34693 100644
--- a/packages/core/admin/admin/src/pages/MarketplacePage/tests/plugins.test.js
+++ b/packages/core/admin/admin/src/pages/MarketplacePage/tests/plugins.test.js
@@ -121,7 +121,7 @@ describe('Marketplace page - plugins tab', () => {
     expect(noResult).toBeVisible();
   });
 
-  it('shows the installed text for installed plugins', async () => {
+  it('shows the installed text for installed plugins', () => {
     // Plugin that's already installed
     const alreadyInstalledCard = screen
       .getAllByTestId('npm-package-card')
diff --git a/packages/core/admin/admin/src/pages/MarketplacePage/utils/useMarketplaceData.js b/packages/core/admin/admin/src/pages/MarketplacePage/utils/useMarketplaceData.js
index 01f45d77bd..c8999b2ed5 100644
--- a/packages/core/admin/admin/src/pages/MarketplacePage/utils/useMarketplaceData.js
+++ b/packages/core/admin/admin/src/pages/MarketplacePage/utils/useMarketplaceData.js
@@ -47,16 +47,16 @@ function useMarketplaceData({ npmPackageType, debouncedSearch, query, tabQuery }
     }
   );
 
-  const relevantResponse = npmPackageType === 'plugin' ? pluginsResponse : providersResponse;
-  const relevantStatus = npmPackageType === 'plugin' ? pluginsStatus : providersStatus;
+  const npmPackageTypeResponse = npmPackageType === 'plugin' ? pluginsResponse : providersResponse;
+  const npmPackageTypeStatus = npmPackageType === 'plugin' ? pluginsStatus : providersStatus;
 
   const [possibleCollections, setPossibleCollections] = useState({});
   const [possibleCategories, setPossibleCategories] = useState({});
 
   // Keep possible filters up to date, but don't lose them while loading
   useEffect(() => {
-    if (relevantStatus === 'success') {
-      setPossibleCollections(relevantResponse.meta.collections);
+    if (npmPackageTypeStatus === 'success') {
+      setPossibleCollections(npmPackageTypeResponse.meta.collections);
     }
 
     if (pluginsStatus === 'success') {
@@ -65,11 +65,11 @@ function useMarketplaceData({ npmPackageType, debouncedSearch, query, tabQuery }
   }, [
     pluginsResponse?.meta.categories,
     pluginsStatus,
-    relevantResponse?.meta.collections,
-    relevantStatus,
+    npmPackageTypeResponse?.meta.collections,
+    npmPackageTypeStatus,
   ]);
 
-  const { pagination } = relevantStatus === 'success' ? relevantResponse.meta : {};
+  const { pagination } = npmPackageTypeStatus === 'success' ? npmPackageTypeResponse.meta : {};
 
   return {
     pluginsResponse,