From 8eec10c6ca3e595d9999b99c1956555c0c10d491 Mon Sep 17 00:00:00 2001 From: Josh <37798644+joshuaellis@users.noreply.github.com> Date: Wed, 17 May 2023 10:57:47 +0100 Subject: [PATCH] chore: remove react-fast-compare (#16749) --- .../components/CollectionTypeFormWrapper/index.js | 2 +- .../admin/src/content-manager/components/DynamicZone/index.js | 2 +- .../src/content-manager/components/FieldComponent/index.js | 2 +- .../admin/admin/src/content-manager/components/Inputs/index.js | 2 +- .../src/content-manager/pages/EditView/DeleteLink/index.js | 2 +- .../admin/src/content-manager/pages/EditView/Header/index.js | 2 +- .../content-manager/pages/EditViewLayoutManager/Permissions.js | 2 +- .../admin/admin/src/content-manager/pages/ListView/index.js | 2 +- packages/core/admin/package.json | 1 - packages/core/admin/webpack.alias.js | 1 - yarn.lock | 3 +-- 11 files changed, 9 insertions(+), 12 deletions(-) diff --git a/packages/core/admin/admin/src/content-manager/components/CollectionTypeFormWrapper/index.js b/packages/core/admin/admin/src/content-manager/components/CollectionTypeFormWrapper/index.js index a7fec44d4a..6ec515527d 100644 --- a/packages/core/admin/admin/src/content-manager/components/CollectionTypeFormWrapper/index.js +++ b/packages/core/admin/admin/src/content-manager/components/CollectionTypeFormWrapper/index.js @@ -15,7 +15,7 @@ import { } from '@strapi/helper-plugin'; import { useSelector, useDispatch } from 'react-redux'; import PropTypes from 'prop-types'; -import isEqual from 'react-fast-compare'; +import isEqual from 'lodash/isEqual'; import { createDefaultForm, getTrad, diff --git a/packages/core/admin/admin/src/content-manager/components/DynamicZone/index.js b/packages/core/admin/admin/src/content-manager/components/DynamicZone/index.js index 077f46612d..9c1b928af2 100644 --- a/packages/core/admin/admin/src/content-manager/components/DynamicZone/index.js +++ b/packages/core/admin/admin/src/content-manager/components/DynamicZone/index.js @@ -1,6 +1,6 @@ import React, { memo, useMemo, useState } from 'react'; import get from 'lodash/get'; -import isEqual from 'react-fast-compare'; +import isEqual from 'lodash/isEqual'; import PropTypes from 'prop-types'; import { Box, Flex, VisuallyHidden } from '@strapi/design-system'; import { NotAllowedInput, useNotification } from '@strapi/helper-plugin'; diff --git a/packages/core/admin/admin/src/content-manager/components/FieldComponent/index.js b/packages/core/admin/admin/src/content-manager/components/FieldComponent/index.js index 9995934c32..6770ba91d4 100644 --- a/packages/core/admin/admin/src/content-manager/components/FieldComponent/index.js +++ b/packages/core/admin/admin/src/content-manager/components/FieldComponent/index.js @@ -2,7 +2,7 @@ import React, { memo, useMemo } from 'react'; import PropTypes from 'prop-types'; import size from 'lodash/size'; -import isEqual from 'react-fast-compare'; +import isEqual from 'lodash/isEqual'; import { useIntl } from 'react-intl'; import { NotAllowedInput } from '@strapi/helper-plugin'; diff --git a/packages/core/admin/admin/src/content-manager/components/Inputs/index.js b/packages/core/admin/admin/src/content-manager/components/Inputs/index.js index 6c2fc32eb0..4faf280f31 100644 --- a/packages/core/admin/admin/src/content-manager/components/Inputs/index.js +++ b/packages/core/admin/admin/src/content-manager/components/Inputs/index.js @@ -4,7 +4,7 @@ import { useIntl } from 'react-intl'; import get from 'lodash/get'; import omit from 'lodash/omit'; import take from 'lodash/take'; -import isEqual from 'react-fast-compare'; +import isEqual from 'lodash/isEqual'; import { GenericInput, NotAllowedInput, useLibrary } from '@strapi/helper-plugin'; import { useContentTypeLayout } from '../../hooks'; import { getFieldName } from '../../utils'; diff --git a/packages/core/admin/admin/src/content-manager/pages/EditView/DeleteLink/index.js b/packages/core/admin/admin/src/content-manager/pages/EditView/DeleteLink/index.js index 4630ee2920..80213e5a18 100644 --- a/packages/core/admin/admin/src/content-manager/pages/EditView/DeleteLink/index.js +++ b/packages/core/admin/admin/src/content-manager/pages/EditView/DeleteLink/index.js @@ -1,6 +1,6 @@ import React, { memo, useState } from 'react'; import { useIntl } from 'react-intl'; -import isEqual from 'react-fast-compare'; +import isEqual from 'lodash/isEqual'; import { Button } from '@strapi/design-system'; import { Trash } from '@strapi/icons'; import { ConfirmDialog, useNotification, useAPIErrorHandler } from '@strapi/helper-plugin'; diff --git a/packages/core/admin/admin/src/content-manager/pages/EditView/Header/index.js b/packages/core/admin/admin/src/content-manager/pages/EditView/Header/index.js index e8100d232e..cdd27193c8 100644 --- a/packages/core/admin/admin/src/content-manager/pages/EditView/Header/index.js +++ b/packages/core/admin/admin/src/content-manager/pages/EditView/Header/index.js @@ -2,7 +2,7 @@ import React, { memo, useState } from 'react'; import { useIntl } from 'react-intl'; import { useHistory } from 'react-router-dom'; import PropTypes from 'prop-types'; -import isEqualFastCompare from 'react-fast-compare'; +import isEqualFastCompare from 'lodash/isEqual'; import get from 'lodash/get'; import isEqual from 'lodash/isEqual'; import isEmpty from 'lodash/isEmpty'; diff --git a/packages/core/admin/admin/src/content-manager/pages/EditViewLayoutManager/Permissions.js b/packages/core/admin/admin/src/content-manager/pages/EditViewLayoutManager/Permissions.js index 8d4d4eb715..fefbe2629b 100644 --- a/packages/core/admin/admin/src/content-manager/pages/EditViewLayoutManager/Permissions.js +++ b/packages/core/admin/admin/src/content-manager/pages/EditViewLayoutManager/Permissions.js @@ -1,7 +1,7 @@ import React, { memo, useMemo } from 'react'; import PropTypes from 'prop-types'; import { useRBAC, LoadingIndicatorPage } from '@strapi/helper-plugin'; -import isEqual from 'react-fast-compare'; +import isEqual from 'lodash/isEqual'; import EditView from '../EditView'; import { generatePermissionsObject } from '../../utils'; diff --git a/packages/core/admin/admin/src/content-manager/pages/ListView/index.js b/packages/core/admin/admin/src/content-manager/pages/ListView/index.js index 5aa3e39eb8..515b71c90c 100644 --- a/packages/core/admin/admin/src/content-manager/pages/ListView/index.js +++ b/packages/core/admin/admin/src/content-manager/pages/ListView/index.js @@ -2,7 +2,7 @@ import React, { memo, useCallback, useEffect, useRef } from 'react'; import PropTypes from 'prop-types'; import styled from 'styled-components'; import { connect } from 'react-redux'; -import isEqual from 'react-fast-compare'; +import isEqual from 'lodash/isEqual'; import { bindActionCreators, compose } from 'redux'; import { useIntl } from 'react-intl'; import { useHistory, useLocation, Link as ReactRouterLink } from 'react-router-dom'; diff --git a/packages/core/admin/package.json b/packages/core/admin/package.json index 61ca438a20..84c7e80812 100644 --- a/packages/core/admin/package.json +++ b/packages/core/admin/package.json @@ -115,7 +115,6 @@ "react-dnd-html5-backend": "15.1.3", "react-dom": "^17.0.2", "react-error-boundary": "3.1.4", - "react-fast-compare": "^3.2.0", "react-helmet": "^6.1.0", "react-intl": "6.4.1", "react-is": "^17.0.2", diff --git a/packages/core/admin/webpack.alias.js b/packages/core/admin/webpack.alias.js index 7079129d5c..0df0edff41 100644 --- a/packages/core/admin/webpack.alias.js +++ b/packages/core/admin/webpack.alias.js @@ -19,7 +19,6 @@ const aliasExactMatch = [ 'react-dnd-html5-backend', 'react-dom', 'react-error-boundary', - 'react-fast-compare', 'react-helmet', 'react-is', 'react-intl', diff --git a/yarn.lock b/yarn.lock index 5fb19aa3cb..65aa29a456 100644 --- a/yarn.lock +++ b/yarn.lock @@ -7795,7 +7795,6 @@ __metadata: react-dnd-html5-backend: 15.1.3 react-dom: ^17.0.2 react-error-boundary: 3.1.4 - react-fast-compare: ^3.2.0 react-helmet: ^6.1.0 react-intl: 6.4.1 react-is: ^17.0.2 @@ -27820,7 +27819,7 @@ __metadata: languageName: node linkType: hard -"react-fast-compare@npm:^3.1.1, react-fast-compare@npm:^3.2.0": +"react-fast-compare@npm:^3.1.1": version: 3.2.0 resolution: "react-fast-compare@npm:3.2.0" checksum: 8ef272c825ae329f61633ce4ce7f15aa5b84e5214d88bc0823880236e03e985a13195befa2c7a4eda7db3b017dc7985729152d88445823f652403cf36c2b86aa