Merge pull request #14195 from WalkingPizza/fix/settings-button-sizes

Make all settings header primary actions small
This commit is contained in:
Julie Plantey 2022-08-29 16:51:46 +02:00 committed by GitHub
commit 9496693a31
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
18 changed files with 187 additions and 194 deletions

View File

@ -195,7 +195,7 @@ const ListSettingsView = ({ layout, slug }) => {
}
primaryAction={
<Button
size="L"
size="S"
startIcon={<Check />}
disabled={isEqual(modifiedData, initialData)}
type="submit"

View File

@ -35,8 +35,8 @@ exports[`ADMIN | CM | LV | Configure the view renders and matches the snapshot 1
.c19 {
font-weight: 600;
color: #32324d;
font-size: 0.875rem;
line-height: 1.43;
font-size: 0.75rem;
line-height: 1.33;
}
.c16 {
@ -110,7 +110,7 @@ exports[`ADMIN | CM | LV | Configure the view renders and matches the snapshot 1
-webkit-box-align: center;
-ms-flex-align: center;
align-items: center;
padding: 10px 16px;
padding: 8px 16px;
background: #4945ff;
border: 1px solid #4945ff;
}
@ -1903,8 +1903,8 @@ exports[`ADMIN | CM | LV | Configure the view should add field 1`] = `
.c19 {
font-weight: 600;
color: #32324d;
font-size: 0.875rem;
line-height: 1.43;
font-size: 0.75rem;
line-height: 1.33;
}
.c16 {
@ -1978,7 +1978,7 @@ exports[`ADMIN | CM | LV | Configure the view should add field 1`] = `
-webkit-box-align: center;
-ms-flex-align: center;
align-items: center;
padding: 10px 16px;
padding: 8px 16px;
background: #4945ff;
border: 1px solid #4945ff;
}

View File

@ -128,7 +128,7 @@ const ApiTokenListView = () => {
<LinkButton
data-testid="create-api-token-button"
startIcon={<Plus />}
size="L"
size="S"
onClick={() => trackUsage('willAddTokenFromList')}
to="/settings/api-tokens/create"
>

View File

@ -422,8 +422,8 @@ describe('ADMIN | Pages | API TOKENS | ListPage', () => {
.c10 {
font-weight: 600;
color: #32324d;
font-size: 0.875rem;
line-height: 1.43;
font-size: 0.75rem;
line-height: 1.33;
}
.c8 {
@ -489,7 +489,7 @@ describe('ADMIN | Pages | API TOKENS | ListPage', () => {
}
.c6 {
padding: 10px 16px;
padding: 8px 16px;
background: #4945ff;
border: 1px solid #4945ff;
border-radius: 4px;

View File

@ -102,7 +102,7 @@ const RoleListPage = () => {
<SettingsPageTitle name="Roles" />
<HeaderLayout
primaryAction={
<Button onClick={handleToggleModalForCreatingRole} startIcon={<Plus />} size="L">
<Button onClick={handleToggleModalForCreatingRole} startIcon={<Plus />} size="S">
{formatMessage({
id: 'Settings.roles.list.button.add',
defaultMessage: 'Add new role',

View File

@ -64,8 +64,8 @@ describe('<ListPage />', () => {
.c11 {
font-weight: 600;
color: #32324d;
font-size: 0.875rem;
line-height: 1.43;
font-size: 0.75rem;
line-height: 1.33;
}
.c8 {
@ -139,7 +139,7 @@ describe('<ListPage />', () => {
-webkit-box-align: center;
-ms-flex-align: center;
align-items: center;
padding: 10px 16px;
padding: 8px 16px;
background: #4945ff;
border: 1px solid #4945ff;
}

View File

@ -105,7 +105,7 @@ const ListPage = () => {
data-testid="create-user-button"
onClick={handleToggle}
startIcon={<Envelop />}
size="L"
size="S"
>
{formatMessage({
id: 'Settings.permissions.users.create',

File diff suppressed because one or more lines are too long

View File

@ -252,7 +252,7 @@ const ListView = () => {
primaryAction={
canCreate &&
!loadingWebhooks && (
<LinkButton startIcon={<Plus />} variant="default" to={`${pathname}/create`} size="L">
<LinkButton startIcon={<Plus />} variant="default" to={`${pathname}/create`} size="S">
{formatMessage({
id: 'Settings.webhooks.list.button.add',
defaultMessage: 'Create new webhook',

View File

@ -472,8 +472,8 @@ describe('Admin | containers | ListView', () => {
.c13 {
font-weight: 600;
color: #32324d;
font-size: 0.875rem;
line-height: 1.43;
font-size: 0.75rem;
line-height: 1.33;
}
.c11 {
@ -539,7 +539,7 @@ describe('Admin | containers | ListView', () => {
}
.c9 {
padding: 10px 16px;
padding: 8px 16px;
background: #4945ff;
border: 1px solid #4945ff;
border-radius: 4px;

View File

@ -259,7 +259,7 @@ const RoleListPage = () => {
<HeaderLayout
primaryAction={
canCreate ? (
<Button onClick={handleNewRoleClick} startIcon={<Plus />} size="L">
<Button onClick={handleNewRoleClick} startIcon={<Plus />} size="S">
{formatMessage({
id: 'Settings.roles.list.button.add',
defaultMessage: 'Add new role',

View File

@ -133,7 +133,7 @@ export const SettingsPage = () => {
loading={isSubmiting}
type="submit"
startIcon={<Check />}
size="L"
size="S"
>
{formatMessage({
id: 'global.save',

View File

@ -71,8 +71,8 @@ describe('Upload | SettingsPage', () => {
.c11 {
font-weight: 600;
color: #32324d;
font-size: 0.875rem;
line-height: 1.43;
font-size: 0.75rem;
line-height: 1.33;
}
.c8 {
@ -146,7 +146,7 @@ describe('Upload | SettingsPage', () => {
-webkit-box-align: center;
-ms-flex-align: center;
align-items: center;
padding: 10px 16px;
padding: 8px 16px;
background: #4945ff;
border: 1px solid #4945ff;
}

View File

@ -34,7 +34,7 @@ const LocaleList = ({ canUpdateLocale, canDeleteLocale, onToggleCreateModal, isC
<Main tabIndex={-1}>
<HeaderLayout
primaryAction={
<Button startIcon={<Plus />} onClick={onToggleCreateModal} size="L">
<Button startIcon={<Plus />} onClick={onToggleCreateModal} size="S">
{formatMessage({ id: getTrad('Settings.list.actions.add') })}
</Button>
}

View File

@ -152,7 +152,7 @@ const AdvancedSettingsPage = () => {
type="submit"
disabled={!canUpdate}
startIcon={<Check />}
size="L"
size="S"
>
{formatMessage({ id: 'global.save', defaultMessage: 'Save' })}
</Button>

View File

@ -75,8 +75,8 @@ describe('ADMIN | Pages | Settings | Advanced Settings', () => {
.c11 {
font-weight: 600;
color: #32324d;
font-size: 0.875rem;
line-height: 1.43;
font-size: 0.75rem;
line-height: 1.33;
}
.c8 {
@ -150,7 +150,7 @@ describe('ADMIN | Pages | Settings | Advanced Settings', () => {
-webkit-box-align: center;
-ms-flex-align: center;
align-items: center;
padding: 10px 16px;
padding: 8px 16px;
background: #4945ff;
border: 1px solid #4945ff;
}

View File

@ -131,7 +131,7 @@ const RoleListPage = () => {
})}
primaryAction={
<CheckPermissions permissions={permissions.createRole}>
<Button onClick={handleNewRoleClick} startIcon={<Plus />} size="L">
<Button onClick={handleNewRoleClick} startIcon={<Plus />} size="S">
{formatMessage({
id: getTrad('List.button.roles'),
defaultMessage: 'Add new role',

View File

@ -64,8 +64,8 @@ describe('Plugin | Users and Permissions | RoleListPage', () => {
.c14 {
font-weight: 600;
color: #32324d;
font-size: 0.875rem;
line-height: 1.43;
font-size: 0.75rem;
line-height: 1.33;
}
.c11 {
@ -139,7 +139,7 @@ describe('Plugin | Users and Permissions | RoleListPage', () => {
-webkit-box-align: center;
-ms-flex-align: center;
align-items: center;
padding: 10px 16px;
padding: 8px 16px;
background: #4945ff;
border: 1px solid #4945ff;
}