yujunjun/strapi
1
0
Fork 0
mirror of https://github.com/strapi/strapi.git synced 2025-09-26 08:52:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

remove media validator until we find a better solution to validate files

Browse Source
This commit is contained in:
Marc-Roig 2023-03-06 10:54:13 +01:00
parent 6b493cd023
commit 94d600826f
2 changed files with 1 additions and 184 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
packages/core/strapi/lib/services/entity-validator/index.js
View File

@ -159,27 +159,11 @@ const createScalarAttributeValidator = (createOrUpdate) => (metas, options) => {
return validator; return validator;
}; };
const createMediaAttributeValidator = (createOrUpdate) => (metas, options) => {
let validator;
if (metas.attr.multiple) {
validator = yup.array().of(yup.mixed()).min(1);
} else {
validator = yup.mixed();
}
validator = addRequiredValidation(createOrUpdate)(validator, {
attr: { required: !options.isDraft && metas.attr.required },
});
return validator;
};
const createAttributeValidator = (createOrUpdate) => (metas, options) => { const createAttributeValidator = (createOrUpdate) => (metas, options) => {
let validator; let validator;
if (isMediaAttribute(metas.attr)) { if (isMediaAttribute(metas.attr)) {
validator = createMediaAttributeValidator(createOrUpdate)(metas, options); validator = yup.mixed();
} else if (isScalarAttribute(metas.attr)) { } else if (isScalarAttribute(metas.attr)) {
validator = createScalarAttributeValidator(createOrUpdate)(metas, options); validator = createScalarAttributeValidator(createOrUpdate)(metas, options);
} else { } else {

167
packages/core/strapi/tests/api/basic-media.test.api.js
View File

@ -1,167 +0,0 @@
'use strict';
const fs = require('fs');
const path = require('path');
const { createStrapiInstance } = require('../../../../../test/helpers/strapi');
const { createTestBuilder } = require('../../../../../test/helpers/builder');
const { createContentAPIRequest } = require('../../../../../test/helpers/request');
const builder = createTestBuilder();
let strapi;
let rq;
const productWithMedia = {
attributes: {
name: {
type: 'string',
},
description: {
type: 'text',
},
media: {
type: 'media',
multiple: false,
required: true,
allowedTypes: ['images', 'files', 'videos', 'audios'],
},
multipleMedia: {
type: 'media',
multiple: true,
required: true,
allowedTypes: ['images', 'files', 'videos', 'audios'],
},
},
displayName: 'product-with-media',
singularName: 'product-with-media',
pluralName: 'product-with-medias',
description: '',
collectionName: '',
};
describe('Core API - Basic + required media', () => {
let file;
beforeAll(async () => {
await builder.addContentType(productWithMedia).build();
strapi = await createStrapiInstance();
rq = await createContentAPIRequest({ strapi });
// Create file
const result = await rq({
method: 'POST',
url: '/upload',
formData: {
files: fs.createReadStream(path.join(__dirname, 'basic-media.test.api.js')),
},
});
file = result.body[0];
});
afterAll(async () => {
await strapi.destroy();
await builder.cleanup();
});
test('Create entry without required multiple media', async () => {
const product = {
name: 'product',
description: 'description',
media: file.id,
};
const res = await rq({
method: 'POST',
url: '/product-with-medias',
body: { data: product },
qs: { populate: true },
});
expect(res.statusCode).toBe(400);
expect(res.body).toMatchObject({
data: null,
error: {
status: 400,
name: 'ValidationError',
message: 'multipleMedia must be defined.',
details: {
errors: [
{
path: ['multipleMedia'],
message: 'multipleMedia must be defined.',
name: 'ValidationError',
},
],
},
},
});
});
test('Create entry with required multiple media as an empty array', async () => {
const product = {
name: 'product',
description: 'description',
multipleMedia: [],
media: file.id,
};
const res = await rq({
method: 'POST',
url: '/product-with-medias',
body: { data: product },
qs: { populate: true },
});
expect(res.statusCode).toBe(400);
expect(res.body).toMatchObject({
data: null,
error: {
status: 400,
name: 'ValidationError',
message: 'multipleMedia field must have at least 1 items',
details: {
errors: [
{
path: ['multipleMedia'],
message: 'multipleMedia field must have at least 1 items',
name: 'ValidationError',
},
],
},
},
});
});
test('Create entry without required single media', async () => {
const product = {
name: 'product',
description: 'description',
multipleMedia: [{ id: file.id }],
};
const res = await rq({
method: 'POST',
url: '/product-with-medias',
body: { data: product },
qs: { populate: true },
});
expect(res.statusCode).toBe(400);
expect(res.body).toMatchObject({
data: null,
error: {
status: 400,
name: 'ValidationError',
message: 'media must be defined.',
details: {
errors: [
{
path: ['media'],
message: 'media must be defined.',
name: 'ValidationError',
},
],
},
},
});
});
});