yujunjun/strapi
1
0
Fork 0
mirror of https://github.com/strapi/strapi.git synced 2025-12-27 23:24:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

only use countDistinct when needed

Browse Source
This commit is contained in:
Bassel Kanso 2022-08-03 14:46:07 +03:00
parent 2b576869b6
commit 9619cf69a3
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
packages/core/database/lib/query/query-builder.js
View File

@ -258,8 +258,8 @@ const createQueryBuilder = (uid, db) => {
this.processSelect();
},
shouldUseDistinct() {
return state.joins.length > 0 && _.isEmpty(state.groupBy);
shouldUseDistinct(numberOfJoins = 0) {
return state.joins.length > numberOfJoins && _.isEmpty(state.groupBy);
},
processSelect() {
@ -306,7 +306,11 @@ const createQueryBuilder = (uid, db) => {
? this.aliasColumn(helpers.toColumnName(meta, 'id'))
: this.aliasColumn(helpers.toColumnName(meta, state.count));
qb.countDistinct({ count: dbColumnName });
if (this.shouldUseDistinct(2)) {
qb.countDistinct({ count: dbColumnName });
} else {
qb.count({ count: dbColumnName });
}
break;
}
case 'max': {