From a4bd82ce45b5cca1c4d65eed31a5fb42483d8f13 Mon Sep 17 00:00:00 2001
From: Simone <startae14@gmail.com>
Date: Wed, 27 Mar 2024 09:21:40 +0100
Subject: [PATCH] fix(content-releases): fix flaky FE unit tests (#19927)

* fix(content-releases): fix flaky unit tests

* fix(content-releases): change Permission mock

* fix(content-releases): change CheckPermissions mock for all the CR unit tests
---
 .../admin/src/components/tests/CMReleasesContainer.test.tsx  | 5 +++--
 .../admin/src/pages/tests/ReleaseDetailsPage.test.tsx        | 5 +++--
 .../admin/src/pages/tests/ReleasesPage.test.tsx              | 5 +++--
 3 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/packages/core/content-releases/admin/src/components/tests/CMReleasesContainer.test.tsx b/packages/core/content-releases/admin/src/components/tests/CMReleasesContainer.test.tsx
index 5861ffa834..183204f0d0 100644
--- a/packages/core/content-releases/admin/src/components/tests/CMReleasesContainer.test.tsx
+++ b/packages/core/content-releases/admin/src/components/tests/CMReleasesContainer.test.tsx
@@ -1,3 +1,5 @@
+import { ReactNode } from 'react';
+
 import { useCMEditViewDataManager } from '@strapi/helper-plugin';
 import { screen, within } from '@testing-library/react';
 import { render, server, waitFor } from '@tests/utils';
@@ -7,8 +9,7 @@ import { CMReleasesContainer } from '../CMReleasesContainer';
 
 jest.mock('@strapi/helper-plugin', () => ({
   ...jest.requireActual('@strapi/helper-plugin'),
-  // eslint-disable-next-line
-  CheckPermissions: ({ children }: { children: JSX.Element }) => <div>{children}</div>,
+  CheckPermissions: jest.fn(({ children }: { children: ReactNode }) => children),
   useCMEditViewDataManager: jest.fn().mockReturnValue({
     isCreatingEntry: false,
     hasDraftAndPublish: true,
diff --git a/packages/core/content-releases/admin/src/pages/tests/ReleaseDetailsPage.test.tsx b/packages/core/content-releases/admin/src/pages/tests/ReleaseDetailsPage.test.tsx
index 0edc7893b3..c11dfafc8f 100644
--- a/packages/core/content-releases/admin/src/pages/tests/ReleaseDetailsPage.test.tsx
+++ b/packages/core/content-releases/admin/src/pages/tests/ReleaseDetailsPage.test.tsx
@@ -1,3 +1,5 @@
+import { ReactNode } from 'react';
+
 import { useRBAC } from '@strapi/helper-plugin';
 import { within } from '@testing-library/react';
 import { render, server, screen } from '@tests/utils';
@@ -9,8 +11,7 @@ import { mockReleaseDetailsPageData } from './mockReleaseDetailsPageData';
 
 jest.mock('@strapi/helper-plugin', () => ({
   ...jest.requireActual('@strapi/helper-plugin'),
-  // eslint-disable-next-line
-  CheckPermissions: ({ children }: { children: JSX.Element }) => <div>{children}</div>,
+  CheckPermissions: jest.fn(({ children }: { children: ReactNode }) => children),
   useRBAC: jest.fn(() => ({
     isLoading: false,
     allowedActions: { canUpdate: true, canDelete: true },
diff --git a/packages/core/content-releases/admin/src/pages/tests/ReleasesPage.test.tsx b/packages/core/content-releases/admin/src/pages/tests/ReleasesPage.test.tsx
index 78c8dff149..d37ed294cd 100644
--- a/packages/core/content-releases/admin/src/pages/tests/ReleasesPage.test.tsx
+++ b/packages/core/content-releases/admin/src/pages/tests/ReleasesPage.test.tsx
@@ -1,3 +1,5 @@
+import { ReactNode } from 'react';
+
 import { within } from '@testing-library/react';
 import { render, server, screen } from '@tests/utils';
 import { rest } from 'msw';
@@ -8,8 +10,7 @@ import { mockReleasesPageData } from './mockReleasesPageData';
 
 jest.mock('@strapi/helper-plugin', () => ({
   ...jest.requireActual('@strapi/helper-plugin'),
-  // eslint-disable-next-line
-  CheckPermissions: ({ children }: { children: JSX.Element }) => <div>{children}</div>,
+  CheckPermissions: jest.fn(({ children }: { children: ReactNode }) => children),
 }));
 
 jest.mock('@strapi/admin/strapi-admin', () => ({