From a8ea727e63e931d99a366f5a61b88eff83bf5d36 Mon Sep 17 00:00:00 2001 From: soupette Date: Wed, 26 Aug 2020 16:01:27 +0200 Subject: [PATCH] Fix PR feedback Signed-off-by: soupette --- packages/strapi-admin/admin/src/translations/en.json | 2 -- .../admin/src/containers/Roles/EditPage/index.js | 2 +- .../admin/src/containers/Roles/ListPage/index.js | 3 ++- .../admin/src/translations/en.json | 4 +++- 4 files changed, 6 insertions(+), 5 deletions(-) diff --git a/packages/strapi-admin/admin/src/translations/en.json b/packages/strapi-admin/admin/src/translations/en.json index 0c673b0c4d..d46d04ec94 100644 --- a/packages/strapi-admin/admin/src/translations/en.json +++ b/packages/strapi-admin/admin/src/translations/en.json @@ -94,9 +94,7 @@ "Settings.roles.create.description": "Define the rights given to the role", "Settings.roles.create.title": "Create a role", "Settings.roles.created": "Role created", - "Settings.roles.deleted": "Role deleted", "Settings.roles.edit.title": "Edit a role", - "Settings.roles.edited": "Role edited", "Settings.roles.form.button.users-with-role": "Users with this role", "Settings.roles.form.created": "Created", "Settings.roles.form.description": "Name and description of the role", diff --git a/packages/strapi-plugin-users-permissions/admin/src/containers/Roles/EditPage/index.js b/packages/strapi-plugin-users-permissions/admin/src/containers/Roles/EditPage/index.js index 068b34dff7..8ea73bcd6d 100644 --- a/packages/strapi-plugin-users-permissions/admin/src/containers/Roles/EditPage/index.js +++ b/packages/strapi-plugin-users-permissions/admin/src/containers/Roles/EditPage/index.js @@ -64,7 +64,7 @@ const EditPage = () => { }) ) .then(() => { - strapi.notification.success('Settings.roles.edited'); + strapi.notification.success(getTrad('Settings.roles.edited')); }) .catch(err => { console.error(err); diff --git a/packages/strapi-plugin-users-permissions/admin/src/containers/Roles/ListPage/index.js b/packages/strapi-plugin-users-permissions/admin/src/containers/Roles/ListPage/index.js index 18fd20f4b6..b97310cede 100644 --- a/packages/strapi-plugin-users-permissions/admin/src/containers/Roles/ListPage/index.js +++ b/packages/strapi-plugin-users-permissions/admin/src/containers/Roles/ListPage/index.js @@ -10,6 +10,7 @@ import { EmptyRole, RoleListWrapper, RoleRow } from '../../../components/Roles'; import { useRolesList } from '../../../hooks'; import BaselineAlignment from './BaselineAlignment'; import pluginId from '../../../pluginId'; +import { getTrad } from '../../../utils'; const RoleListPage = () => { const { formatMessage } = useIntl(); @@ -43,7 +44,7 @@ const RoleListPage = () => { }) ) .then(() => { - strapi.notification.success('Settings.roles.deleted'); + strapi.notification.success(getTrad('Settings.roles.deleted')); }) .catch(err => { console.error(err); diff --git a/packages/strapi-plugin-users-permissions/admin/src/translations/en.json b/packages/strapi-plugin-users-permissions/admin/src/translations/en.json index 914b20424a..2d1a2ee90b 100644 --- a/packages/strapi-plugin-users-permissions/admin/src/translations/en.json +++ b/packages/strapi-plugin-users-permissions/admin/src/translations/en.json @@ -58,5 +58,7 @@ "popUpWarning.button.cancel": "Cancel", "popUpWarning.button.confirm": "Confirm", "popUpWarning.title": "Please confirm", - "popUpWarning.warning.cancel": "Are you sure you want to cancel your modifications?" + "popUpWarning.warning.cancel": "Are you sure you want to cancel your modifications?", + "Settings.roles.deleted": "Role deleted", + "Settings.roles.edited": "Role edited" }