From c9fd4535bc5ed4d80f600780d48fc7c54b528dcf Mon Sep 17 00:00:00 2001 From: Chris Winch Date: Thu, 24 Oct 2019 09:44:52 +0100 Subject: [PATCH 01/17] update upload file size type to integer so that graphQl can sort as expected --- .../documentation/1.0.0/overrides/upload-File.json | 4 ++-- packages/strapi-plugin-upload/models/File.settings.json | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/strapi-plugin-upload/documentation/1.0.0/overrides/upload-File.json b/packages/strapi-plugin-upload/documentation/1.0.0/overrides/upload-File.json index 4621bb93ad..25f5cfd372 100644 --- a/packages/strapi-plugin-upload/documentation/1.0.0/overrides/upload-File.json +++ b/packages/strapi-plugin-upload/documentation/1.0.0/overrides/upload-File.json @@ -233,7 +233,7 @@ "type": "string" }, "size": { - "type": "string" + "type": "integer" }, "mime": { "type": "string" @@ -260,4 +260,4 @@ } } } -} \ No newline at end of file +} diff --git a/packages/strapi-plugin-upload/models/File.settings.json b/packages/strapi-plugin-upload/models/File.settings.json index 06c270b8fe..4d6f45722a 100644 --- a/packages/strapi-plugin-upload/models/File.settings.json +++ b/packages/strapi-plugin-upload/models/File.settings.json @@ -32,7 +32,7 @@ "required": true }, "size": { - "type": "string", + "type": "integer", "configurable": false, "required": true }, @@ -56,4 +56,4 @@ "configurable": false } } -} \ No newline at end of file +} From 6e5eb9d7245b18428d0accd825c7dbb954af2d9d Mon Sep 17 00:00:00 2001 From: Chris Winch Date: Thu, 24 Oct 2019 13:58:05 +0100 Subject: [PATCH 02/17] update upload size type to decimal --- .../documentation/1.0.0/overrides/upload-File.json | 4 ++-- packages/strapi-plugin-upload/models/File.settings.json | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/strapi-plugin-upload/documentation/1.0.0/overrides/upload-File.json b/packages/strapi-plugin-upload/documentation/1.0.0/overrides/upload-File.json index 25f5cfd372..52e508d305 100644 --- a/packages/strapi-plugin-upload/documentation/1.0.0/overrides/upload-File.json +++ b/packages/strapi-plugin-upload/documentation/1.0.0/overrides/upload-File.json @@ -30,7 +30,7 @@ "type": "string" }, "size": { - "type": "integer" + "type": "decimal" }, "url": { "type": "string", @@ -233,7 +233,7 @@ "type": "string" }, "size": { - "type": "integer" + "type": "decimal" }, "mime": { "type": "string" diff --git a/packages/strapi-plugin-upload/models/File.settings.json b/packages/strapi-plugin-upload/models/File.settings.json index 4d6f45722a..de69fdfb21 100644 --- a/packages/strapi-plugin-upload/models/File.settings.json +++ b/packages/strapi-plugin-upload/models/File.settings.json @@ -32,7 +32,7 @@ "required": true }, "size": { - "type": "integer", + "type": "decimal", "configurable": false, "required": true }, From 1849a6c91597fade28b94b161d30e7e405b6ea6c Mon Sep 17 00:00:00 2001 From: Chris Winch Date: Thu, 24 Oct 2019 15:07:02 +0100 Subject: [PATCH 03/17] update upload e2e test to expect number value for size in response --- packages/strapi-plugin-upload/test/upload.test.e2e.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/strapi-plugin-upload/test/upload.test.e2e.js b/packages/strapi-plugin-upload/test/upload.test.e2e.js index aedeaa1271..249eaffcb9 100644 --- a/packages/strapi-plugin-upload/test/upload.test.e2e.js +++ b/packages/strapi-plugin-upload/test/upload.test.e2e.js @@ -132,7 +132,7 @@ describe('Upload plugin end to end tests', () => { id: expect.anything(), sha256: expect.any(String), hash: expect.any(String), - size: expect.any(String), + size: expect.any(Number), url: expect.any(String), provider: 'local', name: 'rec.jpg', From b698303b33a670d315ad3913d371db1e663cd21e Mon Sep 17 00:00:00 2001 From: Andrey Hohutkin Date: Mon, 4 Nov 2019 11:04:53 +0200 Subject: [PATCH 04/17] Fix empty date wrong display Empty date values are shown incorrectly as a current date in the content manager (Admin UI) The correct view should be '-'. --- .../admin/src/components/CustomTable/Row.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/strapi-plugin-content-manager/admin/src/components/CustomTable/Row.js b/packages/strapi-plugin-content-manager/admin/src/components/CustomTable/Row.js index d96a0ec91e..a5f60cfac6 100644 --- a/packages/strapi-plugin-content-manager/admin/src/components/CustomTable/Row.js +++ b/packages/strapi-plugin-content-manager/admin/src/components/CustomTable/Row.js @@ -31,7 +31,7 @@ const getDisplayedValue = (type, value, name) => { case 'time': case 'datetime': case 'timestamp': { - if (value === null) { + if (value == null) { return '-'; } From cff8fd904149ab993df73ec144490e16d17a926b Mon Sep 17 00:00:00 2001 From: Victor LAMBERT Date: Sat, 16 Nov 2019 01:05:21 +0100 Subject: [PATCH 05/17] Populate only role relation to authorize user --- .../config/policies/permissions.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/strapi-plugin-users-permissions/config/policies/permissions.js b/packages/strapi-plugin-users-permissions/config/policies/permissions.js index 55ae6bf4ad..e4fd13b294 100644 --- a/packages/strapi-plugin-users-permissions/config/policies/permissions.js +++ b/packages/strapi-plugin-users-permissions/config/policies/permissions.js @@ -16,11 +16,11 @@ module.exports = async (ctx, next) => { if (isAdmin) { ctx.state.admin = await strapi .query('administrator', 'admin') - .findOne({ id }); + .findOne({ id }, ['role']); } else { ctx.state.user = await strapi .query('user', 'users-permissions') - .findOne({ id }); + .findOne({ id }, ['role']); } } catch (err) { return handleErrors(ctx, err, 'unauthorized'); From 54cd2082213c3acecfab380aff61ea5bba267646 Mon Sep 17 00:00:00 2001 From: Jim LAURIE Date: Thu, 28 Nov 2019 16:26:23 +0100 Subject: [PATCH 06/17] Remove search engine for index.html page --- .../strapi-generate-new/lib/resources/files/public/index.html | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/strapi-generate-new/lib/resources/files/public/index.html b/packages/strapi-generate-new/lib/resources/files/public/index.html index 525729ca29..82b64f866b 100644 --- a/packages/strapi-generate-new/lib/resources/files/public/index.html +++ b/packages/strapi-generate-new/lib/resources/files/public/index.html @@ -6,6 +6,7 @@ Welcome to your Strapi app +