mirror of
https://github.com/strapi/strapi.git
synced 2025-07-03 07:05:06 +00:00
Fix PR feedback
This commit is contained in:
parent
c5d88ace8b
commit
ab82eb1d2e
@ -12,7 +12,7 @@ const appPath = isDevelopmentMode ? path.resolve(process.env.PWD, '..') : path.r
|
|||||||
shell.echo('🏗 Building the admin...');
|
shell.echo('🏗 Building the admin...');
|
||||||
|
|
||||||
shell.cd(path.resolve(appPath, 'admin'));
|
shell.cd(path.resolve(appPath, 'admin'));
|
||||||
const build = shell.exec(`set APP_PATH="${appPath}" && npm run build`, {silent});
|
const build = shell.exec(`cross-env APP_PATH="${appPath}" npm run build`, {silent});
|
||||||
|
|
||||||
if (build.stderr && build.code !== 0) {
|
if (build.stderr && build.code !== 0) {
|
||||||
console.error(build.stderr);
|
console.error(build.stderr);
|
||||||
@ -55,7 +55,7 @@ if (process.env.npm_config_plugins === 'true') {
|
|||||||
|
|
||||||
shell.echo('🏗 Building...');
|
shell.echo('🏗 Building...');
|
||||||
shell.cd(path.resolve(plugins, plugin));
|
shell.cd(path.resolve(plugins, plugin));
|
||||||
const build = shell.exec(`set APP_PATH="${appPath}" && npm run build`, {silent});
|
const build = shell.exec(`cross-env APP_PATH="${appPath}" npm run build`, {silent});
|
||||||
|
|
||||||
if (build.stderr && build.code !== 0) {
|
if (build.stderr && build.code !== 0) {
|
||||||
console.error(build.stderr);
|
console.error(build.stderr);
|
||||||
|
@ -283,7 +283,11 @@ module.exports = (scope, cb) => {
|
|||||||
}
|
}
|
||||||
|
|
||||||
console.log();
|
console.log();
|
||||||
console.log(isQuick ? '✅ Connected to the database' : '⏳ Testing database connection...');
|
console.log(
|
||||||
|
isQuick
|
||||||
|
? '✅ Connected to the database'
|
||||||
|
: '⏳ Testing database connection...\r\nIt might take a minute, please have a coffee ☕️'
|
||||||
|
);
|
||||||
|
|
||||||
resolve();
|
resolve();
|
||||||
}),
|
}),
|
||||||
|
@ -33,6 +33,10 @@
|
|||||||
"pluralize": "^7.0.0",
|
"pluralize": "^7.0.0",
|
||||||
"strapi-utils": "3.0.0-alpha.23.1"
|
"strapi-utils": "3.0.0-alpha.23.1"
|
||||||
},
|
},
|
||||||
|
"devDependencies": {
|
||||||
|
"cross-env": "^5.2.0",
|
||||||
|
"rimraf": "^2.6.3"
|
||||||
|
},
|
||||||
"author": {
|
"author": {
|
||||||
"name": "A Strapi developer",
|
"name": "A Strapi developer",
|
||||||
"email": "",
|
"email": "",
|
||||||
@ -49,9 +53,5 @@
|
|||||||
"node": ">= 10.0.0",
|
"node": ">= 10.0.0",
|
||||||
"npm": ">= 6.0.0"
|
"npm": ">= 6.0.0"
|
||||||
},
|
},
|
||||||
"license": "MIT",
|
"license": "MIT"
|
||||||
"devDependencies": {
|
|
||||||
"cross-env": "^5.2.0",
|
|
||||||
"rimraf": "^2.6.3"
|
|
||||||
}
|
|
||||||
}
|
}
|
@ -31,7 +31,7 @@ const packageJSON = require('../package.json');
|
|||||||
*/
|
*/
|
||||||
|
|
||||||
module.exports = function (name, cliArguments) {
|
module.exports = function (name, cliArguments) {
|
||||||
console.log('🚀 Start creating your Strapi application. It might take a minute, please take a coffee ☕️');
|
console.log('🚀 Start creating your Strapi application.');
|
||||||
|
|
||||||
const developerMode = cliArguments.dev !== undefined;
|
const developerMode = cliArguments.dev !== undefined;
|
||||||
|
|
||||||
|
Loading…
x
Reference in New Issue
Block a user