Update settings api to add the permissions check

Signed-off-by: soupette <cyril.lpz@gmail.com>

packages/strapi-admin/admin/src/containers/LeftMenu/index.js

@@ -37,8 +37,6 @@ const LeftMenu = ({ version, plugins }) => {
     [pluginsSectionLinks]
   );
 
-  console.log(pluginsSectionLinks);
-
   useEffect(() => {
     const getLinksPermissions = async () => {
       const checkPermissions = async (index, permissionsToCheck) => {

packages/strapi-admin/admin/src/containers/LeftMenu/init.js

@@ -1,8 +1,27 @@
 import { get, omit, set, sortBy } from 'lodash';
+import { SETTINGS_BASE_URL } from '../../config';
+
+const getPluginsSettingsPermissions = plugins =>
+  Object.values(plugins).reduce((acc, current) => {
+    const pluginSettings = get(current, 'settings.global', []);
+
+    pluginSettings.forEach(setting => {
+      const permissions = get(setting, 'permissions', []);
+
+      permissions.forEach(permission => {
+        acc.push(permission);
+      });
+    });
+
+    return acc;
+  }, []);
 
 const sortLinks = links => sortBy(links, object => object.name);
 
 const init = (initialState, plugins = {}) => {
+  // For each plugin retrieve the permissions associated to each injected link
+  const settingsPermissions = getPluginsSettingsPermissions(plugins);
+
   const pluginsLinks = Object.values(plugins).reduce((acc, current) => {
     const pluginsSectionLinks = get(current, 'menu.pluginsSectionLinks', []);
 
@@ -12,6 +31,17 @@ const init = (initialState, plugins = {}) => {
     return { ...omit(link, 'name'), isDisplayed: false };
   });
 
+  const settingsLinkIndex = initialState.generalSectionLinks.findIndex(
+    obj => obj.destination === SETTINGS_BASE_URL
+  );
+
+  if (settingsPermissions.length && settingsLinkIndex !== -1) {
+    const permissionsPath = ['generalSectionLinks', settingsLinkIndex, 'permissions'];
+    const alreadyCreatedPermissions = get(initialState, permissionsPath, []);
+
+    set(initialState, permissionsPath, [...alreadyCreatedPermissions, ...settingsPermissions]);
+  }
+
   if (sortedLinks.length) {
     set(initialState, 'pluginsSectionLinks', sortedLinks);
   }

packages/strapi-admin/admin/src/containers/LeftMenu/reducer.js

@@ -46,10 +46,7 @@ const initialState = {
         { action: 'admin::roles.update', subject: null },
         { action: 'admin::roles.read', subject: null },
         { action: 'admin::roles.delete', subject: null },
-
+        // Here are added the plugins settings permissions during the init phase
-        // TODO this should be set by the plugin directly
-        // media library
-        { action: 'plugins::upload.settings.read', subject: null },
       ],
     },
   ],

packages/strapi-admin/admin/src/containers/LeftMenu/tests/init.test.js

@@ -5,9 +5,10 @@ describe('ADMIN | LeftMenu | init', () => {
     it('should return the initialState if the plugins are empty', () => {
       const initialState = {
         ok: true,
+        generalSectionLinks: [],
       };
 
-      expect(init(initialState)).toEqual({ ok: true });
+      expect(init(initialState)).toEqual({ ok: true, generalSectionLinks: [] });
     });
 
     it('should create the pluginsSectionLinks correctly', () => {

packages/strapi-admin/admin/src/plugins.js

@@ -32,6 +32,6 @@ module.exports = {
     .default,
 
   'strapi-plugin-email': require('../../../strapi-plugin-email/admin/src').default,
-  // 'strapi-plugin-upload': require('../../../strapi-plugin-upload/admin/src').default,
+  'strapi-plugin-upload': require('../../../strapi-plugin-upload/admin/src').default,
   'strapi-plugin-graphql': require('../../../strapi-plugin-graphql/admin/src').default,
 };

packages/strapi-admin/admin/src/utils/fakePermissionsData.js

@@ -234,12 +234,12 @@ const data = {
     //   fields: null,
     //   conditions: [],
     // },
-    {
+    // {
-      action: 'admin::marketplace.plugins.install',
+    //   action: 'admin::marketplace.plugins.install',
-      subject: null,
+    //   subject: null,
-      fields: null,
+    //   fields: null,
-      conditions: ['some condition'],
+    //   conditions: ['some condition'],
-    },
+    // },
     // {
     //   action: 'admin::marketplace.plugins.uninstall',
     //   subject: null,
@@ -248,82 +248,82 @@ const data = {
     // },
 
     // Admin webhooks
-    {
+    // {
-      action: 'admin::webhooks.create',
+    //   action: 'admin::webhooks.create',
-      subject: null,
+    //   subject: null,
-      fields: null,
+    //   fields: null,
-      conditions: [],
+    //   conditions: [],
-    },
+    // },
-    {
+    // {
-      action: 'admin::webhooks.read',
+    //   action: 'admin::webhooks.read',
-      subject: null,
+    //   subject: null,
-      fields: null,
+    //   fields: null,
-      conditions: [],
+    //   conditions: [],
-    },
+    // },
-    {
+    // {
-      action: 'admin::webhooks.update',
+    //   action: 'admin::webhooks.update',
-      subject: null,
+    //   subject: null,
-      fields: null,
+    //   fields: null,
-      conditions: [],
+    //   conditions: [],
-    },
+    // },
-    {
+    // {
-      action: 'admin::webhooks.delete',
+    //   action: 'admin::webhooks.delete',
-      subject: null,
+    //   subject: null,
-      fields: null,
+    //   fields: null,
-      conditions: [],
+    //   conditions: [],
-    },
+    // },
 
-    // Admin users
+    // // Admin users
-    {
+    // {
-      action: 'admin::users.create',
+    //   action: 'admin::users.create',
-      subject: null,
+    //   subject: null,
-      fields: null,
+    //   fields: null,
-      conditions: [],
+    //   conditions: [],
-    },
+    // },
-    {
+    // {
-      action: 'admin::users.read',
+    //   action: 'admin::users.read',
-      subject: null,
+    //   subject: null,
-      fields: null,
+    //   fields: null,
-      conditions: [],
+    //   conditions: [],
-    },
+    // },
-    {
+    // {
-      action: 'admin::users.update',
+    //   action: 'admin::users.update',
-      subject: null,
+    //   subject: null,
-      fields: null,
+    //   fields: null,
-      conditions: [],
+    //   conditions: [],
-    },
+    // },
-    {
+    // {
-      action: 'admin::users.delete',
+    //   action: 'admin::users.delete',
-      subject: null,
+    //   subject: null,
-      fields: null,
+    //   fields: null,
-      conditions: [],
+    //   conditions: [],
-    },
+    // },
 
-    // Admin roles
+    // // Admin roles
-    {
+    // {
-      action: 'admin::roles.create',
+    //   action: 'admin::roles.create',
-      subject: null,
+    //   subject: null,
-      fields: null,
+    //   fields: null,
-      conditions: [],
+    //   conditions: [],
-    },
+    // },
-    {
+    // {
-      action: 'admin::roles.read',
+    //   action: 'admin::roles.read',
-      subject: null,
+    //   subject: null,
-      fields: null,
+    //   fields: null,
-      conditions: [],
+    //   conditions: [],
-    },
+    // },
-    {
+    // {
-      action: 'admin::roles.update',
+    //   action: 'admin::roles.update',
-      subject: null,
+    //   subject: null,
-      fields: null,
+    //   fields: null,
-      conditions: [],
+    //   conditions: [],
-    },
+    // },
-    {
+    // {
-      action: 'admin::roles.delete',
+    //   action: 'admin::roles.delete',
-      subject: null,
+    //   subject: null,
-      fields: null,
+    //   fields: null,
-      conditions: [],
+    //   conditions: [],
-    },
+    // },
 
     // Content type builder
     {

packages/strapi-plugin-upload/admin/src/index.js

@@ -50,6 +50,8 @@ export default strapi => {
           name: 'media-library',
           to: `${strapi.settingsBaseURL}/media-library`,
           Component: SettingsPage,
+          // TODO write documentation
+          permissions: [{ action: 'plugins::upload.settings.read', subject: null }],
         },
       ],
     },