diff --git a/packages/strapi-admin/controllers/Admin.js b/packages/strapi-admin/controllers/Admin.js index e4a4f9d14b..a239825e62 100755 --- a/packages/strapi-admin/controllers/Admin.js +++ b/packages/strapi-admin/controllers/Admin.js @@ -1,7 +1,7 @@ 'use strict'; const path = require('path'); -const exec = require('child_process').execSync; +const exec = require('child_process').spawnSync; const _ = require('lodash'); /** @@ -53,8 +53,7 @@ module.exports = { strapi.reload.isWatching = false; strapi.log.info(`Installing ${plugin}...`); - - exec(`node "${strapiBin}" install ${plugin} ${port === '4000' ? '--dev' : ''}`); + exec('node', [strapiBin, 'install', plugin, (port === '4000') ? '--dev' : '']); ctx.send({ ok: true }); @@ -87,7 +86,7 @@ module.exports = { strapi.reload.isWatching = false; strapi.log.info(`Uninstalling ${plugin}...`); - exec(`node "${strapiBin}" uninstall ${plugin}`); + exec('node', [strapiBin, 'uninstall', plugin]); ctx.send({ ok: true }); diff --git a/packages/strapi-admin/package.json b/packages/strapi-admin/package.json index a918c9edf7..b5778e1491 100755 --- a/packages/strapi-admin/package.json +++ b/packages/strapi-admin/package.json @@ -51,4 +51,4 @@ "npm": ">= 5.0.0" }, "license": "MIT" -} \ No newline at end of file +} diff --git a/packages/strapi-plugin-settings-manager/services/SettingsManager.js b/packages/strapi-plugin-settings-manager/services/SettingsManager.js index 7e104de4e9..3945a3eeda 100755 --- a/packages/strapi-plugin-settings-manager/services/SettingsManager.js +++ b/packages/strapi-plugin-settings-manager/services/SettingsManager.js @@ -3,7 +3,7 @@ const fs = require('fs'); const path = require('path'); const _ = require('lodash'); -const exec = require('child_process').execSync; +const exec = require('child_process').spawnSync; module.exports = { menu: { @@ -901,12 +901,12 @@ module.exports = { if (connector && !installedConnector) { strapi.log.info(`Installing ${connector} dependency ...`); - exec(`npm install ${connector}@alpha`); + exec('npm', ['install', `${connector}@alpha`]); } if (client && !installedClient) { strapi.log.info(`Installing ${client} dependency ...`); - exec(`npm install ${client}`); + exec('npm', ['install', client]); } }, diff --git a/packages/strapi/bin/strapi-install.js b/packages/strapi/bin/strapi-install.js index 156266ca4a..5571ae845b 100755 --- a/packages/strapi/bin/strapi-install.js +++ b/packages/strapi/bin/strapi-install.js @@ -60,7 +60,7 @@ module.exports = function (plugin, cliArguments) { if (!isStrapiInstalledWithNPM) { // Create the directory yarn doesn't do it it - shell.exec(`mkdir ${pluginPath}`); + shell.exec('mkdir', [pluginPath]); // Add a package.json so it installs the dependencies shell.touch(`${pluginPath}/package.json`); fs.writeFileSync(`${pluginPath}/package.json`, JSON.stringify({}), 'utf8');