From bb4cea601908dab89dab4d029806fba3bfbbfa98 Mon Sep 17 00:00:00 2001 From: soupette Date: Tue, 1 Sep 2020 10:07:24 +0200 Subject: [PATCH] Clean code Signed-off-by: soupette --- .../admin/src/containers/ListSettingsView/index.js | 5 ++--- .../admin/src/utils/index.js | 1 - .../admin/src/utils/removePublishedAtFromMetas.js | 5 ----- .../utils/tests/removePublishedAtFromMetas.test.js | 12 ------------ 4 files changed, 2 insertions(+), 21 deletions(-) delete mode 100644 packages/strapi-plugin-content-manager/admin/src/utils/removePublishedAtFromMetas.js delete mode 100644 packages/strapi-plugin-content-manager/admin/src/utils/tests/removePublishedAtFromMetas.test.js diff --git a/packages/strapi-plugin-content-manager/admin/src/containers/ListSettingsView/index.js b/packages/strapi-plugin-content-manager/admin/src/containers/ListSettingsView/index.js index 0ce3c34d68..bddea41bbe 100644 --- a/packages/strapi-plugin-content-manager/admin/src/containers/ListSettingsView/index.js +++ b/packages/strapi-plugin-content-manager/admin/src/containers/ListSettingsView/index.js @@ -12,7 +12,7 @@ import { useDrop } from 'react-dnd'; import { DropdownItem } from 'reactstrap'; import { Inputs as Input } from '@buffetjs/custom'; import pluginId from '../../pluginId'; -import { ItemTypes, getRequestUrl, removePublishedAtFromMetas } from '../../utils'; +import { ItemTypes, getRequestUrl } from '../../utils'; import PopupForm from '../../components/PopupForm'; import SettingsViewWrapper from '../../components/SettingsViewWrapper'; import SortWrapper from '../../components/SortWrapper'; @@ -81,9 +81,8 @@ const ListSettingsView = ({ deleteLayout, slug }) => { const listRemainingFields = useMemo(() => { const metadatas = get(modifiedData, ['metadatas'], {}); - const filteredMetadatas = removePublishedAtFromMetas(metadatas); - return Object.keys(filteredMetadatas) + return Object.keys(metadatas) .filter(key => { const type = get(attributes, [key, 'type'], ''); diff --git a/packages/strapi-plugin-content-manager/admin/src/utils/index.js b/packages/strapi-plugin-content-manager/admin/src/utils/index.js index aecd72479a..479d32d2f4 100644 --- a/packages/strapi-plugin-content-manager/admin/src/utils/index.js +++ b/packages/strapi-plugin-content-manager/admin/src/utils/index.js @@ -4,4 +4,3 @@ export { default as getFieldName } from './getFieldName'; export { default as getRequestUrl } from './getRequestUrl'; export { default as getTrad } from './getTrad'; export { default as ItemTypes } from './ItemTypes'; -export { default as removePublishedAtFromMetas } from './removePublishedAtFromMetas'; diff --git a/packages/strapi-plugin-content-manager/admin/src/utils/removePublishedAtFromMetas.js b/packages/strapi-plugin-content-manager/admin/src/utils/removePublishedAtFromMetas.js deleted file mode 100644 index 54b352fb2b..0000000000 --- a/packages/strapi-plugin-content-manager/admin/src/utils/removePublishedAtFromMetas.js +++ /dev/null @@ -1,5 +0,0 @@ -import { omit } from 'lodash'; - -const removePublishedAtFromMetas = metas => omit(metas, ['published_at']); - -export default removePublishedAtFromMetas; diff --git a/packages/strapi-plugin-content-manager/admin/src/utils/tests/removePublishedAtFromMetas.test.js b/packages/strapi-plugin-content-manager/admin/src/utils/tests/removePublishedAtFromMetas.test.js deleted file mode 100644 index e5ae92ce0b..0000000000 --- a/packages/strapi-plugin-content-manager/admin/src/utils/tests/removePublishedAtFromMetas.test.js +++ /dev/null @@ -1,12 +0,0 @@ -import removePublishedAtFromMetas from '../removePublishedAtFromMetas'; - -describe('CONTENT MANAGER | utils | removePublishedAtFromMetas', () => { - it('should remove the published_at key from the given object', () => { - const data = { - ok: true, - published_at: true, - }; - - expect(removePublishedAtFromMetas(data)).toEqual({ ok: true }); - }); -});