From bc6034cf841f8cfb048751ea26efcff64903bd48 Mon Sep 17 00:00:00 2001
From: Josh <37798644+joshuaellis@users.noreply.github.com>
Date: Mon, 19 Jun 2023 10:22:38 +0100
Subject: [PATCH] chore: remove history & clean up some U&P tests (#16992)
---
.../Permissions/PermissionRow/SubCategory.js | 22 +-
.../admin/src/hooks/index.js | 4 +-
.../admin/src/hooks/usePlugins.js | 71 +
.../admin/src/hooks/usePlugins/index.js | 70 -
.../admin/src/hooks/usePlugins/init.js | 5 -
.../admin/src/hooks/usePlugins/reducer.js | 34 -
.../src/hooks/usePlugins/tests/init.test.js | 32 -
.../hooks/usePlugins/tests/reducer.test.js | 96 --
.../AdvancedSettings/tests/index.test.js | 9 -
.../AdvancedSettings/tests/utils/server.js | 26 -
.../pages/EmailTemplates/tests/index.test.js | 9 -
.../EmailTemplates/tests/utils/server.js | 41 -
.../src/pages/Providers/tests/index.test.js | 8 -
.../admin/src/pages/Providers/tests/server.js | 26 -
.../{CreatePage/index.js => CreatePage.js} | 16 +-
.../Roles/CreatePage/tests/index.test.js | 1059 --------------
.../pages/Roles/CreatePage/tests/server.js | 65 -
.../Roles/{EditPage/index.js => EditPage.js} | 34 +-
.../pages/Roles/EditPage/tests/index.test.js | 1221 -----------------
.../src/pages/Roles/EditPage/tests/server.js | 95 --
.../src/pages/Roles/EditPage/utils/schema.js | 9 -
.../pages/Roles/ListPage/tests/index.test.js | 763 +---------
.../src/pages/Roles/ListPage/tests/server.js | 33 -
.../src/pages/Roles/ListPage/utils/api.js | 2 +-
.../index.js => ProtectedCreatePage.js} | 5 +-
.../index.js => ProtectedEditPage.js} | 5 +-
.../index.js => ProtectedListPage.js} | 5 +-
.../utils/schema.js => constants.js} | 4 +-
.../src/pages/Roles/tests/CreatePage.test.js | 108 ++
.../src/pages/Roles/tests/EditPage.test.js | 155 +++
.../users-permissions/jest.config.front.js | 1 +
.../plugins/users-permissions/package.json | 1 -
.../plugins/users-permissions/tests/server.js | 191 +++
.../plugins/users-permissions/tests/setup.js | 15 +
yarn.lock | 1 -
35 files changed, 671 insertions(+), 3570 deletions(-)
create mode 100644 packages/plugins/users-permissions/admin/src/hooks/usePlugins.js
delete mode 100644 packages/plugins/users-permissions/admin/src/hooks/usePlugins/index.js
delete mode 100644 packages/plugins/users-permissions/admin/src/hooks/usePlugins/init.js
delete mode 100644 packages/plugins/users-permissions/admin/src/hooks/usePlugins/reducer.js
delete mode 100644 packages/plugins/users-permissions/admin/src/hooks/usePlugins/tests/init.test.js
delete mode 100644 packages/plugins/users-permissions/admin/src/hooks/usePlugins/tests/reducer.test.js
delete mode 100644 packages/plugins/users-permissions/admin/src/pages/AdvancedSettings/tests/utils/server.js
delete mode 100644 packages/plugins/users-permissions/admin/src/pages/EmailTemplates/tests/utils/server.js
delete mode 100644 packages/plugins/users-permissions/admin/src/pages/Providers/tests/server.js
rename packages/plugins/users-permissions/admin/src/pages/Roles/{CreatePage/index.js => CreatePage.js} (94%)
delete mode 100644 packages/plugins/users-permissions/admin/src/pages/Roles/CreatePage/tests/index.test.js
delete mode 100644 packages/plugins/users-permissions/admin/src/pages/Roles/CreatePage/tests/server.js
rename packages/plugins/users-permissions/admin/src/pages/Roles/{EditPage/index.js => EditPage.js} (95%)
delete mode 100644 packages/plugins/users-permissions/admin/src/pages/Roles/EditPage/tests/index.test.js
delete mode 100644 packages/plugins/users-permissions/admin/src/pages/Roles/EditPage/tests/server.js
delete mode 100644 packages/plugins/users-permissions/admin/src/pages/Roles/EditPage/utils/schema.js
delete mode 100644 packages/plugins/users-permissions/admin/src/pages/Roles/ListPage/tests/server.js
rename packages/plugins/users-permissions/admin/src/pages/Roles/{ProtectedCreatePage/index.js => ProtectedCreatePage.js} (74%)
rename packages/plugins/users-permissions/admin/src/pages/Roles/{ProtectedEditPage/index.js => ProtectedEditPage.js} (75%)
rename packages/plugins/users-permissions/admin/src/pages/Roles/{ProtectedListPage/index.js => ProtectedListPage.js} (76%)
rename packages/plugins/users-permissions/admin/src/pages/Roles/{CreatePage/utils/schema.js => constants.js} (78%)
create mode 100644 packages/plugins/users-permissions/admin/src/pages/Roles/tests/CreatePage.test.js
create mode 100644 packages/plugins/users-permissions/admin/src/pages/Roles/tests/EditPage.test.js
create mode 100644 packages/plugins/users-permissions/tests/server.js
create mode 100644 packages/plugins/users-permissions/tests/setup.js
diff --git a/packages/plugins/users-permissions/admin/src/components/Permissions/PermissionRow/SubCategory.js b/packages/plugins/users-permissions/admin/src/components/Permissions/PermissionRow/SubCategory.js
index 924883932d..a9a91bdffc 100644
--- a/packages/plugins/users-permissions/admin/src/components/Permissions/PermissionRow/SubCategory.js
+++ b/packages/plugins/users-permissions/admin/src/components/Permissions/PermissionRow/SubCategory.js
@@ -1,6 +1,14 @@
import React, { useCallback, useMemo } from 'react';
-import { Box, Checkbox, Flex, Grid, GridItem, Typography } from '@strapi/design-system';
+import {
+ Box,
+ Checkbox,
+ Flex,
+ Typography,
+ Grid,
+ GridItem,
+ VisuallyHidden,
+} from '@strapi/design-system';
import { Cog as CogIcon } from '@strapi/icons';
import get from 'lodash/get';
import PropTypes from 'prop-types';
@@ -90,10 +98,20 @@ const SubCategory = ({ subCategory }) => {
diff --git a/packages/plugins/users-permissions/admin/src/hooks/index.js b/packages/plugins/users-permissions/admin/src/hooks/index.js
index 3b6a597d15..9988733f3f 100644
--- a/packages/plugins/users-permissions/admin/src/hooks/index.js
+++ b/packages/plugins/users-permissions/admin/src/hooks/index.js
@@ -1,5 +1,5 @@
// eslint-disable-next-line import/prefer-default-export
-export { default as useFetchRole } from './useFetchRole';
export { default as useForm } from './useForm';
-export { default as usePlugins } from './usePlugins';
export { default as useRolesList } from './useRolesList';
+export * from './usePlugins';
+export { default as useFetchRole } from './useFetchRole';
diff --git a/packages/plugins/users-permissions/admin/src/hooks/usePlugins.js b/packages/plugins/users-permissions/admin/src/hooks/usePlugins.js
new file mode 100644
index 0000000000..ce1f0e8d23
--- /dev/null
+++ b/packages/plugins/users-permissions/admin/src/hooks/usePlugins.js
@@ -0,0 +1,71 @@
+import { useEffect } from 'react';
+
+import { useNotification, useFetchClient, useAPIErrorHandler } from '@strapi/helper-plugin';
+import { useQueries } from 'react-query';
+
+import pluginId from '../pluginId';
+import { cleanPermissions, getTrad } from '../utils';
+
+export const usePlugins = () => {
+ const toggleNotification = useNotification();
+ const { get } = useFetchClient();
+ const { formatAPIError } = useAPIErrorHandler(getTrad);
+
+ const [
+ {
+ data: permissions,
+ isLoading: isLoadingPermissions,
+ error: permissionsError,
+ refetch: refetchPermissions,
+ },
+ { data: routes, isLoading: isLoadingRoutes, error: routesError, refetch: refetchRoutes },
+ ] = useQueries([
+ {
+ queryKey: [pluginId, 'permissions'],
+ async queryFn() {
+ const res = await get(`/${pluginId}/permissions`);
+
+ return res.data.permissions;
+ },
+ },
+ {
+ queryKey: [pluginId, 'routes'],
+ async queryFn() {
+ const res = await get(`/${pluginId}/routes`);
+
+ return res.data.routes;
+ },
+ },
+ ]);
+
+ const refetchQueries = async () => {
+ await Promise.all([refetchPermissions(), refetchRoutes()]);
+ };
+
+ useEffect(() => {
+ if (permissionsError) {
+ toggleNotification({
+ type: 'warning',
+ message: formatAPIError(permissionsError),
+ });
+ }
+ }, [toggleNotification, permissionsError, formatAPIError]);
+
+ useEffect(() => {
+ if (routesError) {
+ toggleNotification({
+ type: 'warning',
+ message: formatAPIError(routesError),
+ });
+ }
+ }, [toggleNotification, routesError, formatAPIError]);
+
+ const isLoading = isLoadingPermissions || isLoadingRoutes;
+
+ return {
+ permissions: permissions ? cleanPermissions(permissions) : {},
+ routes: routes ?? {},
+ getData: refetchQueries,
+ isLoading,
+ };
+};
diff --git a/packages/plugins/users-permissions/admin/src/hooks/usePlugins/index.js b/packages/plugins/users-permissions/admin/src/hooks/usePlugins/index.js
deleted file mode 100644
index d1abd28af5..0000000000
--- a/packages/plugins/users-permissions/admin/src/hooks/usePlugins/index.js
+++ /dev/null
@@ -1,70 +0,0 @@
-import { useCallback, useEffect, useReducer } from 'react';
-
-import { useFetchClient, useNotification } from '@strapi/helper-plugin';
-import get from 'lodash/get';
-
-import pluginId from '../../pluginId';
-import { cleanPermissions } from '../../utils';
-
-import init from './init';
-import reducer, { initialState } from './reducer';
-
-const usePlugins = (shouldFetchData = true) => {
- const toggleNotification = useNotification();
- const [{ permissions, routes, isLoading }, dispatch] = useReducer(reducer, initialState, () =>
- init(initialState, shouldFetchData)
- );
- const fetchClient = useFetchClient();
-
- const fetchPlugins = useCallback(async () => {
- try {
- dispatch({
- type: 'GET_DATA',
- });
-
- const [{ permissions }, { routes }] = await Promise.all(
- [`/${pluginId}/permissions`, `/${pluginId}/routes`].map(async (endpoint) => {
- const res = await fetchClient.get(endpoint);
-
- return res.data;
- })
- );
-
- dispatch({
- type: 'GET_DATA_SUCCEEDED',
- permissions: cleanPermissions(permissions),
- routes,
- });
- } catch (err) {
- const message = get(err, ['response', 'payload', 'message'], 'An error occured');
-
- dispatch({
- type: 'GET_DATA_ERROR',
- });
-
- if (message !== 'Forbidden') {
- toggleNotification({
- type: 'warning',
- message,
- });
- }
- }
-
- // eslint-disable-next-line react-hooks/exhaustive-deps
- }, [toggleNotification]);
-
- useEffect(() => {
- if (shouldFetchData) {
- fetchPlugins();
- }
- }, [fetchPlugins, shouldFetchData]);
-
- return {
- permissions,
- routes,
- getData: fetchPlugins,
- isLoading,
- };
-};
-
-export default usePlugins;
diff --git a/packages/plugins/users-permissions/admin/src/hooks/usePlugins/init.js b/packages/plugins/users-permissions/admin/src/hooks/usePlugins/init.js
deleted file mode 100644
index dfe71d9376..0000000000
--- a/packages/plugins/users-permissions/admin/src/hooks/usePlugins/init.js
+++ /dev/null
@@ -1,5 +0,0 @@
-const init = (initialState, shouldFetchData) => {
- return { ...initialState, isLoading: shouldFetchData };
-};
-
-export default init;
diff --git a/packages/plugins/users-permissions/admin/src/hooks/usePlugins/reducer.js b/packages/plugins/users-permissions/admin/src/hooks/usePlugins/reducer.js
deleted file mode 100644
index 8a19db2dd2..0000000000
--- a/packages/plugins/users-permissions/admin/src/hooks/usePlugins/reducer.js
+++ /dev/null
@@ -1,34 +0,0 @@
-/* eslint-disable consistent-return */
-import produce from 'immer';
-
-export const initialState = {
- permissions: {},
- routes: {},
- isLoading: true,
-};
-
-const reducer = (state, action) =>
- produce(state, (draftState) => {
- switch (action.type) {
- case 'GET_DATA': {
- draftState.isLoading = true;
- draftState.permissions = {};
- draftState.routes = {};
- break;
- }
- case 'GET_DATA_SUCCEEDED': {
- draftState.permissions = action.permissions;
- draftState.routes = action.routes;
- draftState.isLoading = false;
- break;
- }
- case 'GET_DATA_ERROR': {
- draftState.isLoading = false;
- break;
- }
- default:
- return draftState;
- }
- });
-
-export default reducer;
diff --git a/packages/plugins/users-permissions/admin/src/hooks/usePlugins/tests/init.test.js b/packages/plugins/users-permissions/admin/src/hooks/usePlugins/tests/init.test.js
deleted file mode 100644
index 9900a6bcb3..0000000000
--- a/packages/plugins/users-permissions/admin/src/hooks/usePlugins/tests/init.test.js
+++ /dev/null
@@ -1,32 +0,0 @@
-import init from '../init';
-
-describe('USERS PERMISSIONS | HOOKS | usePlugins | init', () => {
- it('should return the initial state and set the isLoading key to true', () => {
- const initialState = {
- ok: true,
- };
-
- const expected = {
- ok: true,
- isLoading: true,
- };
-
- expect(init(initialState, true)).toEqual(expected);
- });
-
- it('should return the initial state and set the isLoading key to false', () => {
- const initialState = {
- permissions: {},
- routes: {},
- isLoading: null,
- };
-
- const expected = {
- permissions: {},
- routes: {},
- isLoading: false,
- };
-
- expect(init(initialState, false)).toEqual(expected);
- });
-});
diff --git a/packages/plugins/users-permissions/admin/src/hooks/usePlugins/tests/reducer.test.js b/packages/plugins/users-permissions/admin/src/hooks/usePlugins/tests/reducer.test.js
deleted file mode 100644
index c9e62e2942..0000000000
--- a/packages/plugins/users-permissions/admin/src/hooks/usePlugins/tests/reducer.test.js
+++ /dev/null
@@ -1,96 +0,0 @@
-import reducer from '../reducer';
-
-describe('USERS PERMISSIONS | HOOKS | usePlugins | reducer', () => {
- describe('DEFAULT_ACTION', () => {
- it('should return the initialState', () => {
- const state = {
- test: true,
- };
-
- expect(reducer(state, {})).toEqual(state);
- });
- });
-
- describe('GET_DATA', () => {
- it('should set the isLoading key to true', () => {
- const state = {
- permissions: { ok: true },
- routes: { ok: true },
- isLoading: false,
- };
-
- const action = {
- type: 'GET_DATA',
- };
-
- const expected = {
- permissions: {},
- routes: {},
- isLoading: true,
- };
-
- expect(reducer(state, action)).toEqual(expected);
- });
- });
-
- describe('GET_DATA_ERROR', () => {
- it('should set isLoading to false is an error occured', () => {
- const action = {
- type: 'GET_DATA_ERROR',
- };
- const initialState = {
- permissions: {},
- routes: {},
- isLoading: true,
- };
- const expected = {
- permissions: {},
- routes: {},
- isLoading: false,
- };
-
- expect(reducer(initialState, action)).toEqual(expected);
- });
- });
-
- describe('GET_DATA_SUCCEEDED', () => {
- it('should return the state with the permissions list', () => {
- const action = {
- type: 'GET_DATA_SUCCEEDED',
- permissions: {
- application: {
- controllers: {
- address: {
- count: { enabled: false },
- },
- },
- },
- },
- routes: {
- application: [{ method: 'GET', path: '/addresses' }],
- },
- };
- const initialState = {
- permissions: {},
- isLoading: true,
- };
- const expected = {
- permissions: {
- application: {
- controllers: {
- address: {
- count: { enabled: false },
- },
- },
- },
- },
- routes: {
- application: [{ method: 'GET', path: '/addresses' }],
- },
- isLoading: false,
- };
-
- expect(reducer(initialState, action)).toEqual(expected);
- });
- });
-});
diff --git a/packages/plugins/users-permissions/admin/src/pages/AdvancedSettings/tests/index.test.js b/packages/plugins/users-permissions/admin/src/pages/AdvancedSettings/tests/index.test.js
index db3cf66616..5b487fb47b 100644
--- a/packages/plugins/users-permissions/admin/src/pages/AdvancedSettings/tests/index.test.js
+++ b/packages/plugins/users-permissions/admin/src/pages/AdvancedSettings/tests/index.test.js
@@ -8,8 +8,6 @@ import { QueryClient, QueryClientProvider } from 'react-query';
import ProtectedAdvancedSettingsPage from '../index';
-import server from './utils/server';
-
jest.mock('@strapi/helper-plugin', () => ({
...jest.requireActual('@strapi/helper-plugin'),
useNotification: jest.fn(),
@@ -38,19 +36,12 @@ const App = (
);
describe('ADMIN | Pages | Settings | Advanced Settings', () => {
- beforeAll(() => server.listen());
-
beforeEach(() => {
jest.clearAllMocks();
});
- afterEach(() => {
- server.resetHandlers();
- });
-
afterAll(() => {
jest.resetAllMocks();
- server.close();
});
it('renders and matches the snapshot', async () => {
diff --git a/packages/plugins/users-permissions/admin/src/pages/AdvancedSettings/tests/utils/server.js b/packages/plugins/users-permissions/admin/src/pages/AdvancedSettings/tests/utils/server.js
deleted file mode 100644
index 644d99cfce..0000000000
--- a/packages/plugins/users-permissions/admin/src/pages/AdvancedSettings/tests/utils/server.js
+++ /dev/null
@@ -1,26 +0,0 @@
-import { rest } from 'msw';
-import { setupServer } from 'msw/node';
-
-const handlers = [
- rest.get('*/advanced', (req, res, ctx) => {
- return res(
- ctx.delay(100),
- ctx.status(200),
- ctx.json({
- roles: [{ name: 'Authenticated', type: 'authenticated' }],
- settings: {
- allow_register: false,
- default_role: 'authenticated',
- email_confirmation: false,
- email_confirmation_redirection: '',
- email_reset_password: 'https://cat-bounce.com/',
- unique_email: false,
- },
- })
- );
- }),
-];
-
-const server = setupServer(...handlers);
-
-export default server;
diff --git a/packages/plugins/users-permissions/admin/src/pages/EmailTemplates/tests/index.test.js b/packages/plugins/users-permissions/admin/src/pages/EmailTemplates/tests/index.test.js
index 4568143899..49af90dcc3 100644
--- a/packages/plugins/users-permissions/admin/src/pages/EmailTemplates/tests/index.test.js
+++ b/packages/plugins/users-permissions/admin/src/pages/EmailTemplates/tests/index.test.js
@@ -8,8 +8,6 @@ import { QueryClient, QueryClientProvider } from 'react-query';
import ProtectedEmailTemplatesPage from '../index';
-import server from './utils/server';
-
jest.mock('@strapi/helper-plugin', () => ({
...jest.requireActual('@strapi/helper-plugin'),
useNotification: jest.fn(),
@@ -38,19 +36,12 @@ const App = (
);
describe('ADMIN | Pages | Settings | Email Templates', () => {
- beforeAll(() => server.listen());
-
beforeEach(() => {
jest.clearAllMocks();
});
- afterEach(() => {
- server.resetHandlers();
- });
-
afterAll(() => {
jest.resetAllMocks();
- server.close();
});
it('renders and matches the snapshot', async () => {
diff --git a/packages/plugins/users-permissions/admin/src/pages/EmailTemplates/tests/utils/server.js b/packages/plugins/users-permissions/admin/src/pages/EmailTemplates/tests/utils/server.js
deleted file mode 100644
index e01d131332..0000000000
--- a/packages/plugins/users-permissions/admin/src/pages/EmailTemplates/tests/utils/server.js
+++ /dev/null
@@ -1,41 +0,0 @@
-import { rest } from 'msw';
-import { setupServer } from 'msw/node';
-
-const handlers = [
- rest.get('*/email-templates', (req, res, ctx) => {
- return res(
- ctx.delay(100),
- ctx.status(200),
- ctx.json({
- email_confirmation: {
- display: 'Email.template.email_confirmation',
- options: {
- from: {
- email: 'mochoko@strapi.io',
- name: 'Administration Panel',
- },
- message: 'Thank you for registering. Please click on the link below.',
- object: 'Account confirmation',
- response_email: '',
- },
- },
- reset_password: {
- display: 'Email.template.reset_password',
- options: {
- from: {
- email: 'mochoko@strapi.io',
- name: 'Administration Panel',
- },
- message: 'We heard that you lost your password. Sorry about that!',
- object: 'Reset password',
- response_email: '',
- },
- },
- })
- );
- }),
-];
-
-const server = setupServer(...handlers);
-
-export default server;
diff --git a/packages/plugins/users-permissions/admin/src/pages/Providers/tests/index.test.js b/packages/plugins/users-permissions/admin/src/pages/Providers/tests/index.test.js
index 549b297511..a63aee292d 100644
--- a/packages/plugins/users-permissions/admin/src/pages/Providers/tests/index.test.js
+++ b/packages/plugins/users-permissions/admin/src/pages/Providers/tests/index.test.js
@@ -8,8 +8,6 @@ import { QueryClient, QueryClientProvider } from 'react-query';
import { ProvidersPage } from '../index';
-import server from './server';
-
jest.mock('@strapi/helper-plugin', () => ({
...jest.requireActual('@strapi/helper-plugin'),
useNotification: jest.fn(),
@@ -36,16 +34,10 @@ const App = (
);
describe('Admin | containers | ProvidersPage', () => {
- beforeAll(() => server.listen());
-
beforeEach(() => {
jest.clearAllMocks();
});
- afterEach(() => server.resetHandlers());
-
- afterAll(() => server.close());
-
it('renders and matches the snapshot', () => {
useRBAC.mockImplementation(() => ({
isLoading: true,
diff --git a/packages/plugins/users-permissions/admin/src/pages/Providers/tests/server.js b/packages/plugins/users-permissions/admin/src/pages/Providers/tests/server.js
deleted file mode 100644
index 16125084e6..0000000000
--- a/packages/plugins/users-permissions/admin/src/pages/Providers/tests/server.js
+++ /dev/null
@@ -1,26 +0,0 @@
-import { rest } from 'msw';
-import { setupServer } from 'msw/node';
-
-const handlers = [
- rest.get('*/providers', (req, res, ctx) => {
- return res(
- ctx.delay(1000),
- ctx.status(200),
- ctx.json({
- email: { enabled: true, icon: 'envelope' },
- discord: {
- callback: '/auth/discord/callback',
- enabled: false,
- icon: 'discord',
- key: '',
- scope: ['identify', 'email'],
- secret: '',
- },
- })
- );
- }),
-];
-
-const server = setupServer(...handlers);
-
-export default server;
diff --git a/packages/plugins/users-permissions/admin/src/pages/Roles/CreatePage/index.js b/packages/plugins/users-permissions/admin/src/pages/Roles/CreatePage.js
similarity index 94%
rename from packages/plugins/users-permissions/admin/src/pages/Roles/CreatePage/index.js
rename to packages/plugins/users-permissions/admin/src/pages/Roles/CreatePage.js
index 9744ec4630..15888f7ffc 100644
--- a/packages/plugins/users-permissions/admin/src/pages/Roles/CreatePage/index.js
+++ b/packages/plugins/users-permissions/admin/src/pages/Roles/CreatePage.js
@@ -26,14 +26,14 @@ import { Formik } from 'formik';
import { useIntl } from 'react-intl';
import { useHistory } from 'react-router-dom';
-import UsersPermissions from '../../../components/UsersPermissions';
-import { usePlugins } from '../../../hooks';
-import pluginId from '../../../pluginId';
-import getTrad from '../../../utils/getTrad';
+import UsersPermissions from '../../components/UsersPermissions';
+import { usePlugins } from '../../hooks';
+import pluginId from '../../pluginId';
+import getTrad from '../../utils/getTrad';
-import schema from './utils/schema';
+import { createRoleSchema } from './constants';
-const EditPage = () => {
+const CreatePage = () => {
const { formatMessage } = useIntl();
const [isSubmitting, setIsSubmitting] = useState(false);
const toggleNotification = useNotification();
@@ -85,7 +85,7 @@ const EditPage = () => {
enableReinitialize
initialValues={{ name: '', description: '' }}
onSubmit={handleCreateRoleSubmit}
- validationSchema={schema}
+ validationSchema={createRoleSchema}
>
{({ handleSubmit, values, handleChange, errors }) => (