From bcd907522963767d1489bc95806ceedda807811f Mon Sep 17 00:00:00 2001 From: soupette Date: Fri, 28 Aug 2020 09:43:48 +0200 Subject: [PATCH] Remove useless files Signed-off-by: soupette --- .../admin/src/containers/Initializer/index.js | 27 ----------------- .../Initializer/tests/index.test.js | 17 ----------- .../admin/src/index.js | 6 ++-- .../admin/src/lifecycles.js | 30 ------------------- 4 files changed, 2 insertions(+), 78 deletions(-) delete mode 100644 packages/strapi-plugin-users-permissions/admin/src/containers/Initializer/index.js delete mode 100644 packages/strapi-plugin-users-permissions/admin/src/containers/Initializer/tests/index.test.js delete mode 100644 packages/strapi-plugin-users-permissions/admin/src/lifecycles.js diff --git a/packages/strapi-plugin-users-permissions/admin/src/containers/Initializer/index.js b/packages/strapi-plugin-users-permissions/admin/src/containers/Initializer/index.js deleted file mode 100644 index fd0659a007..0000000000 --- a/packages/strapi-plugin-users-permissions/admin/src/containers/Initializer/index.js +++ /dev/null @@ -1,27 +0,0 @@ -/** - * - * Initializer - * - */ - -import { memo, useEffect, useRef } from 'react'; -import PropTypes from 'prop-types'; -import pluginId from '../../pluginId'; - -const Initializer = ({ updatePlugin }) => { - const ref = useRef(); - ref.current = updatePlugin; - - useEffect(() => { - ref.current(pluginId, 'isReady', true); - }, []); - - return null; -}; - -Initializer.propTypes = { - updatePlugin: PropTypes.func.isRequired, -}; - -export default memo(Initializer); -export { Initializer }; diff --git a/packages/strapi-plugin-users-permissions/admin/src/containers/Initializer/tests/index.test.js b/packages/strapi-plugin-users-permissions/admin/src/containers/Initializer/tests/index.test.js deleted file mode 100644 index 15ad188e27..0000000000 --- a/packages/strapi-plugin-users-permissions/admin/src/containers/Initializer/tests/index.test.js +++ /dev/null @@ -1,17 +0,0 @@ -import React from 'react'; -import { mount, shallow } from 'enzyme'; - -import { Initializer } from '../index'; - -describe('', () => { - it('should not crash', () => { - shallow(); - }); - - it('should call the updatePlugin props on mount', () => { - const props = { updatePlugin: jest.fn() }; - mount(); - - expect(props.updatePlugin).toHaveBeenCalledWith('users-permissions', 'isReady', true); - }); -}); diff --git a/packages/strapi-plugin-users-permissions/admin/src/index.js b/packages/strapi-plugin-users-permissions/admin/src/index.js index 73e3efe3af..345fafcb60 100644 --- a/packages/strapi-plugin-users-permissions/admin/src/index.js +++ b/packages/strapi-plugin-users-permissions/admin/src/index.js @@ -11,8 +11,6 @@ import pluginLogo from './assets/images/logo.svg'; import pluginPermissions from './permissions'; import layout from '../../config/layout'; import pluginId from './pluginId'; -import Initializer from './containers/Initializer'; -import lifecycles from './lifecycles'; import trads from './translations'; import RolesPage from './containers/Roles'; import ProvidersPage from './containers/Providers'; @@ -31,11 +29,11 @@ export default strapi => { description: pluginDescription, icon, id: pluginId, - initializer: Initializer, + initializer: null, + isReady: true, injectedComponents: [], isRequired: pluginPkg.strapi.required || false, layout, - lifecycles, mainComponent: null, name, pluginLogo, diff --git a/packages/strapi-plugin-users-permissions/admin/src/lifecycles.js b/packages/strapi-plugin-users-permissions/admin/src/lifecycles.js deleted file mode 100644 index e287457c36..0000000000 --- a/packages/strapi-plugin-users-permissions/admin/src/lifecycles.js +++ /dev/null @@ -1,30 +0,0 @@ -/* - * - * SET THE HOOKS TO ENABLE THE MAGIC OF STRAPI. - * ------------------------------------------- - * - * Secure, customise and enhance your project by setting - * the hooks via this file. - * - */ - -function lifecycles() { - // TODO: Make it work and remove it when the split-admin PR has been merged - // const componentsToAdd = [ - // { - // area: 'NavRight', - // key: 'UsersPermissionsLogout', - // mainComponent: require('./components/Logout').default, - // }, - // ]; - // this.setComponents(componentsToAdd); - // Set hooks for the AdminPage container. - // Note: we don't need to specify the first argument because we already know what "willSecure" refers to. - // Set hooks for the App container of the Content Manager. - // Note: we have to specify the first argument to select a specific container which is located in a plugin, or not. - // this.setHooks('content-manager.App', { - // willSomething: (props, store) => { console.log("Do Something"); } - // }); -} - -export default lifecycles;