yujunjun/strapi
1
0
Fork 0
mirror of https://github.com/strapi/strapi.git synced 2025-12-28 07:33:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #8615 from strapi/fix/update-notif-file-access

Browse Source 
Fix write access error of the update-notifier
This commit is contained in:
Alexandre BODIN 2020-11-10 19:01:09 +01:00 committed by GitHub
commit c4e681e017
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 18 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
packages/strapi/lib/utils/update-notifier/index.js
View File

@ -1,12 +1,15 @@
'use strict';
const path = require('path');
const packageJson = require('package-json');
const Configstore = require('configstore');
const semver = require('semver');
const boxen = require('boxen');
const chalk = require('chalk');
const path = require('path');
const pkg = require('../../../package');
const { env } = require('strapi-utils');
const pkg = require('../../../package');
const CHECK_INTERVAL = 1000 * 60 * 60 * 24 * 1; // 1 day
const NOTIF_INTERVAL = 1000 * 60 * 60 * 24 * 7; // 1 week
const boxenOptions = {
@ -29,11 +32,18 @@ Check out the new the releases at: ${releaseLink}
};
const createUpdateNotifier = strapi => {
const config = new Configstore(
pkg.name,
{},
{ configPath: path.join(strapi.dir, '.strapi-updater.json') }
);
let config = null;
try {
config = new Configstore(
pkg.name,
{},
{ configPath: path.join(strapi.dir, '.strapi-updater.json') }
);
} catch {
// we don't have write access to the file system
// we silence the error
}
const checkUpdate = async checkInterval => {
const now = Date.now();
@ -74,7 +84,7 @@ const createUpdateNotifier = strapi => {
return {
notify({ checkInterval = CHECK_INTERVAL, notifInterval = NOTIF_INTERVAL } = {}) {
if (env.bool('STRAPI_DISABLE_UPDATE_NOTIFICATION', false)) {
if (env.bool('STRAPI_DISABLE_UPDATE_NOTIFICATION', false) || !config) {
return;
}
display(notifInterval);