fix: remove overflow hidden to allow react-select menu to break out of accordion

This commit is contained in:
Josh 2022-12-08 09:14:17 +00:00
parent 223d1195e5
commit c5ec5bdb65
2 changed files with 31 additions and 30 deletions

View File

@ -325,35 +325,37 @@ const RelationInput = ({
)
}
>
<RelationList overflow={overflow}>
<VisuallyHidden id={ariaDescriptionId}>{listAriaDescription}</VisuallyHidden>
<VisuallyHidden aria-live="assertive">{liveText}</VisuallyHidden>
<List
height={dynamicListHeight}
ref={listRef}
outerRef={outerListRef}
itemCount={totalNumberOfRelations}
itemSize={RELATION_ITEM_HEIGHT + RELATION_GUTTER}
itemData={{
ariaDescribedBy: ariaDescriptionId,
canDrag: canReorder,
disabled,
handleCancel: onCancel,
handleDropItem: onDropItem,
handleGrabItem: onGrabItem,
iconButtonAriaLabel,
labelDisconnectRelation,
onRelationDisconnect,
publicationStateTranslations,
relations,
updatePositionOfRelation: handleUpdatePositionOfRelation,
}}
itemKey={(index, { relations: relationsItems }) => relationsItems[index].id}
innerElementType="ol"
>
{ListItem}
</List>
</RelationList>
{relations.length > 0 ? (
<RelationList overflow={overflow}>
<VisuallyHidden id={ariaDescriptionId}>{listAriaDescription}</VisuallyHidden>
<VisuallyHidden aria-live="assertive">{liveText}</VisuallyHidden>
<List
height={dynamicListHeight}
ref={listRef}
outerRef={outerListRef}
itemCount={totalNumberOfRelations}
itemSize={RELATION_ITEM_HEIGHT + RELATION_GUTTER}
itemData={{
ariaDescribedBy: ariaDescriptionId,
canDrag: canReorder,
disabled,
handleCancel: onCancel,
handleDropItem: onDropItem,
handleGrabItem: onGrabItem,
iconButtonAriaLabel,
labelDisconnectRelation,
onRelationDisconnect,
publicationStateTranslations,
relations,
updatePositionOfRelation: handleUpdatePositionOfRelation,
}}
itemKey={(index, { relations: relationsItems }) => relationsItems[index].id}
innerElementType="ol"
>
{ListItem}
</List>
</RelationList>
) : null}
{(description || error) && (
<Box paddingTop={2}>
<FieldHint />

View File

@ -14,7 +14,6 @@ export const Footer = styled(Box)`
export const Content = styled(Box)`
border-bottom: none;
overflow: hidden;
/* add the borders and make sure the top is transparent to avoid jumping with the hover effect */
& > div > div {