From 21c57644b12ce0e70e6fd7cffb57d82d079aa041 Mon Sep 17 00:00:00 2001 From: Bassel Kanso Date: Thu, 3 Oct 2024 17:49:46 +0300 Subject: [PATCH 1/3] fix: copy button shown on v4 plugins --- .../src/pages/Marketplace/components/NpmPackageCard.tsx | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/core/admin/admin/src/pages/Marketplace/components/NpmPackageCard.tsx b/packages/core/admin/admin/src/pages/Marketplace/components/NpmPackageCard.tsx index 5b34b73fc6..808879a842 100644 --- a/packages/core/admin/admin/src/pages/Marketplace/components/NpmPackageCard.tsx +++ b/packages/core/admin/admin/src/pages/Marketplace/components/NpmPackageCard.tsx @@ -66,7 +66,10 @@ const NpmPackageCard = ({ }`; const versionRange = semver.validRange(attributes.strapiVersion); - const isCompatible = semver.satisfies(strapiAppVersion ?? '', versionRange ?? ''); + + const isCompatible = versionRange + ? semver.satisfies(strapiAppVersion ?? '', versionRange) + : false; return ( Date: Thu, 3 Oct 2024 21:03:47 +0300 Subject: [PATCH 2/3] fix: add test and don't show tooltip --- .../Marketplace/components/NpmPackageCard.tsx | 33 +++++++------------ .../tests/MarketplacePage.test.tsx | 18 +++------- 2 files changed, 16 insertions(+), 35 deletions(-) diff --git a/packages/core/admin/admin/src/pages/Marketplace/components/NpmPackageCard.tsx b/packages/core/admin/admin/src/pages/Marketplace/components/NpmPackageCard.tsx index 808879a842..eb19e6b13a 100644 --- a/packages/core/admin/admin/src/pages/Marketplace/components/NpmPackageCard.tsx +++ b/packages/core/admin/admin/src/pages/Marketplace/components/NpmPackageCard.tsx @@ -275,28 +275,17 @@ const CardButton = ({ return (