fix permission + simplify test

packages/core/content-manager/server/controllers/relations.js

@@ -29,7 +29,7 @@ module.exports = {
       const entityManager = getService('entity-manager');
       const permissionChecker = getService('permission-checker').create({
         userAbility,
-        model: sourceModel,
+        model,
       });
 
       if (permissionChecker.cannot.read()) {

packages/core/content-manager/server/tests/relations.test.e2e.js

@@ -61,6 +61,15 @@ const shopModel = {
   pluralName: 'shops',
 };
 
+const createEntry = async (uid, data) => {
+  const { body } = await rq({
+    method: 'POST',
+    url: `/content-manager/collection-types/${uid}`,
+    body: data,
+  });
+  return body;
+};
+
 describe('Relations', () => {
   const builder = createTestBuilder();
 
@@ -74,28 +83,16 @@ describe('Relations', () => {
     strapi = await createStrapiInstance();
     rq = await createAuthRequest({ strapi });
 
-    const { body: createdProduct1 } = await rq({
+    const createdProduct1 = await createEntry('api::product.product', { name: 'Skate' });
-      method: 'POST',
+    const createdProduct2 = await createEntry('api::product.product', { name: 'Candle' });
-      url: '/content-manager/collection-types/api::product.product',
-      body: { name: 'Skate' },
-    });
-    const { body: createdProduct2 } = await rq({
-      method: 'POST',
-      url: '/content-manager/collection-types/api::product.product',
-      body: { name: 'Candle' },
-    });
 
     data.products.push(createdProduct1);
     data.products.push(createdProduct2);
 
-    const { body: createdShop } = await rq({
+    const createdShop = await createEntry('api::shop.shop', {
-      method: 'POST',
-      url: '/content-manager/collection-types/api::shop.shop',
-      body: {
       name: 'Cazotte Shop',
       products: [createdProduct1.id],
       myCompo: { compoProducts: [createdProduct2.id] },
-      },
     });
 
     data.shops.push(createdShop);