From c8ca3f49e2b61b598d36f373352b0bb0894e3ed8 Mon Sep 17 00:00:00 2001 From: Gustav Hansen Date: Thu, 24 Mar 2022 17:31:44 +0100 Subject: [PATCH] FolderCard: Restructure component files --- .../components/FolderCard/{ => FolderCard}/FolderCard.js | 6 +++--- .../admin/src/components/FolderCard/FolderCard/index.js | 1 + .../FolderCard/{ => FolderCardBody}/FolderCardBody.js | 2 +- .../src/components/FolderCard/FolderCardBody/index.js | 1 + .../{ => FolderCardCheckbox}/FolderCardCheckbox.js | 2 +- .../src/components/FolderCard/FolderCardCheckbox/index.js | 1 + .../{FolderCardContext.js => contexts/FolderCard.js} | 2 +- .../FolderCard/{utils => hooks}/tests/useId.test.js | 0 .../src/components/FolderCard/{utils => hooks}/useId.js | 4 ++-- .../core/upload/admin/src/components/FolderCard/index.js | 3 ++- .../FolderCard/{FolderCardLink.js => styled.js} | 0 .../src/components/FolderCard/tests/FolderCard.test.js | 3 +-- .../tests/__snapshots__/FolderCard.test.js.snap | 8 +++----- 13 files changed, 17 insertions(+), 16 deletions(-) rename packages/core/upload/admin/src/components/FolderCard/{ => FolderCard}/FolderCard.js (93%) create mode 100644 packages/core/upload/admin/src/components/FolderCard/FolderCard/index.js rename packages/core/upload/admin/src/components/FolderCard/{ => FolderCardBody}/FolderCardBody.js (88%) create mode 100644 packages/core/upload/admin/src/components/FolderCard/FolderCardBody/index.js rename packages/core/upload/admin/src/components/FolderCard/{ => FolderCardCheckbox}/FolderCardCheckbox.js (86%) create mode 100644 packages/core/upload/admin/src/components/FolderCard/FolderCardCheckbox/index.js rename packages/core/upload/admin/src/components/FolderCard/{FolderCardContext.js => contexts/FolderCard.js} (71%) rename packages/core/upload/admin/src/components/FolderCard/{utils => hooks}/tests/useId.test.js (100%) rename packages/core/upload/admin/src/components/FolderCard/{utils => hooks}/useId.js (55%) rename packages/core/upload/admin/src/components/FolderCard/{FolderCardLink.js => styled.js} (100%) diff --git a/packages/core/upload/admin/src/components/FolderCard/FolderCard.js b/packages/core/upload/admin/src/components/FolderCard/FolderCard/FolderCard.js similarity index 93% rename from packages/core/upload/admin/src/components/FolderCard/FolderCard.js rename to packages/core/upload/admin/src/components/FolderCard/FolderCard/FolderCard.js index a297ffa2ba..462412cd6d 100644 --- a/packages/core/upload/admin/src/components/FolderCard/FolderCard.js +++ b/packages/core/upload/admin/src/components/FolderCard/FolderCard/FolderCard.js @@ -7,8 +7,8 @@ import { Box } from '@strapi/design-system/Box'; import { Stack } from '@strapi/design-system/Stack'; import Folder from '@strapi/icons/Folder'; -import { FolderCardContext } from './FolderCardContext'; -import useId from './utils/useId'; +import { FolderCardContext } from '../contexts/FolderCard'; +import useId from '../hooks/useId'; const FauxClickWrapper = styled.button` height: 100%; @@ -31,7 +31,7 @@ const StyledFolder = styled(Folder)` `; export const FolderCard = ({ children, id, startAction, ariaLabel, onDoubleClick, ...props }) => { - const generatedId = useId(id); + const generatedId = useId('folder', id); return ( diff --git a/packages/core/upload/admin/src/components/FolderCard/FolderCard/index.js b/packages/core/upload/admin/src/components/FolderCard/FolderCard/index.js new file mode 100644 index 0000000000..1aad1f19f4 --- /dev/null +++ b/packages/core/upload/admin/src/components/FolderCard/FolderCard/index.js @@ -0,0 +1 @@ +export * from './FolderCard'; diff --git a/packages/core/upload/admin/src/components/FolderCard/FolderCardBody.js b/packages/core/upload/admin/src/components/FolderCard/FolderCardBody/FolderCardBody.js similarity index 88% rename from packages/core/upload/admin/src/components/FolderCard/FolderCardBody.js rename to packages/core/upload/admin/src/components/FolderCard/FolderCardBody/FolderCardBody.js index bd7ecb5cb5..41a9d1d3da 100644 --- a/packages/core/upload/admin/src/components/FolderCard/FolderCardBody.js +++ b/packages/core/upload/admin/src/components/FolderCard/FolderCardBody/FolderCardBody.js @@ -3,7 +3,7 @@ import styled from 'styled-components'; import { Flex } from '@strapi/design-system/Flex'; -import { useFolderCard } from './FolderCardContext'; +import { useFolderCard } from '../contexts/FolderCard'; const StyledBox = styled(Flex)` user-select: none; diff --git a/packages/core/upload/admin/src/components/FolderCard/FolderCardBody/index.js b/packages/core/upload/admin/src/components/FolderCard/FolderCardBody/index.js new file mode 100644 index 0000000000..0368e72b9c --- /dev/null +++ b/packages/core/upload/admin/src/components/FolderCard/FolderCardBody/index.js @@ -0,0 +1 @@ +export * from './FolderCardBody'; diff --git a/packages/core/upload/admin/src/components/FolderCard/FolderCardCheckbox.js b/packages/core/upload/admin/src/components/FolderCard/FolderCardCheckbox/FolderCardCheckbox.js similarity index 86% rename from packages/core/upload/admin/src/components/FolderCard/FolderCardCheckbox.js rename to packages/core/upload/admin/src/components/FolderCard/FolderCardCheckbox/FolderCardCheckbox.js index ced28a17cc..8e0102f5da 100644 --- a/packages/core/upload/admin/src/components/FolderCard/FolderCardCheckbox.js +++ b/packages/core/upload/admin/src/components/FolderCard/FolderCardCheckbox/FolderCardCheckbox.js @@ -1,7 +1,7 @@ import React from 'react'; import { Box } from '@strapi/design-system/Box'; import { BaseCheckbox } from '@strapi/design-system/BaseCheckbox'; -import { useFolderCard } from './FolderCardContext'; +import { useFolderCard } from '../contexts/FolderCard'; export const FolderCardCheckbox = props => { const { id } = useFolderCard(); diff --git a/packages/core/upload/admin/src/components/FolderCard/FolderCardCheckbox/index.js b/packages/core/upload/admin/src/components/FolderCard/FolderCardCheckbox/index.js new file mode 100644 index 0000000000..90201eab84 --- /dev/null +++ b/packages/core/upload/admin/src/components/FolderCard/FolderCardCheckbox/index.js @@ -0,0 +1 @@ +export * from './FolderCardCheckbox'; diff --git a/packages/core/upload/admin/src/components/FolderCard/FolderCardContext.js b/packages/core/upload/admin/src/components/FolderCard/contexts/FolderCard.js similarity index 71% rename from packages/core/upload/admin/src/components/FolderCard/FolderCardContext.js rename to packages/core/upload/admin/src/components/FolderCard/contexts/FolderCard.js index 985ae836d9..27aaa7dc0b 100644 --- a/packages/core/upload/admin/src/components/FolderCard/FolderCardContext.js +++ b/packages/core/upload/admin/src/components/FolderCard/contexts/FolderCard.js @@ -1,6 +1,6 @@ import { createContext, useContext } from 'react'; -export const FolderCardContext = createContext(); +export const FolderCardContext = createContext({}); export function useFolderCard() { return useContext(FolderCardContext); diff --git a/packages/core/upload/admin/src/components/FolderCard/utils/tests/useId.test.js b/packages/core/upload/admin/src/components/FolderCard/hooks/tests/useId.test.js similarity index 100% rename from packages/core/upload/admin/src/components/FolderCard/utils/tests/useId.test.js rename to packages/core/upload/admin/src/components/FolderCard/hooks/tests/useId.test.js diff --git a/packages/core/upload/admin/src/components/FolderCard/utils/useId.js b/packages/core/upload/admin/src/components/FolderCard/hooks/useId.js similarity index 55% rename from packages/core/upload/admin/src/components/FolderCard/utils/useId.js rename to packages/core/upload/admin/src/components/FolderCard/hooks/useId.js index 91b8b43377..aeef81cfb7 100644 --- a/packages/core/upload/admin/src/components/FolderCard/utils/useId.js +++ b/packages/core/upload/admin/src/components/FolderCard/hooks/useId.js @@ -4,8 +4,8 @@ let id = 0; const genId = () => ++id; -const useId = (prefix, initialId) => { - const idRef = useRef(initialId || `${prefix}-${genId()}`); +const useId = initialId => { + const idRef = useRef(`${initialId}-${genId()}`); return idRef.current; }; diff --git a/packages/core/upload/admin/src/components/FolderCard/index.js b/packages/core/upload/admin/src/components/FolderCard/index.js index 4da01d2615..0d973c3898 100644 --- a/packages/core/upload/admin/src/components/FolderCard/index.js +++ b/packages/core/upload/admin/src/components/FolderCard/index.js @@ -1,4 +1,5 @@ export { FolderCard } from './FolderCard'; export { FolderCardBody } from './FolderCardBody'; export { FolderCardCheckbox } from './FolderCardCheckbox'; -export { FolderCardLink } from './FolderCardLink'; + +export { FolderCardLink } from './styled'; diff --git a/packages/core/upload/admin/src/components/FolderCard/FolderCardLink.js b/packages/core/upload/admin/src/components/FolderCard/styled.js similarity index 100% rename from packages/core/upload/admin/src/components/FolderCard/FolderCardLink.js rename to packages/core/upload/admin/src/components/FolderCard/styled.js diff --git a/packages/core/upload/admin/src/components/FolderCard/tests/FolderCard.test.js b/packages/core/upload/admin/src/components/FolderCard/tests/FolderCard.test.js index a46955a338..8fcf24e54e 100644 --- a/packages/core/upload/admin/src/components/FolderCard/tests/FolderCard.test.js +++ b/packages/core/upload/admin/src/components/FolderCard/tests/FolderCard.test.js @@ -9,7 +9,7 @@ import { FolderCard } from '../FolderCard'; import { FolderCardBody } from '../FolderCardBody'; import { FolderCardCheckbox } from '../FolderCardCheckbox'; -const ID_FIXTURE = 'folder-1'; +const ID_FIXTURE = 'folder'; // eslint-disable-next-line react/prop-types const ComponentFixture = props => { @@ -18,7 +18,6 @@ const ComponentFixture = props => { } onDoubleClick={() => {}} {...props} diff --git a/packages/core/upload/admin/src/components/FolderCard/tests/__snapshots__/FolderCard.test.js.snap b/packages/core/upload/admin/src/components/FolderCard/tests/__snapshots__/FolderCard.test.js.snap index 33208d3da0..f8c8111206 100644 --- a/packages/core/upload/admin/src/components/FolderCard/tests/__snapshots__/FolderCard.test.js.snap +++ b/packages/core/upload/admin/src/components/FolderCard/tests/__snapshots__/FolderCard.test.js.snap @@ -194,7 +194,6 @@ exports[`FolderCard has all required ids set when rendering a start action 1`] =