From 87ec8aac1b0f628bbd46cea96f6319cac2245671 Mon Sep 17 00:00:00 2001 From: Jamie Howard Date: Tue, 11 Jul 2023 17:02:26 +0100 Subject: [PATCH 1/6] fix(ee): display assignee in list view using useEnterprise pattern --- .../ListView/components/TableRows/index.js | 49 ++++++---- .../content-manager/pages/ListView/index.js | 14 +-- .../ReviewWorkflowsAssigneeEE.js | 33 +++++++ .../ReviewWorkflowsColumn/constants.js | 57 +++++++---- .../ReviewWorkflowsColumn/getTableColumns.js | 95 ------------------- .../ListView/ReviewWorkflowsColumn/index.js | 1 + 6 files changed, 112 insertions(+), 137 deletions(-) create mode 100644 packages/core/admin/ee/admin/content-manager/pages/ListView/ReviewWorkflowsColumn/ReviewWorkflowsAssigneeEE.js delete mode 100644 packages/core/admin/ee/admin/content-manager/pages/ListView/ReviewWorkflowsColumn/getTableColumns.js diff --git a/packages/core/admin/admin/src/content-manager/pages/ListView/components/TableRows/index.js b/packages/core/admin/admin/src/content-manager/pages/ListView/components/TableRows/index.js index 6408ad7c42..8ebadb33d7 100644 --- a/packages/core/admin/admin/src/content-manager/pages/ListView/components/TableRows/index.js +++ b/packages/core/admin/admin/src/content-manager/pages/ListView/components/TableRows/index.js @@ -55,11 +55,7 @@ export const TableRows = ({ const ReviewWorkflowsStage = useEnterprise( REVIEW_WORKFLOW_COLUMNS_CE, async () => - ( - await import( - '../../../../../../../ee/admin/content-manager/pages/ListView/ReviewWorkflowsColumn' - ) - ).ReviewWorkflowsStageEE, + import('../../../../../../../ee/admin/content-manager/pages/ListView/ReviewWorkflowsColumn'), { enabled: hasReviewWorkflows, } @@ -178,19 +174,36 @@ export const TableRows = ({ ); } - if (hasReviewWorkflows && name === 'strapi_reviewWorkflows_stage') { - return ( - - {data.strapi_reviewWorkflows_stage ? ( - - ) : ( - - - )} - - ); + if (hasReviewWorkflows) { + switch (name) { + case 'strapi_reviewWorkflows_stage': + return ( + + {data.strapi_reviewWorkflows_stage ? ( + + ) : ( + - + )} + + ); + case 'strapi_assignee': + return ( + + {data.strapi_assignee ? ( + + ) : ( + - + )} + + ); + default: + } } return ( diff --git a/packages/core/admin/admin/src/content-manager/pages/ListView/index.js b/packages/core/admin/admin/src/content-manager/pages/ListView/index.js index 1130a618e9..98a306f750 100644 --- a/packages/core/admin/admin/src/content-manager/pages/ListView/index.js +++ b/packages/core/admin/admin/src/content-manager/pages/ListView/index.js @@ -422,13 +422,15 @@ function ListView({ if (reviewWorkflowColumns) { // Make sure the column header label is translated - if (typeof reviewWorkflowColumns.metadatas.label !== 'string') { - reviewWorkflowColumns.metadatas.label = formatMessage( - reviewWorkflowColumns.metadatas.label - ); - } + reviewWorkflowColumns.map((column) => { + if (typeof column.metadatas.label !== 'string') { + column.metadatas.label = formatMessage(column.metadatas.label); + } - formattedHeaders.push(reviewWorkflowColumns); + return column; + }); + + formattedHeaders.push(...reviewWorkflowColumns); } return formattedHeaders; diff --git a/packages/core/admin/ee/admin/content-manager/pages/ListView/ReviewWorkflowsColumn/ReviewWorkflowsAssigneeEE.js b/packages/core/admin/ee/admin/content-manager/pages/ListView/ReviewWorkflowsColumn/ReviewWorkflowsAssigneeEE.js new file mode 100644 index 0000000000..f13fa42513 --- /dev/null +++ b/packages/core/admin/ee/admin/content-manager/pages/ListView/ReviewWorkflowsColumn/ReviewWorkflowsAssigneeEE.js @@ -0,0 +1,33 @@ +import React from 'react'; + +import { Typography } from '@strapi/design-system'; +import PropTypes from 'prop-types'; +import { useIntl } from 'react-intl'; + +import getTrad from '../../../../../../admin/src/content-manager/utils/getTrad'; + +export function ReviewWorkflowsAssigneeEE({ firstname, lastname }) { + const { formatMessage } = useIntl(); + + if (!firstname && !lastname) { + return -; + } + + return ( + + {formatMessage( + { + id: getTrad(`containers.ListPage.reviewWorkflows.assignee`), + defaultMessage: '{firstname} {lastname}', + }, + { firstname, lastname } + )} + + ); +} + +// TODO are both required? +ReviewWorkflowsAssigneeEE.propTypes = { + firstname: PropTypes.string.isRequired, + lastname: PropTypes.string.isRequired, +}; diff --git a/packages/core/admin/ee/admin/content-manager/pages/ListView/ReviewWorkflowsColumn/constants.js b/packages/core/admin/ee/admin/content-manager/pages/ListView/ReviewWorkflowsColumn/constants.js index 1ec56488b0..325cedfe98 100644 --- a/packages/core/admin/ee/admin/content-manager/pages/ListView/ReviewWorkflowsColumn/constants.js +++ b/packages/core/admin/ee/admin/content-manager/pages/ListView/ReviewWorkflowsColumn/constants.js @@ -1,24 +1,45 @@ import getTrad from '../../../../../../admin/src/content-manager/utils/getTrad'; +import { + ASSIGNEE_ATTRIBUTE_NAME, + STAGE_ATTRIBUTE_NAME, +} from '../../EditView/InformationBox/constants'; -export const REVIEW_WORKFLOW_COLUMNS_EE = { - key: '__strapi_reviewWorkflows_stage_temp_key__', - name: 'strapi_reviewWorkflows_stage', - fieldSchema: { - type: 'relation', - }, - metadatas: { - // formatMessage() will be applied when the column is rendered - label: { - id: getTrad(`containers.ListPage.table-headers.reviewWorkflows.stage`), - defaultMessage: 'Review stage', +export const REVIEW_WORKFLOW_COLUMNS_EE = [ + { + key: `__${STAGE_ATTRIBUTE_NAME}_temp_key__`, + name: STAGE_ATTRIBUTE_NAME, + fieldSchema: { + type: 'relation', }, - searchable: false, - sortable: true, - mainField: { - name: 'name', - schema: { - type: 'string', + metadatas: { + // formatMessage() will be applied when the column is rendered + label: { + id: getTrad(`containers.ListPage.table-headers.reviewWorkflows.stage`), + defaultMessage: 'Review stage', + }, + searchable: false, + sortable: true, + mainField: { + name: 'name', + schema: { + type: 'string', + }, }, }, }, -}; + { + key: `__${ASSIGNEE_ATTRIBUTE_NAME}_temp_key__`, + name: ASSIGNEE_ATTRIBUTE_NAME, + fieldSchema: { + type: 'relation', + }, + metadatas: { + label: { + id: getTrad(`containers.ListPage.table-headers.reviewWorkflows.assignee`), + defaultMessage: 'Assignee', + }, + searchable: false, + sortable: false, + }, + }, +]; diff --git a/packages/core/admin/ee/admin/content-manager/pages/ListView/ReviewWorkflowsColumn/getTableColumns.js b/packages/core/admin/ee/admin/content-manager/pages/ListView/ReviewWorkflowsColumn/getTableColumns.js deleted file mode 100644 index 18746ab3cd..0000000000 --- a/packages/core/admin/ee/admin/content-manager/pages/ListView/ReviewWorkflowsColumn/getTableColumns.js +++ /dev/null @@ -1,95 +0,0 @@ -import React from 'react'; - -import { Typography } from '@strapi/design-system'; -import { useIntl } from 'react-intl'; - -import getTrad from '../../../../../../admin/src/content-manager/utils/getTrad'; -import { STAGE_COLOR_DEFAULT } from '../../../../pages/SettingsPage/pages/ReviewWorkflows/constants'; - -import { ReviewWorkflowsStageEE } from '.'; - -export default (layout) => { - const { formatMessage } = useIntl(); - - // TODO: As soon as the feature was enabled in EE mode, the BE currently does not have a way to send - // `false` once a user is in CE mode again. We shouldn't have to perform the window.strapi.isEE check here - // and it is meant to be in interim solution until we find a better one. - const hasReviewWorkflows = - (window.strapi.features.isEnabled(window.strapi.features.REVIEW_WORKFLOWS) && - layout.contentType.options?.reviewWorkflows) ?? - false; - - if (!hasReviewWorkflows) { - return []; - } - - return [ - { - key: '__strapi_reviewWorkflows_stage_temp_key__', - name: 'strapi_reviewWorkflows_stage', - fieldSchema: { - type: 'relation', - }, - metadatas: { - label: formatMessage({ - id: getTrad(`containers.ListPage.table-headers.reviewWorkflows.stage`), - defaultMessage: 'Review stage', - }), - searchable: false, - sortable: true, - mainField: { - name: 'name', - schema: { - type: 'string', - }, - }, - }, - cellFormatter({ strapi_reviewWorkflows_stage }) { - // if entities are created e.g. through lifecycle methods - // they may not have a stage assigned - if (!strapi_reviewWorkflows_stage) { - return -; - } - - const { color, name } = strapi_reviewWorkflows_stage; - - return ; - }, - }, - - { - key: '__strapi_reviewWorkflows_assignee_temp_key__', - name: 'strapi_reviewWorkflows_assignee', - fieldSchema: { - type: 'relation', - }, - metadatas: { - label: formatMessage({ - id: getTrad(`containers.ListPage.table-headers.reviewWorkflows.assignee`), - defaultMessage: 'Assignee', - }), - searchable: false, - sortable: false, - }, - cellFormatter({ strapi_assignee }) { - if (!strapi_assignee) { - return -; - } - - const { firstname, lastname } = strapi_assignee; - - return ( - - {formatMessage( - { - id: getTrad(`containers.ListPage.reviewWorkflows.assignee`), - defaultMessage: '{firstname} {lastname}', - }, - { firstname, lastname } - )} - - ); - }, - }, - ]; -}; diff --git a/packages/core/admin/ee/admin/content-manager/pages/ListView/ReviewWorkflowsColumn/index.js b/packages/core/admin/ee/admin/content-manager/pages/ListView/ReviewWorkflowsColumn/index.js index 354bfb6848..57a8fa4cf3 100644 --- a/packages/core/admin/ee/admin/content-manager/pages/ListView/ReviewWorkflowsColumn/index.js +++ b/packages/core/admin/ee/admin/content-manager/pages/ListView/ReviewWorkflowsColumn/index.js @@ -1 +1,2 @@ export * from './ReviewWorkflowsStageEE'; +export * from './ReviewWorkflowsAssigneeEE'; From 606b29a5bc2ff00c4e022233853862e7b7509c32 Mon Sep 17 00:00:00 2001 From: Jamie Howard Date: Wed, 12 Jul 2023 12:09:55 +0100 Subject: [PATCH 2/6] test(ee): ReviewWorkflowsAssignee --- .../tests/ReviewWorkflowsAssignee.test.js | 25 +++++++++++++++++++ 1 file changed, 25 insertions(+) create mode 100644 packages/core/admin/ee/admin/content-manager/pages/ListView/ReviewWorkflowsColumn/tests/ReviewWorkflowsAssignee.test.js diff --git a/packages/core/admin/ee/admin/content-manager/pages/ListView/ReviewWorkflowsColumn/tests/ReviewWorkflowsAssignee.test.js b/packages/core/admin/ee/admin/content-manager/pages/ListView/ReviewWorkflowsColumn/tests/ReviewWorkflowsAssignee.test.js new file mode 100644 index 0000000000..a16122e421 --- /dev/null +++ b/packages/core/admin/ee/admin/content-manager/pages/ListView/ReviewWorkflowsColumn/tests/ReviewWorkflowsAssignee.test.js @@ -0,0 +1,25 @@ +import React from 'react'; + +import { lightTheme, ThemeProvider } from '@strapi/design-system'; +import { render } from '@testing-library/react'; +import { IntlProvider } from 'react-intl'; + +import { ReviewWorkflowsAssigneeEE } from '..'; + +const ComponentFixture = (props) => ( + + + + + +); + +const setup = (props) => render(); + +describe('DynamicTable | ReviewWorkflowsAssignee', () => { + test('render assignee name', () => { + const { getByText } = setup({ firstname: 'Kai', lastname: 'Doe' }); + + expect(getByText('Kai Doe')).toBeInTheDocument(); + }); +}); From eeb5bbd76987242549300fdb9512e8bc93caf507 Mon Sep 17 00:00:00 2001 From: Jamie Howard Date: Wed, 12 Jul 2023 12:33:48 +0100 Subject: [PATCH 3/6] fix: PR feedback --- .../ListView/components/TableRows/index.js | 68 ++++++++++--------- .../content-manager/pages/ListView/index.js | 2 +- 2 files changed, 37 insertions(+), 33 deletions(-) diff --git a/packages/core/admin/admin/src/content-manager/pages/ListView/components/TableRows/index.js b/packages/core/admin/admin/src/content-manager/pages/ListView/components/TableRows/index.js index 8ebadb33d7..c3bb9f212a 100644 --- a/packages/core/admin/admin/src/content-manager/pages/ListView/components/TableRows/index.js +++ b/packages/core/admin/admin/src/content-manager/pages/ListView/components/TableRows/index.js @@ -52,10 +52,15 @@ export const TableRows = ({ const pluginsQueryParams = usePluginsQueryParams(); const [{ query }] = useQueryParams(); const { formatAPIError } = useAPIErrorHandler(getTrad); - const ReviewWorkflowsStage = useEnterprise( + const ReviewWorkflowsColumns = useEnterprise( REVIEW_WORKFLOW_COLUMNS_CE, - async () => - import('../../../../../../../ee/admin/content-manager/pages/ListView/ReviewWorkflowsColumn'), + async () => { + const { ReviewWorkflowsStageEE, ReviewWorkflowsAssigneeEE } = await import( + '../../../../../../../ee/admin/content-manager/pages/ListView/ReviewWorkflowsColumn' + ); + + return { ReviewWorkflowsStageEE, ReviewWorkflowsAssigneeEE }; + }, { enabled: hasReviewWorkflows, } @@ -104,7 +109,7 @@ export const TableRows = ({ }; // block rendering until the review stage component is fully loaded in EE - if (!ReviewWorkflowsStage) { + if (!ReviewWorkflowsColumns) { return null; } @@ -175,34 +180,33 @@ export const TableRows = ({ } if (hasReviewWorkflows) { - switch (name) { - case 'strapi_reviewWorkflows_stage': - return ( - - {data.strapi_reviewWorkflows_stage ? ( - - ) : ( - - - )} - - ); - case 'strapi_assignee': - return ( - - {data.strapi_assignee ? ( - - ) : ( - - - )} - - ); - default: + if (name === 'strapi_reviewWorkflows_stage') { + return ( + + {data.strapi_reviewWorkflows_stage ? ( + + ) : ( + - + )} + + ); + } + if (name === 'strapi_assignee') { + return ( + + {data.strapi_assignee ? ( + + ) : ( + - + )} + + ); } } diff --git a/packages/core/admin/admin/src/content-manager/pages/ListView/index.js b/packages/core/admin/admin/src/content-manager/pages/ListView/index.js index 98a306f750..b15430179d 100644 --- a/packages/core/admin/admin/src/content-manager/pages/ListView/index.js +++ b/packages/core/admin/admin/src/content-manager/pages/ListView/index.js @@ -422,7 +422,7 @@ function ListView({ if (reviewWorkflowColumns) { // Make sure the column header label is translated - reviewWorkflowColumns.map((column) => { + (reviewWorkflowColumns ?? []).map((column) => { if (typeof column.metadatas.label !== 'string') { column.metadatas.label = formatMessage(column.metadatas.label); } From 99011ef33a1ebed3ae963992e271f5eefa4fd8c4 Mon Sep 17 00:00:00 2001 From: Jamie Howard Date: Wed, 12 Jul 2023 12:53:32 +0100 Subject: [PATCH 4/6] fix: PR feedback --- .../ListView/components/TableRows/index.js | 3 +- .../ReviewWorkflowsAssigneeEE.js | 32 +++++++++++++++---- .../tests/ReviewWorkflowsAssignee.test.js | 6 ++++ 3 files changed, 33 insertions(+), 8 deletions(-) diff --git a/packages/core/admin/admin/src/content-manager/pages/ListView/components/TableRows/index.js b/packages/core/admin/admin/src/content-manager/pages/ListView/components/TableRows/index.js index c3bb9f212a..a9c135cd3c 100644 --- a/packages/core/admin/admin/src/content-manager/pages/ListView/components/TableRows/index.js +++ b/packages/core/admin/admin/src/content-manager/pages/ListView/components/TableRows/index.js @@ -200,7 +200,8 @@ export const TableRows = ({ {data.strapi_assignee ? ( ) : ( - diff --git a/packages/core/admin/ee/admin/content-manager/pages/ListView/ReviewWorkflowsColumn/ReviewWorkflowsAssigneeEE.js b/packages/core/admin/ee/admin/content-manager/pages/ListView/ReviewWorkflowsColumn/ReviewWorkflowsAssigneeEE.js index f13fa42513..4516fcff78 100644 --- a/packages/core/admin/ee/admin/content-manager/pages/ListView/ReviewWorkflowsColumn/ReviewWorkflowsAssigneeEE.js +++ b/packages/core/admin/ee/admin/content-manager/pages/ListView/ReviewWorkflowsColumn/ReviewWorkflowsAssigneeEE.js @@ -6,11 +6,23 @@ import { useIntl } from 'react-intl'; import getTrad from '../../../../../../admin/src/content-manager/utils/getTrad'; -export function ReviewWorkflowsAssigneeEE({ firstname, lastname }) { +export function ReviewWorkflowsAssigneeEE({ firstname, lastname, displayname }) { const { formatMessage } = useIntl(); - if (!firstname && !lastname) { - return -; + // TODO align with changes from this PR, using the getDisplayName util + // https://github.com/strapi/strapi/pull/17043/ + if (displayname.length > 0) { + return ( + + {formatMessage( + { + id: getTrad(`containers.ListPage.reviewWorkflows.assignee`), + defaultMessage: '{displayname}', + }, + { displayname } + )} + + ); } return ( @@ -26,8 +38,14 @@ export function ReviewWorkflowsAssigneeEE({ firstname, lastname }) { ); } -// TODO are both required? -ReviewWorkflowsAssigneeEE.propTypes = { - firstname: PropTypes.string.isRequired, - lastname: PropTypes.string.isRequired, +ReviewWorkflowsAssigneeEE.defaultProps = { + firstname: '', + lastname: '', + displayname: '', +}; + +ReviewWorkflowsAssigneeEE.propTypes = { + firstname: PropTypes.string, + lastname: PropTypes.string, + displayname: PropTypes.string, }; diff --git a/packages/core/admin/ee/admin/content-manager/pages/ListView/ReviewWorkflowsColumn/tests/ReviewWorkflowsAssignee.test.js b/packages/core/admin/ee/admin/content-manager/pages/ListView/ReviewWorkflowsColumn/tests/ReviewWorkflowsAssignee.test.js index a16122e421..1a198d0adb 100644 --- a/packages/core/admin/ee/admin/content-manager/pages/ListView/ReviewWorkflowsColumn/tests/ReviewWorkflowsAssignee.test.js +++ b/packages/core/admin/ee/admin/content-manager/pages/ListView/ReviewWorkflowsColumn/tests/ReviewWorkflowsAssignee.test.js @@ -17,6 +17,12 @@ const ComponentFixture = (props) => ( const setup = (props) => render(); describe('DynamicTable | ReviewWorkflowsAssignee', () => { + test('will use displayName over first and last name', () => { + const displayname = 'Display Name'; + const { getByText } = setup({ displayname }); + + expect(getByText(displayname)).toBeInTheDocument(); + }); test('render assignee name', () => { const { getByText } = setup({ firstname: 'Kai', lastname: 'Doe' }); From 25014312a65634c4509038ae3fa6cd0862dfb8cc Mon Sep 17 00:00:00 2001 From: Jamie Howard Date: Thu, 13 Jul 2023 09:25:31 +0100 Subject: [PATCH 5/6] fix: pass in correct display name --- .../pages/ListView/components/TableRows/index.js | 4 ++-- .../admin/admin/src/content-manager/pages/ListView/index.js | 2 +- .../ReviewWorkflowsColumn/ReviewWorkflowsAssigneeEE.js | 2 +- .../core/admin/ee/server/services/__tests__/assignees.test.js | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/core/admin/admin/src/content-manager/pages/ListView/components/TableRows/index.js b/packages/core/admin/admin/src/content-manager/pages/ListView/components/TableRows/index.js index a9c135cd3c..f4b79a09aa 100644 --- a/packages/core/admin/admin/src/content-manager/pages/ListView/components/TableRows/index.js +++ b/packages/core/admin/admin/src/content-manager/pages/ListView/components/TableRows/index.js @@ -200,8 +200,8 @@ export const TableRows = ({ {data.strapi_assignee ? ( ) : ( - diff --git a/packages/core/admin/admin/src/content-manager/pages/ListView/index.js b/packages/core/admin/admin/src/content-manager/pages/ListView/index.js index b15430179d..98a306f750 100644 --- a/packages/core/admin/admin/src/content-manager/pages/ListView/index.js +++ b/packages/core/admin/admin/src/content-manager/pages/ListView/index.js @@ -422,7 +422,7 @@ function ListView({ if (reviewWorkflowColumns) { // Make sure the column header label is translated - (reviewWorkflowColumns ?? []).map((column) => { + reviewWorkflowColumns.map((column) => { if (typeof column.metadatas.label !== 'string') { column.metadatas.label = formatMessage(column.metadatas.label); } diff --git a/packages/core/admin/ee/admin/content-manager/pages/ListView/ReviewWorkflowsColumn/ReviewWorkflowsAssigneeEE.js b/packages/core/admin/ee/admin/content-manager/pages/ListView/ReviewWorkflowsColumn/ReviewWorkflowsAssigneeEE.js index 4516fcff78..6422c0c211 100644 --- a/packages/core/admin/ee/admin/content-manager/pages/ListView/ReviewWorkflowsColumn/ReviewWorkflowsAssigneeEE.js +++ b/packages/core/admin/ee/admin/content-manager/pages/ListView/ReviewWorkflowsColumn/ReviewWorkflowsAssigneeEE.js @@ -11,7 +11,7 @@ export function ReviewWorkflowsAssigneeEE({ firstname, lastname, displayname }) // TODO align with changes from this PR, using the getDisplayName util // https://github.com/strapi/strapi/pull/17043/ - if (displayname.length > 0) { + if (displayname) { return ( {formatMessage( diff --git a/packages/core/admin/ee/server/services/__tests__/assignees.test.js b/packages/core/admin/ee/server/services/__tests__/assignees.test.js index c854024dc8..7e03e19e3a 100644 --- a/packages/core/admin/ee/server/services/__tests__/assignees.test.js +++ b/packages/core/admin/ee/server/services/__tests__/assignees.test.js @@ -67,7 +67,7 @@ describe('Review workflows - Stages service', () => { toId ); expect(entityServiceMock.update).toBeCalledWith(uid, id, { - data: { strapi_assignee: toId }, + data: { [ENTITY_ASSIGNEE_ATTRIBUTE]: toId }, fields: [], populate: [ENTITY_ASSIGNEE_ATTRIBUTE], }); From 2cd691abae1b22996a3e8c6fec7f24fa921d38df Mon Sep 17 00:00:00 2001 From: Jamie Howard Date: Thu, 13 Jul 2023 11:18:02 +0100 Subject: [PATCH 6/6] chore: cleanup --- .../ReviewWorkflowsColumn/tests/ReviewWorkflowsAssignee.test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/core/admin/ee/admin/content-manager/pages/ListView/ReviewWorkflowsColumn/tests/ReviewWorkflowsAssignee.test.js b/packages/core/admin/ee/admin/content-manager/pages/ListView/ReviewWorkflowsColumn/tests/ReviewWorkflowsAssignee.test.js index 1a198d0adb..4e3d45a171 100644 --- a/packages/core/admin/ee/admin/content-manager/pages/ListView/ReviewWorkflowsColumn/tests/ReviewWorkflowsAssignee.test.js +++ b/packages/core/admin/ee/admin/content-manager/pages/ListView/ReviewWorkflowsColumn/tests/ReviewWorkflowsAssignee.test.js @@ -17,7 +17,7 @@ const ComponentFixture = (props) => ( const setup = (props) => render(); describe('DynamicTable | ReviewWorkflowsAssignee', () => { - test('will use displayName over first and last name', () => { + test('will use displayname over first and last name', () => { const displayname = 'Display Name'; const { getByText } = setup({ displayname });