add transaction for folder update

packages/core/database/lib/index.js

@@ -58,6 +58,10 @@ class Database {
     return schema ? trx.schema.withSchema(schema) : trx.schema;
   }
 
+  transaction() {
+    return this.connection.transaction();
+  }
+
   queryBuilder(uid) {
     return this.entityManager.createQueryBuilder(uid);
   }

packages/core/database/lib/query/query-builder.js

@@ -19,6 +19,8 @@ const createQueryBuilder = (uid, db) => {
     populate: null,
     limit: null,
     offset: null,
+    transaction: null,
+    forUpdate: false,
     orderBy: [],
     groupBy: [],
   };
@@ -115,6 +117,16 @@ const createQueryBuilder = (uid, db) => {
       return this;
     },
 
+    transacting(transaction) {
+      state.transaction = transaction;
+      return this;
+    },
+
+    forUpdate() {
+      state.forUpdate = true;
+      return this;
+    },
+
     init(params = {}) {
       const { _q, filters, where, select, limit, offset, orderBy, groupBy, populate } = params;
 
@@ -308,6 +320,14 @@ const createQueryBuilder = (uid, db) => {
         }
       }
 
+      if (state.transaction) {
+        qb.transacting(state.transaction);
+      }
+
+      if (state.forUpdate) {
+        qb.forUpdate();
+      }
+
       if (state.limit) {
         qb.limit(state.limit);
       }

packages/core/upload/server/services/folder.js

@@ -74,53 +74,101 @@ const deleteByIds = async (ids = []) => {
  * @returns {Promise<boolean>}
  */
 const update = async (id, { name, parent }, { user }) => {
-  const existingFolder = await strapi.entityService.findOne(FOLDER_MODEL_UID, id);
+  // only name is updated
+  if (isUndefined(parent)) {
+    const existingFolder = await strapi.entityService.findOne(FOLDER_MODEL_UID, id);
 
-  if (!existingFolder) {
+    if (!existingFolder) {
-    return undefined;
+      return undefined;
-  }
+    }
 
-  if (!isUndefined(parent)) {
+    const newFolder = setCreatorFields({ user, isEdition: true })({ name, parent });
-    const folderPathColumnName = strapi.db.metadata.get(FILE_MODEL_UID).attributes.folderPath
-      .columnName;
-    const pathColumnName = strapi.db.metadata.get(FOLDER_MODEL_UID).attributes.path.columnName;
 
-    // Todo wrap into a transaction
+    if (isUndefined(parent)) {
-    const destinationFolder =
+      const folder = await strapi.entityService.update(FOLDER_MODEL_UID, id, { data: newFolder });
-      parent === null ? '/' : (await strapi.entityService.findOne(FOLDER_MODEL_UID, parent)).path;
+      return folder;
+    }
+    // location is updated => using transaction
+  } else {
+    const trx = await strapi.db.transaction();
+    try {
+      // fetch existing folder
+      const existingFolder = await strapi.db
+        .queryBuilder(FOLDER_MODEL_UID)
+        .select(['uid', 'path'])
+        .where({ id })
+        .transacting(trx)
+        .forUpdate()
+        .first()
+        .execute();
 
-    const folderTable = strapi.getModel(FOLDER_MODEL_UID).collectionName;
+      // update parent folder
-    const fileTable = strapi.getModel(FILE_MODEL_UID).collectionName;
+      const joinTable = strapi.db.metadata.get(FOLDER_MODEL_UID).attributes.parent.joinTable;
+      await strapi.db
+        .queryBuilder(joinTable.name)
+        .transacting(trx)
+        .update({ [joinTable.inverseJoinColumn.name]: parent })
+        .where({ [joinTable.joinColumn.name]: id })
+        .execute();
 
-    await strapi.db
+      // fetch destinationFolder path
-      .connection(folderTable)
+      let destinationFolderPath = '/';
-      .where(pathColumnName, 'like', `${existingFolder.path}%`)
+      if (parent !== null) {
-      .update(
+        const destinationFolder = await strapi.db
-        pathColumnName,
+          .queryBuilder(FOLDER_MODEL_UID)
-        strapi.db.connection.raw('REPLACE(??, ?, ?)', [
+          .select('path')
+          .where({ id: parent })
+          .transacting(trx)
+          .first()
+          .execute();
+        destinationFolderPath = destinationFolder.path;
+      }
+
+      const folderTable = strapi.getModel(FOLDER_MODEL_UID).collectionName;
+      const fileTable = strapi.getModel(FILE_MODEL_UID).collectionName;
+      const folderPathColumnName = strapi.db.metadata.get(FILE_MODEL_UID).attributes.folderPath
+        .columnName;
+      const pathColumnName = strapi.db.metadata.get(FOLDER_MODEL_UID).attributes.path.columnName;
+
+      // update folders below
+      await strapi.db
+        .connection(folderTable)
+        .transacting(trx)
+        .where(pathColumnName, 'like', `${existingFolder.path}%`)
+        .update(
           pathColumnName,
-          existingFolder.path,
+          strapi.db.connection.raw('REPLACE(??, ?, ?)', [
-          joinBy('/', destinationFolder, existingFolder.uid),
+            pathColumnName,
-        ])
+            existingFolder.path,
-      );
+            joinBy('/', destinationFolderPath, existingFolder.uid),
+          ])
+        );
 
-    await strapi.db
+      // update files below
-      .connection(fileTable)
+      await strapi.db
-      .where(folderPathColumnName, 'like', `${existingFolder.path}%`)
+        .connection(fileTable)
-      .update(
+        .transacting(trx)
-        folderPathColumnName,
+        .where(folderPathColumnName, 'like', `${existingFolder.path}%`)
-        strapi.db.connection.raw('REPLACE(??, ?, ?)', [
+        .update(
           folderPathColumnName,
-          existingFolder.path,
+          strapi.db.connection.raw('REPLACE(??, ?, ?)', [
-          joinBy('/', destinationFolder, existingFolder.uid),
+            folderPathColumnName,
-        ])
+            existingFolder.path,
-      );
+            joinBy('/', destinationFolderPath, existingFolder.uid),
+          ])
+        );
+
+      await trx.commit();
+    } catch (e) {
+      await trx.rollback();
+      throw e;
+    }
+
+    // update less critical information (name + updatedBy)
+    const newFolder = setCreatorFields({ user, isEdition: true })({ name });
+    const folder = await strapi.entityService.update(FOLDER_MODEL_UID, id, { data: newFolder });
+    return folder;
   }
-
-  const newFolder = setCreatorFields({ user, isEdition: true })({ name, parent });
-  const folder = await strapi.entityService.update(FOLDER_MODEL_UID, id, { data: newFolder });
-
-  return folder;
 };
 
 /**