From d7b18b9ece2534ea9ac263f15cc2009359bc4760 Mon Sep 17 00:00:00 2001 From: Gustav Hansen Date: Mon, 30 Jan 2023 17:29:52 +0100 Subject: [PATCH] Chore: Simplify selector access across the page --- .../pages/ReviewWorkflows/ReviewWorkflows.js | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/packages/core/admin/ee/admin/pages/SettingsPage/pages/ReviewWorkflows/ReviewWorkflows.js b/packages/core/admin/ee/admin/pages/SettingsPage/pages/ReviewWorkflows/ReviewWorkflows.js index ccec39ed4b..3066c29243 100644 --- a/packages/core/admin/ee/admin/pages/SettingsPage/pages/ReviewWorkflows/ReviewWorkflows.js +++ b/packages/core/admin/ee/admin/pages/SettingsPage/pages/ReviewWorkflows/ReviewWorkflows.js @@ -15,7 +15,7 @@ import { setWorkflow } from './actions'; export function ReviewWorkflowsPage() { const { formatMessage } = useIntl(); const { workflows: workflowsData } = useReviewWorkflows(); - const workflow = useSelector((state) => state?.[REDUX_NAMESPACE]); + const state = useSelector((state) => state?.[REDUX_NAMESPACE]); const dispatch = useDispatch(); useInjectReducer(REDUX_NAMESPACE, reducer); @@ -27,10 +27,12 @@ export function ReviewWorkflowsPage() { // useInjectReducer() runs on the first rendering after useSelector // which will return undefined. This helps to avoid too many optional // chaining operators down the component. - if (!workflow) { + if (!state) { return null; } + const { workflows } = state; + return ( - {workflow.workflows.state === 'loading' ? ( + {workflows.state === 'loading' ? ( {formatMessage({ id: 'Settings.review-workflows.page.isLoading', @@ -70,7 +72,7 @@ export function ReviewWorkflowsPage() { })} ) : ( - + )}