WIP- debug sentry mock

packages/strapi-plugin-sentry/package.json

@@ -8,7 +8,8 @@
     "description": "Send API errors to Sentry"
   },
   "dependencies": {
-    "@sentry/node": "5.29.0"
+    "@sentry/node": "5.29.0",
+    "polygala": "4.0.0"
   },
   "author": {
     "name": "A Strapi developer",

packages/strapi-plugin-sentry/services/__tests__/sentry.test.js

@@ -1,13 +1,27 @@
-const Sentry = require('@sentry/node');
+'use strict';
+
+jest.resetModules();
+
+jest.mock('@sentry/node', () => {
+  return {
+    init() {
+      console.log('MOCKING SENTRY INIT');
+    },
+  };
+});
+
 const sentryService = require('../sentry');
 const defaultConfig = require('../../config/settings.json');
 
-describe('Check if runs', () => {
+describe('test', () => {
   beforeEach(() => {
     global.strapi = {
       plugins: {
         sentry: {
-          config: defaultConfig,
+          config: {
+            ...defaultConfig,
+            dsn: 'fakedsn',
+          },
         },
       },
       log: {
@@ -16,54 +30,76 @@ describe('Check if runs', () => {
       },
     };
   });
-
+  it('init', async () => {
-  it('disables Sentry when no DSN is provided', () => {
     sentryService.init();
-    expect(strapi.log.info).toHaveBeenCalledWith(expect.stringMatching(/disabled/i));
-
-    const instance = sentryService.getInstance();
-    expect(instance).toBeNull();
   });
-
-  it('disables Sentry when an invalid DSN is provided', () => {
-    global.strapi.plugins.sentry.config = {
-      dsn: 'an_invalid_dsn',
-    };
-    sentryService.init();
-    expect(strapi.log.warn).toHaveBeenCalledWith(expect.stringMatching(/could not set up sentry/i));
-
-    const instance = sentryService.getInstance();
-    expect(instance).toBeNull();
-  });
-
-  it("doesn't send events before init", () => {
-    sentryService.sendError(Error());
-    expect(strapi.log.warn).toHaveBeenCalledWith(expect.stringMatching(/cannot send event/i));
-  });
-
-  it('initializes and sends errors', () => {
-    global.strapi.plugins.sentry.config = {
-      dsn: 'a_valid_dsn',
-    };
-
-    // Mock Sentry.init only for this test
-    Sentry.init = jest.fn();
-    sentryService.init();
-    expect(Sentry.init).toHaveBeenCalled();
-
-    // Saves the instance correctly
-    const instance = sentryService.getInstance();
-    expect(instance).not.toBeNull();
-
-    // Doesn't allow re-init
-    sentryService.init();
-    expect(strapi.log.warn).toHaveBeenCalledWith(expect.stringMatching(/already/i));
-
-    const error = Error('an error');
-    const configureScope = jest.fn();
-    sentryService.sendError(error, configureScope);
-    expect(configureScope).toHaveBeenCalled();
-  });
-
-  it('');
 });
+
+// const Sentry = require('@sentry/node');
+// const sentryService = require('../sentry');
+// const defaultConfig = require('../../config/settings.json');
+
+// const INVALID_DSN = 'an_invalid_dsn';
+// const VALID_DSN = 'a_valid_dsn';
+
+// describe('strapi-plugin-sentry service', () => {
+//   beforeEach(() => {
+//     global.strapi = {
+//       plugins: {
+//         sentry: {
+//           config: defaultConfig,
+//         },
+//       },
+//       log: {
+//         warn: jest.fn(),
+//         info: jest.fn(),
+//       },
+//     };
+//   });
+
+//   it('disables Sentry when no DSN is provided', () => {
+//     // Sentry.init();
+//     sentryService.init();
+//     expect(strapi.log.info).toHaveBeenCalledWith(expect.stringMatching(/disabled/i));
+
+//     const instance = sentryService.getInstance();
+//     expect(instance).toBeNull();
+//   });
+
+//   it('disables Sentry when an invalid DSN is provided', () => {
+//     global.strapi.plugins.sentry.config = {
+//       dsn: INVALID_DSN,
+//     };
+//     sentryService.init();
+//     expect(strapi.log.warn).toHaveBeenCalledWith(expect.stringMatching(/could not set up sentry/i));
+
+//     const instance = sentryService.getInstance();
+//     expect(instance).toBeNull();
+//   });
+
+//   it("doesn't send events before init", () => {
+//     sentryService.sendError(Error());
+//     expect(strapi.log.warn).toHaveBeenCalledWith(expect.stringMatching(/cannot send event/i));
+//   });
+
+//   it('initializes and sends errors', () => {
+//     global.strapi.plugins.sentry.config = {
+//       dsn: VALID_DSN,
+//     };
+
+//     sentryService.init();
+
+//     // Saves the instance correctly
+//     const instance = sentryService.getInstance();
+//     expect(instance).not.toBeNull();
+
+//     // Doesn't allow re-init
+//     sentryService.init();
+//     expect(strapi.log.warn).toHaveBeenCalledWith(expect.stringMatching(/already/i));
+
+//     const error = Error('an error');
+//     const configureScope = jest.fn();
+//     sentryService.sendError(error, configureScope);
+//     expect(configureScope).toHaveBeenCalled();
+//   });
+// });

packages/strapi-plugin-sentry/services/sentry.js

@@ -28,6 +28,7 @@ const createSentryService = () => {
       try {
         // Don't init Sentry if no DSN was provided
         if (settings.dsn) {
+          console.log('should call mock now');
           Sentry.init({
             dsn: settings.dsn,
             environment: strapi.config.environment,
@@ -36,6 +37,7 @@ const createSentryService = () => {
           instance = Sentry;
           isReady = true;
         } else {
+          console.log('no dsn');
           strapi.log.info('strapi-plugin-sentry is disabled because no Sentry DSN was provided');
         }
       } catch (error) {

yarn.lock

@@ -3230,6 +3230,11 @@
   resolved "https://registry.yarnpkg.com/@types/http-errors/-/http-errors-1.8.0.tgz#682477dbbbd07cd032731cb3b0e7eaee3d026b69"
   integrity sha512-2aoSC4UUbHDj2uCsCxcG/vRMXey/m17bC7UwitVm5hn22nI8O8Y9iDpA76Orc+DWkQ4zZrOKEshCqR/jSuXAHA==
 
+"@types/immediate@^3.2.0":
+  version "3.2.0"
+  resolved "https://registry.yarnpkg.com/@types/immediate/-/immediate-3.2.0.tgz#497e830a92aa4990aeba93c66a0f90ee790cb3f6"
+  integrity sha512-CojBxLEgxjdIXgoxSYrxvaydin6MmA94rCHg2AKmC+7FePBXNfFxhZ/1RRkUwyBnCi3YoVyg8PiM5iUQFku5pw==
+
 "@types/invariant@^2.2.31":
   version "2.2.34"
   resolved "https://registry.yarnpkg.com/@types/invariant/-/invariant-2.2.34.tgz#05e4f79f465c2007884374d4795452f995720bbe"
@@ -9743,6 +9748,11 @@ ignore@^5.0.6, ignore@^5.1.1:
   resolved "https://registry.yarnpkg.com/ignore/-/ignore-5.1.8.tgz#f150a8b50a34289b33e22f5889abd4d8016f0e57"
   integrity sha512-BMpfD7PpiETpBl/A6S498BaIJ6Y/ABT93ETbby2fP00v4EbvPBXWEoaR1UBPKs3iR53pJY7EtZk5KACI57i1Uw==
 
+immediate@^3.2.3:
+  version "3.3.0"
+  resolved "https://registry.yarnpkg.com/immediate/-/immediate-3.3.0.tgz#1aef225517836bcdf7f2a2de2600c79ff0269266"
+  integrity sha512-HR7EVodfFUdQCTIeySw+WDRFJlPcLOJbXfwwZ7Oom6tjsvZ3bOkCDJHehQC3nxJrv7+f9XecwazynjU8e4Vw3Q==
+
 immediate@~3.0.5:
   version "3.0.6"
   resolved "https://registry.yarnpkg.com/immediate/-/immediate-3.0.6.tgz#9db1dbd0faf8de6fbe0f5dd5e56bb606280de69b"
@@ -14443,6 +14453,15 @@ pluralize@^8.0.0:
   resolved "https://registry.yarnpkg.com/pluralize/-/pluralize-8.0.0.tgz#1a6fa16a38d12a1901e0320fa017051c539ce3b1"
   integrity sha512-Nc3IT5yHzflTfbjgqWcCPpo7DaKy4FnpB0l/zCAW0Tc7jxAiuqSxHasntB3D7887LSrA93kDJ9IXovxJYxyLCA==
 
+polygala@4.0.0:
+  version "4.0.0"
+  resolved "https://registry.yarnpkg.com/polygala/-/polygala-4.0.0.tgz#b408d4031c47d2b55b8c9dd0231c4b37ba24a775"
+  integrity sha512-NFCEozpfmK0wAymxrpdje2PP5laLfWJZsOHMwETbdooXc59LhfANZEqFtH5cokiMjd6sCpU0Vt0fnmHaF/Kn9A==
+  dependencies:
+    "@types/immediate" "^3.2.0"
+    immediate "^3.2.3"
+    tslib "^1.9.3"
+
 popper.js@^1.14.4:
   version "1.16.1"
   resolved "https://registry.yarnpkg.com/popper.js/-/popper.js-1.16.1.tgz#2a223cb3dc7b6213d740e40372be40de43e65b1b"