yujunjun/strapi
1
0
Fork 0
mirror of https://github.com/strapi/strapi.git synced 2025-12-27 15:13:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

add todo tests

Browse Source
This commit is contained in:
Ben Irvin 2022-07-28 19:40:43 +02:00
parent 17036e964c
commit de5c1a7f57
1 changed files with 57 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

77
packages/core/permissions/lib/__tests__/permissions.engine.test.js
View File

@ -2,6 +2,8 @@
const permissions = require('../');
// TODO: test abilityBuilderFactory
// TODO: test generateAbility with options
describe('Permissions Engine', () => {
const providers = {
action: { get: jest.fn() },
@ -21,7 +23,11 @@ describe('Permissions Engine', () => {
const generateInvalidateActionHook = action => {
return params => {
if (params.permission.action === action) return false;
console.log('params.permission', params.permission, action);
if (params.permission.action === action) {
console.log('invalidating');
return false;
}
};
};
@ -88,7 +94,7 @@ describe('Permissions Engine', () => {
});
describe('conditions', () => {
it('does not register action when conditions not met', async () => {
it.skip('does not register action when conditions not met', async () => {
const { ability } = await buildEngineWithAbility({
permissions: [
{
@ -129,7 +135,25 @@ describe('Permissions Engine', () => {
expect(ability.can('read', 'article', 'title')).toBeTruthy();
});
// TODO: test all hooks are called at the right time and bail correctly
// 'before-format::validate.permission': hooks.createAsyncBailHook(),
// 'format.permission': hooks.createAsyncSeriesWaterfallHook(),
// 'post-format::validate.permission': hooks.createAsyncBailHook(),
// 'before-evaluate.permission': hooks.createAsyncSeriesHook(),
// 'before-register.permission': hooks.createAsyncSeriesHook(),
describe('hooks', () => {
it.skip('format.permission can modify permissions', () => {
// .on('format.permission', permission => {
// if (permission.action === 'modifyMe') {
// return {
// ...permission,
// action: 'modifedAction',
// };
// }
// return permission;
// });
});
it('before-format::validate.permission can prevent action register', async () => {
const { ability } = await buildEngineWithAbility({
permissions: [{ action: 'read', subject: 'article' }],
@ -141,6 +165,9 @@ describe('Permissions Engine', () => {
expect(ability.can('read', 'user')).toBeFalsy();
});
});
it.skip('before-format::validate.permission run before format.permission', () => {});
it('post-format::validate.permission can prevent action register', async () => {
const { ability } = await buildEngineWithAbility({
permissions: [{ action: 'read', subject: 'article' }],
@ -152,25 +179,35 @@ describe('Permissions Engine', () => {
expect(ability.can('read', 'user')).toBeFalsy();
});
it('before-evaluate.permission can prevent action register', async () => {
const { ability } = await buildEngineWithAbility({
permissions: [{ action: 'read', subject: 'article' }],
engineHooks: [
{ name: 'before-evaluate.permission', fn: generateInvalidateActionHook('read') },
],
});
expect(ability.can('read', 'article')).toBeFalsy();
expect(ability.can('read', 'user')).toBeFalsy();
it.skip('post-format::validate.permission runs after format.permission', () => {});
it.skip('before-evaluate.permission is called ', async () => {
// const { ability } = await buildEngineWithAbility({
// permissions: [{ action: 'read', subject: 'article' }],
// engineHooks: [
// {
// name: 'before-evaluate.permission',
// fn(permissions) {
// console.log('permissions', permissions);
// return;
// },
// },
// ],
// });
});
it('before-register.permission can prevent action register', async () => {
const { ability } = await buildEngineWithAbility({
permissions: [{ action: 'read', subject: 'article' }],
engineHooks: [
{ name: 'before-register.permission', fn: generateInvalidateActionHook('read') },
],
});
expect(ability.can('read', 'article')).toBeFalsy();
expect(ability.can('read', 'user')).toBeFalsy();
it.skip('before-register.permission is called ', async () => {
// const { ability } = await buildEngineWithAbility({
// permissions: [{ action: 'read', subject: 'article' }],
// engineHooks: [
// {
// name: 'before-evaluate.permission',
// fn(permissions) {
// console.log('permissions', permissions);
// return;
// },
// },
// ],
// });
});
});