From e97b8cca7118e5693488004a89fc4d094c9a5d97 Mon Sep 17 00:00:00 2001 From: soupette Date: Fri, 10 Apr 2020 15:25:00 +0200 Subject: [PATCH] Fix PR feedback Signed-off-by: soupette --- docs/3.0.0-beta.x/guides/registering-a-field-in-admin.md | 4 +--- .../plugin-development/frontend-components-api.md | 4 ++-- .../admin/src/components/Wysiwyg/MediaLib.js | 2 +- 3 files changed, 4 insertions(+), 6 deletions(-) diff --git a/docs/3.0.0-beta.x/guides/registering-a-field-in-admin.md b/docs/3.0.0-beta.x/guides/registering-a-field-in-admin.md index 503d938e88..d87007312e 100644 --- a/docs/3.0.0-beta.x/guides/registering-a-field-in-admin.md +++ b/docs/3.0.0-beta.x/guides/registering-a-field-in-admin.md @@ -151,8 +151,6 @@ const Wysiwyg = ({ } const handleChange = data => { - console.log(data); - if (data.mime.includes('image')) { const imgTag = `

${data.alternativeText}

`; const newValue = value ? `${value}${imgTag}` : imgTag; @@ -160,7 +158,7 @@ const Wysiwyg = ({ onChange({ target: { name, value: newValue } }); } - // Handle videos and other type of files + // Handle videos and other type of files by adding some code }; const handleToggle = () => setIsOpen(prev => !prev); diff --git a/docs/3.0.0-beta.x/plugin-development/frontend-components-api.md b/docs/3.0.0-beta.x/plugin-development/frontend-components-api.md index b017c208b1..73092d30cb 100644 --- a/docs/3.0.0-beta.x/plugin-development/frontend-components-api.md +++ b/docs/3.0.0-beta.x/plugin-development/frontend-components-api.md @@ -93,8 +93,8 @@ const Initializer = ({ updatePlugin }) => { ref.current = updatePlugin; useEffect(() => { - // Register the new field - strapi.componentApi.registerComponent({ name: 'm-component', Component: MyComponent }); + // Register the new component + strapi.componentApi.registerComponent({ name: 'my-component', Component: MyComponent }); ref.current(pluginId, 'isReady', true); }, []); diff --git a/packages/strapi-plugin-content-manager/admin/src/components/Wysiwyg/MediaLib.js b/packages/strapi-plugin-content-manager/admin/src/components/Wysiwyg/MediaLib.js index 52b8dc754b..c14350e123 100644 --- a/packages/strapi-plugin-content-manager/admin/src/components/Wysiwyg/MediaLib.js +++ b/packages/strapi-plugin-content-manager/admin/src/components/Wysiwyg/MediaLib.js @@ -22,7 +22,7 @@ const MediaLib = ({ isOpen, onChange, onToggle }) => { const handleInputChange = data => { if (data) { const { name, alternativeText, url } = data; - const alt = alternativeText === '' ? name : alternativeText; + const alt = alternativeText || name; setData({ alt, url: prefixFileUrlWithBackendUrl(url) }); }