From b18b6369629faf2e788eb59a30e4b19a40365293 Mon Sep 17 00:00:00 2001 From: derrickmehaffy Date: Thu, 6 Oct 2022 06:42:47 -0700 Subject: [PATCH 1/2] Add File ID to edit asset dialog Signed-off-by: Derrick Mehaffy --- .../upload/admin/src/components/EditAssetDialog/index.js | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/packages/core/upload/admin/src/components/EditAssetDialog/index.js b/packages/core/upload/admin/src/components/EditAssetDialog/index.js index d2e9ceefb6..f6f58f7bdd 100644 --- a/packages/core/upload/admin/src/components/EditAssetDialog/index.js +++ b/packages/core/upload/admin/src/components/EditAssetDialog/index.js @@ -225,6 +225,14 @@ export const EditAssetDialog = ({ }), value: getFileExtension(asset.ext), }, + + { + label: formatMessage({ + id: getTrad('modal.file-details.id'), + defaultMessage: 'File ID', + }), + value: asset.id, + }, ]} /> From 0b56ebf5d8e7d068006cdf9cea8b232e836ef14a Mon Sep 17 00:00:00 2001 From: derrickmehaffy Date: Thu, 6 Oct 2022 07:47:43 -0700 Subject: [PATCH 2/2] Apply PR feedback and update snapshot tests Signed-off-by: Derrick Mehaffy --- .../src/components/EditAssetDialog/index.js | 2 +- .../EditAssetDialog.test.js.snap | 23 +++++++++++++++++++ .../tests/__snapshots__/index.test.js.snap | 23 +++++++++++++++++++ .../upload/admin/src/translations/en.json | 1 + 4 files changed, 48 insertions(+), 1 deletion(-) diff --git a/packages/core/upload/admin/src/components/EditAssetDialog/index.js b/packages/core/upload/admin/src/components/EditAssetDialog/index.js index f6f58f7bdd..8aab10e035 100644 --- a/packages/core/upload/admin/src/components/EditAssetDialog/index.js +++ b/packages/core/upload/admin/src/components/EditAssetDialog/index.js @@ -229,7 +229,7 @@ export const EditAssetDialog = ({ { label: formatMessage({ id: getTrad('modal.file-details.id'), - defaultMessage: 'File ID', + defaultMessage: 'Asset ID', }), value: asset.id, }, diff --git a/packages/core/upload/admin/src/components/EditAssetDialog/tests/__snapshots__/EditAssetDialog.test.js.snap b/packages/core/upload/admin/src/components/EditAssetDialog/tests/__snapshots__/EditAssetDialog.test.js.snap index 6be3fd8d8c..6e14e34e5a 100644 --- a/packages/core/upload/admin/src/components/EditAssetDialog/tests/__snapshots__/EditAssetDialog.test.js.snap +++ b/packages/core/upload/admin/src/components/EditAssetDialog/tests/__snapshots__/EditAssetDialog.test.js.snap @@ -1290,6 +1290,29 @@ exports[` renders and matches the snapshot 1`] = ` +
+
+
+ + Asset ID + + + 8 + +
+
+
diff --git a/packages/core/upload/admin/src/components/EditAssetDialog/tests/__snapshots__/index.test.js.snap b/packages/core/upload/admin/src/components/EditAssetDialog/tests/__snapshots__/index.test.js.snap index 6be3fd8d8c..6e14e34e5a 100644 --- a/packages/core/upload/admin/src/components/EditAssetDialog/tests/__snapshots__/index.test.js.snap +++ b/packages/core/upload/admin/src/components/EditAssetDialog/tests/__snapshots__/index.test.js.snap @@ -1290,6 +1290,29 @@ exports[` renders and matches the snapshot 1`] = `
+
+
+
+ + Asset ID + + + 8 + +
+
+
diff --git a/packages/core/upload/admin/src/translations/en.json b/packages/core/upload/admin/src/translations/en.json index 9df2127ace..8f8d4ad792 100644 --- a/packages/core/upload/admin/src/translations/en.json +++ b/packages/core/upload/admin/src/translations/en.json @@ -64,6 +64,7 @@ "modal.file-details.dimensions": "Dimensions", "modal.file-details.extension": "Extension", "modal.file-details.size": "Size", + "modal.file-details.id": "Asset ID", "modal.folder.elements.count": "{folderCount} folders, {assetCount} assets", "modal.header.browse": "Upload assets", "modal.header.file-detail": "Details",