Apply review comments

api-tests/core/admin/admin-permission.test.api.js

@@ -34,7 +34,7 @@ describe('Role CRUD End to End', () => {
     sortedData.conditions = sortedData.conditions.sort();
 
     // eslint-disable-next-line node/no-extraneous-require
-    const { features } = require('@strapi/strapi/dist/utils/ee');
+    const { features } = require('@strapi/strapi/dist/utils/ee').default;
     const hasSSO = features.isEnabled('sso');
 
     if (hasSSO) {

examples/getstarted/src/api/address/services/address.js

@@ -1,7 +1,3 @@
 const { createCoreService } = require('@strapi/strapi').factories;
 
-module.exports = createCoreService('api::address.address', {
-  async find(coucou) {
-    return [{ coucou }];
-  }
-});
+module.exports = createCoreService('api::address.address');

packages/core/admin/ee/server/bootstrap.js

@@ -1,7 +1,7 @@
 'use strict';
 
 // eslint-disable-next-line node/no-extraneous-require
-const { features } = require('@strapi/strapi/dist/utils/ee');
+const { features } = require('@strapi/strapi/dist/utils/ee').default;
 const executeCEBootstrap = require('../../server/bootstrap');
 const { getService } = require('../../server/utils');
 const actions = require('./config/admin-actions');

packages/core/admin/ee/server/controllers/admin.js

@@ -2,7 +2,7 @@
 
 const { isNil } = require('lodash/fp');
 // eslint-disable-next-line node/no-extraneous-require
-const ee = require('@strapi/strapi/dist/utils/ee');
+const ee = require('@strapi/strapi/dist/utils/ee').default;
 const { env } = require('@strapi/utils');
 const { getService } = require('../../../server/utils');
 

packages/core/admin/ee/server/controllers/user.js

@@ -1,7 +1,7 @@
 'use strict';
 
 // eslint-disable-next-line node/no-extraneous-require
-const ee = require('@strapi/strapi/dist/utils/ee');
+const ee = require('@strapi/strapi/dist/utils/ee').default;
 const _ = require('lodash');
 const { pick, isNil } = require('lodash/fp');
 const { ApplicationError, ForbiddenError } = require('@strapi/utils').errors;

packages/core/admin/ee/server/destroy.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const { features } = require('@strapi/strapi/dist/utils/ee');
+const { features } = require('@strapi/strapi/dist/utils/ee').default;
 const executeCEDestroy = require('../../server/destroy');
 
 module.exports = async ({ strapi }) => {

packages/core/admin/ee/server/register.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const { features } = require('@strapi/strapi/dist/utils/ee');
+const { features } = require('@strapi/strapi/dist/utils/ee').default;
 const executeCERegister = require('../../server/register');
 const migrateAuditLogsTable = require('./migrations/audit-logs-table');
 const migrateReviewWorkflowStagesColor = require('./migrations/review-workflows-stages-color');

packages/core/admin/ee/server/routes/utils.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const { features } = require('@strapi/strapi/dist/utils/ee');
+const { features } = require('@strapi/strapi/dist/utils/ee').default;
 
 const enableFeatureMiddleware = (featureName) => (ctx, next) => {
   if (features.isEnabled(featureName)) {

packages/core/admin/ee/server/services/__tests__/audit-logs.test.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const { features } = require('@strapi/strapi/dist/utils/ee');
+const { features } = require('@strapi/strapi/dist/utils/ee').default;
 const { register } = require('@strapi/provider-audit-logs-local');
 const { scheduleJob } = require('node-schedule');
 const createAuditLogsService = require('../audit-logs');

packages/core/admin/ee/server/services/audit-logs.js

@@ -2,7 +2,7 @@
 
 const localProvider = require('@strapi/provider-audit-logs-local');
 const { scheduleJob } = require('node-schedule');
-const { features } = require('@strapi/strapi/dist/utils/ee');
+const { features } = require('@strapi/strapi/dist/utils/ee').default;
 
 const DEFAULT_RETENTION_DAYS = 90;
 

packages/core/admin/ee/server/services/passport.js

@@ -1,7 +1,7 @@
 'use strict';
 
 // eslint-disable-next-line node/no-extraneous-require
-const { features } = require('@strapi/strapi/dist/utils/ee');
+const { features } = require('@strapi/strapi/dist/utils/ee').default;
 
 const { UnauthorizedError } = require('@strapi/utils').errors;
 const createLocalStrategy = require('../../../server/services/passport/local-strategy');

packages/core/admin/ee/server/services/passport/sso.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const ee = require('@strapi/strapi/dist/utils/ee');
+const ee = require('@strapi/strapi/dist/utils/ee').default;
 const { authEventsMapper } = require('../../../../server/services/passport');
 const createProviderRegistry = require('./provider-registry');
 

packages/core/admin/ee/server/services/seat-enforcement.js

@@ -1,7 +1,7 @@
 'use strict';
 
 // eslint-disable-next-line node/no-extraneous-require
-const ee = require('@strapi/strapi/dist/utils/ee');
+const ee = require('@strapi/strapi/dist/utils/ee').default;
 const { take, drop, map, prop, pick, reverse, isNil } = require('lodash/fp');
 const { getService } = require('../../../server/utils');
 const { SUPER_ADMIN_CODE } = require('../../../server/services/constants');

packages/core/admin/ee/server/utils/sso-lock.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const { features } = require('@strapi/strapi/dist/utils/ee');
+const { features } = require('@strapi/strapi/dist/utils/ee').default;
 const { isEmpty } = require('lodash/fp');
 
 const isSsoLocked = async (user) => {

packages/core/admin/ee/server/validation/role.js

@@ -2,7 +2,7 @@
 
 const { yup, validateYupSchema } = require('@strapi/utils');
 // eslint-disable-next-line node/no-extraneous-require
-const { features } = require('@strapi/strapi/dist/utils/ee');
+const { features } = require('@strapi/strapi/dist/utils/ee').default;
 
 const roleCreateSchema = yup
   .object()

packages/core/admin/ee/server/validation/user.js

@@ -2,7 +2,7 @@
 
 const { yup, validateYupSchema } = require('@strapi/utils');
 // eslint-disable-next-line node/no-extraneous-require
-const { features } = require('@strapi/strapi/dist/utils/ee');
+const { features } = require('@strapi/strapi/dist/utils/ee').default;
 const { schemas } = require('../../../server/validation/user');
 
 const ssoUserCreationInputExtension = yup

packages/core/admin/server/controllers/admin.js

@@ -8,7 +8,7 @@ const { exists } = require('fs-extra');
 const { env } = require('@strapi/utils');
 const { isUsingTypeScript } = require('@strapi/typescript-utils');
 // eslint-disable-next-line node/no-extraneous-require
-const ee = require('@strapi/strapi/dist/utils/ee');
+const ee = require('@strapi/strapi/dist/utils/ee').default;
 
 const {
   validateUpdateProjectSettings,

packages/core/data-transfer/src/commands/__tests__/commands.test.utils.ts

@@ -1,3 +1,4 @@
+// TODO: move to a test-utils internal pkg
 import type { Utils } from '@strapi/typings';
 
 const expectExit = async (code: number, fn: Utils.Function.Any) => {

packages/core/data-transfer/src/strapi/providers/local-source/assets.ts

@@ -62,8 +62,8 @@ function getFileStats(filepath: string, isLocal = false): Promise<{ size: number
 export const createAssetsStream = (strapi: LoadedStrapi): Duplex => {
   const generator: () => AsyncGenerator<IAsset, void> = async function* () {
     const stream: Readable = strapi.db
+      .queryBuilder('plugin::upload.file')
       // Create a query builder instance (default type is 'select')
-      ?.queryBuilder('plugin::upload.file')
       // Fetch all columns
       .select('*')
       // Get a readable stream

packages/core/data-transfer/src/strapi/queries/entity.ts

@@ -22,10 +22,7 @@ const createEntityQuery = (strapi: LoadedStrapi): any => {
     async assignToEntity(uid: Common.UID.Schema, data: any) {
       const model = strapi.getModel(uid);
 
-      const entityComponents = await componentsService.createComponents(
-        uid as Common.UID.Schema,
-        data
-      );
+      const entityComponents = await componentsService.createComponents(uid, data);
       const dataWithoutComponents = sanitizeComponentLikeAttributes(model, data);
 
       return assign(entityComponents, dataWithoutComponents);

packages/core/strapi/src/commands/__tests__/commands.test.utils.ts

@@ -1,3 +1,4 @@
+// TODO: move to a test-utils internal pkg
 import type { Utils } from '@strapi/typings';
 
 const expectExit = async (code: number, fn: Utils.Function.Any) => {

packages/core/typings/src/types/core-api/router.ts

@@ -55,7 +55,7 @@ export type RouterConfig<TContentTypeUID extends Common.UID.ContentType> = {
     ],
     Generic
   >;
-  type: RouterType;
+  type?: RouterType;
 };
 
 export type RouterType = 'admin' | 'content-api';