yujunjun/strapi
1
0
Fork 0
mirror of https://github.com/strapi/strapi.git synced 2025-11-03 19:36:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

use standard filtering for ID in ct findOne query

Browse Source
This commit is contained in:
Convly 2021-07-30 13:38:14 +02:00
parent 210434dab9
commit fa3d90f201
1 changed files with 7 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
packages/plugins/graphql/services/schema/builders/queries/collection-type.js
View File

@ -1,19 +1,12 @@
'use strict'; 'use strict';
const { extendType } = require('nexus'); const { extendType } = require('nexus');
const { pipe } = require('lodash/fp');
const { actionExists } = require('../../../old/utils'); const { actionExists } = require('../../../old/utils');
const { utils, args } = require('../../../types'); const { utils, args } = require('../../../types');
const { const { transformArgs } = require('../utils');
getUniqueScalarAttributes,
scalarAttributesToFiltersMap,
transformArgs,
} = require('../utils');
const { buildQueriesResolvers } = require('../../resolvers'); const { buildQueriesResolvers } = require('../../resolvers');
const getUniqueAttributesFiltersMap = pipe(getUniqueScalarAttributes, scalarAttributesToFiltersMap);
module.exports = ({ strapi }) => { module.exports = ({ strapi }) => {
const buildCollectionTypeQueries = contentType => { const buildCollectionTypeQueries = contentType => {
return extendType({ return extendType({
@ -32,7 +25,7 @@ module.exports = ({ strapi }) => {
* @param contentType * @param contentType
*/ */
const addFindOneQuery = (t, contentType) => { const addFindOneQuery = (t, contentType) => {
const { uid, attributes } = contentType; const { uid } = contentType;
const findOneQueryName = utils.getFindOneQueryName(contentType); const findOneQueryName = utils.getFindOneQueryName(contentType);
const responseTypeName = utils.getEntityResponseName(contentType); const responseTypeName = utils.getEntityResponseName(contentType);
@ -42,15 +35,17 @@ module.exports = ({ strapi }) => {
return; return;
} }
// todo[v4]: Don't allow to filter using every unique attributes for now
// Only authorize filtering using unique scalar fields for findOne queries // Only authorize filtering using unique scalar fields for findOne queries
const uniqueAttributes = getUniqueAttributesFiltersMap(attributes); // const uniqueAttributes = getUniqueAttributesFiltersMap(attributes);
t.field(findOneQueryName, { t.field(findOneQueryName, {
type: responseTypeName, type: responseTypeName,
args: { args: {
id: utils.getScalarFilterInputTypeName('ID'), id: 'ID',
...uniqueAttributes, // todo[v4]: Don't allow to filter using every unique attributes for now
// ...uniqueAttributes,
}, },
async resolve(source, args) { async resolve(source, args) {