Jamie Howard 1097504b36
[core] document unique field validation per content type and locale (#19153)
* feat: use document service in content manager

* feat: update contracts with meta information

* chore: group metadata types into a single type

* feat: metadata information in single types

* chore: change meta contract to return documents instead of strings

* fix: remove unused type

* fix: ignore doc id if entry is null

* fix: update contract metadata

* feat: document metadata service

* feat: locale and status filtering

* chore: add comment

* chore: refactor metadata service

* chore: refactor entity manager exists to handle single types

* feat: refactor single type controllers to use documents

* feat: get locale param from in cm endpoints

* Revert "feat: get locale param from in cm endpoints"

This reverts commit 856c38588b8f8521cadd85c8c933f42a36a2178a.

* feat: get locale param from cm endpoints

* Update packages/plugins/i18n/server/src/controllers/validate-locale-creation.ts

Co-authored-by: Ben Irvin <ben@innerdvations.com>

* fix: entity manager unit tests

* chore: unit test document metadata

* feat: prevent empty string locale filtering

* feat(core): document unique field validation per content type and locale

* feat(e2e): test document unique fields

* fix(admin): ts build

* fix: cm contract import

* chore: test new d&p cm features

* feat(core): validate document unique fields within one publication state

chore: remove build:ts

* fix: search content manager api test

* fix: cm tests

* fix: cm tests

* fix: cm tests

* fix(content-manager): access to non default locale documents (#19190)

* fix(content-manager): access to non default locale documents

* chore(content-manager): revert route construction

* fix(content-manager): api tests for number of draft relations

* test(content-manager): counting number of draft relations for non default locales

* chore(content-manager): remove default locale from entity manager countDraftRelations

* test(document-service): api tests for unique document fields per publication state

* test(i18n): api tests for unique document fields per locale

* chore(api-tests): adjust author schema

* chore(e2e): disable edit view tests (#19235)

* fix(core): unique validation on publish

* fix(api-tests): un-localise author

* fix(e2e): incorrect path

* fix(admin): tidy up

* fix(admin): pass correct locale query params

fix(core): pass locale outside of filters

* chore(api-tests): wip comment for relatedEntityId logic

* fix(core): entity validator tests

* chore(api-tests): wip skip failing relations i18n test

* chore(e2e): clean up editview spec

* fix(content-manager): pass locale to publish and unpublish

* fix(content-manager): fix test:ts:back

* fix(e2e): update edit view expected path

* fix(entity-validator): default to null locale

fix(api-tests): wip i18n test changes

* fix(e2e): wip UID fields

* chore(content-type-builder): temporarily disable component unique field checkboxes (#19253)

* fix(admin): wip correctly pass params

feat(e2e): reintroduce uniqueness e2e tests

* Refactor UID validation for V5 (#19285)

* fix(database): wip remove UID unique DB constraint

* feat(content-manager): update uid checking endpoints to look at locale

* chore(admin): clean up

* fix(content-manager): single type unit tests

* fix(content-manager): send all params to uid endpoints

* feat(e2e): update tar backup to support unique CT

* fix(e2e): uniqueness spec

* chore(e2e): remove only

* fix(content-manager): only check UID availability against drafts

feat(api-tests): test case for UID validation across locales

* fix(content-manager): uid unit tests

* chore(api-tests): clean up

* chore(content-manager): clean up

* chore(i18n): remove relatedEntityId reference

---------

Co-authored-by: Marc-Roig <marc12info@gmail.com>
Co-authored-by: Ben Irvin <ben@innerdvations.com>
Co-authored-by: Josh <37798644+joshuaellis@users.noreply.github.com>
2024-01-29 15:35:20 +00:00

256 lines
6.3 KiB
JavaScript

'use strict';
const { createTestBuilder } = require('api-tests/builder');
const { createStrapiInstance } = require('api-tests/strapi');
const { createAuthRequest } = require('api-tests/request');
let strapi;
let rq;
describe('Test type UID', () => {
describe('No targetField, required=false, not length limits', () => {
const model = {
displayName: 'With uid',
singularName: 'withuid',
pluralName: 'withuids',
attributes: {
slug: {
type: 'uid',
},
},
};
const builder = createTestBuilder();
beforeAll(async () => {
await builder.addContentType(model).build();
strapi = await createStrapiInstance();
rq = await createAuthRequest({ strapi });
});
afterAll(async () => {
await strapi.destroy();
await builder.cleanup();
});
test('Creates an entry successfully', async () => {
const res = await rq.post('/content-manager/collection-types/api::withuid.withuid', {
body: {
slug: 'valid-uid',
},
});
expect(res.statusCode).toBe(200);
expect(res.body).toMatchObject({
slug: 'valid-uid',
});
});
// TODO: to handle with database UniqueError
test.skip('Throws error on duplicate value', async () => {
const res = await rq.post('/content-manager/collection-types/api::withuid.withuid', {
body: {
slug: 'duplicate-uid',
},
});
expect(res.statusCode).toBe(200);
expect(res.body).toMatchObject({
slug: 'duplicate-uid',
});
const conflicting = await rq.post('/content-manager/collection-types/api::withuid.withuid', {
body: {
slug: 'duplicate-uid',
},
});
expect(conflicting.statusCode).toBe(400);
});
test('Can set value to be null', async () => {
const res = await rq.post('/content-manager/collection-types/api::withuid.withuid', {
body: {
slug: null,
},
});
expect(res.statusCode).toBe(200);
expect(res.body).toMatchObject({
slug: null,
});
});
});
describe('Value validation', () => {
const model = {
displayName: 'With uid',
singularName: 'withuid',
pluralName: 'withuids',
pluginOptions: {
i18n: {
localized: true,
},
},
attributes: {
slug: {
type: 'uid',
},
},
};
const builder = createTestBuilder();
const locales = ['en', 'fr'];
beforeAll(async () => {
await builder.addContentType(model).build();
strapi = await createStrapiInstance();
rq = await createAuthRequest({ strapi });
for (const locale of locales) {
await rq({
method: 'POST',
url: '/i18n/locales',
body: {
code: locale,
name: `${locale}`,
isDefault: false,
},
});
}
});
afterAll(async () => {
await strapi.destroy();
await builder.cleanup();
});
test('Values should not have to be unique across different locales', async () => {
const value = 'valid-uid';
const endpoint = '/content-manager/collection-types/api::withuid.withuid';
const englishEndpoint = `${endpoint}?locale=${locales[0]}`;
const frenchEndpoint = `${endpoint}?locale=${locales[1]}`;
const res = await rq.post(englishEndpoint, {
body: {
slug: value,
},
});
expect(res.statusCode).toBe(200);
expect(res.body).toMatchObject({
slug: value,
});
// Test that we cannot create a new entry with the same value in the same locale
const sameLocaleResult = await rq.post(englishEndpoint, {
body: {
slug: value,
},
});
expect(sameLocaleResult.statusCode).toBe(400);
// Test that we can create a new entry with the same value in a different locale
const newLocaleResult = await rq.post(frenchEndpoint, {
body: {
slug: value,
},
});
expect(newLocaleResult.statusCode).toBe(200);
});
});
describe('No targetField, required, no length limits', () => {
const model = {
displayName: 'withrequireduid',
singularName: 'withrequireduid',
pluralName: 'withrequireduids',
attributes: {
slug: {
type: 'uid',
required: true,
},
},
};
const builder = createTestBuilder();
beforeAll(async () => {
await builder.addContentType(model).build();
strapi = await createStrapiInstance();
rq = await createAuthRequest({ strapi });
});
afterAll(async () => {
await strapi.destroy();
await builder.cleanup();
});
test('Creates an entry successfully', async () => {
const res = await rq.post(
'/content-manager/collection-types/api::withrequireduid.withrequireduid',
{
body: {
slug: 'valid-uid',
},
}
);
expect(res.statusCode).toBe(200);
expect(res.body).toMatchObject({
slug: 'valid-uid',
});
});
// TODO: to handle with database UniqueError
test.skip('Throws error on duplicate value', async () => {
const res = await rq.post(
'/content-manager/collection-types/api::withrequireduid.withrequireduid',
{
body: {
slug: 'duplicate-uid',
},
}
);
expect(res.statusCode).toBe(200);
expect(res.body).toMatchObject({
slug: 'duplicate-uid',
});
const conflicting = await rq.post(
'/content-manager/collection-types/api::withrequireduid.withrequireduid',
{
body: {
slug: 'duplicate-uid',
},
}
);
expect(conflicting.statusCode).toBe(400);
});
// TODO: Fix uniqueness and validations in document service
test.skip('Cannot set value to be null', async () => {
const createRes = await rq.post(
'/content-manager/collection-types/api::withrequireduid.withrequireduid',
{
body: {
slug: null,
},
}
);
const res = await rq.post(
`/content-manager/collection-types/api::withrequireduid.withrequireduid/${createRes.body.id}/actions/publish`
);
expect(res.statusCode).toBe(400);
});
});
});