Jean-Sébastien Herbaux 1e5b1c99f6
I18n/ permissions rework (#9535)
* Add a domain layer for the permission, rework the engine handling of the permissions

Signed-off-by: Convly <jean-sebastien.herbaux@epitech.eu>

* Add permissions-fields-to-properties migration for the admin

Signed-off-by: Convly <jean-sebastien.herbaux@epitech.eu>

* Removes useless console.log

Signed-off-by: Convly <jean-sebastien.herbaux@epitech.eu>

* Remove debug logLevel from provider-login.test.e2e.js

Signed-off-by: Convly <jean-sebastien.herbaux@epitech.eu>

* Adds the new layout for the GET permissions, allow to subscribe to actionRegistered events, adds i18n handlers

Signed-off-by: Convly <jean-sebastien.herbaux@epitech.eu>

* Fix typo

Signed-off-by: Convly <jean-sebastien.herbaux@epitech.eu>

* Update permissions validators

Signed-off-by: Convly <jean-sebastien.herbaux@epitech.eu>

* Update unit tests

Signed-off-by: Convly <jean-sebastien.herbaux@epitech.eu>

* Update integrations test + fix some validation issues

Signed-off-by: Convly <jean-sebastien.herbaux@epitech.eu>

* Change plugins & settings section format for the permissions layout

* only return locales property to localized subjects for the permission's layout

* Do not send the locales property to the permission's layout when there is no locales created

* Add the 'locales' property to publish & delete routes

* Fix unwanted mutation of the sections builder states on multiple builds

* Fix units tests with (new engine)

* Fix admin-role e2e test - Add locales property to the update payload

* fix e2e testsé

* Update e2e snapshots

* Fix unit test for i18n bootstrap

* Add mocks for i18n/bootstrap test

* Fix has-locale condition & updatePermission validator

* Avoid mutation in migration, always authorize super admin for has-locales condition

* Rework rbac domain objects, add a hook module and a provider factory

* Remove old providers

* Update the admin services & tests for the new rbac domain & providers

* Fix tests, bootstrap functions & services following rbac domain rework

* Update migration runner

* PR comments

Signed-off-by: Convly <jean-sebastien.herbaux@epitech.eu>

* Remove useless console.log

* Fix sanitizeCondition bug

* Section builder rework

* Add test for the section-builder section & add jsdoc for the permission domain

* pr comments (without the migrations)

* fix fields-to-properties migration

* Add jsdoc for the sections-builder

* Moves createBoundAbstractDomain from permission domain to the engine service

* Remove debug logLevel for admin role test (e2e)

* Fix core-store

* Fix hooks & move business logic from i18n bootstrap to dedicated services

* add route get-non-localized-fields

* use write and read permission

* refacto

* add input validator

* add route doc

* handle ST

Co-authored-by: Pierre Noël <petersg83@gmail.com>
Co-authored-by: Alexandre BODIN <alexandrebodin@users.noreply.github.com>
2021-03-25 14:59:44 +01:00

149 lines
3.7 KiB
JavaScript

'use strict';
const { yup, formatYupErrors } = require('strapi-utils');
const { validateRoleUpdateInput } = require('../validation/role');
const { validatedUpdatePermissionsInput } = require('../validation/permission');
const { EDITOR_CODE, AUTHOR_CODE, SUPER_ADMIN_CODE } = require('../services/constants');
const { getService } = require('../utils');
module.exports = {
/**
* Returns on role by id
* @param {KoaContext} ctx - koa context
*/
async findOne(ctx) {
const { id } = ctx.params;
const role = await getService('role').findOneWithUsersCount({ id });
if (!role) {
return ctx.notFound('role.notFound');
}
ctx.body = {
data: role,
};
},
/**
* Returns every roles
* @param {KoaContext} ctx - koa context
*/
async findAll(ctx) {
const roles = await getService('role').findAllWithUsersCount();
ctx.body = {
data: roles,
};
},
/**
* Updates a role by id
* @param {KoaContext} ctx - koa context
*/
async update(ctx) {
const { id } = ctx.params;
const { body } = ctx.request;
const roleService = getService('role');
try {
await validateRoleUpdateInput(body);
} catch (err) {
return ctx.badRequest('ValidationError', err);
}
const role = await roleService.findOne({ id });
if (!role) {
return ctx.notFound('role.notFound');
}
if (role.code === SUPER_ADMIN_CODE) {
return ctx.badRequest("Super admin can't be edited.");
}
const updatedRole = await roleService.update({ id }, body);
const sanitizedRole = roleService.sanitizeRole(updatedRole);
ctx.body = {
data: sanitizedRole,
};
},
/**
* Returns the permissions assigned to a role
* @param {KoaContext} ctx - koa context
*/
async getPermissions(ctx) {
const { id } = ctx.params;
const roleService = getService('role');
const permissionService = getService('permission');
const role = await roleService.findOne({ id });
if (!role) {
return ctx.notFound('role.notFound');
}
const permissions = await permissionService.find({ role: role.id, _limit: -1 });
const sanitizedPermissions = permissions.map(permissionService.sanitizePermission);
ctx.body = {
data: sanitizedPermissions,
};
},
/**
* Updates the permissions assigned to a role
* @param {KoaContext} ctx - koa context
*/
async updatePermissions(ctx) {
const { id } = ctx.params;
const { body: input } = ctx.request;
const { findOne, assignPermissions } = getService('role');
const { sanitizePermission, actionProvider } = getService('permission');
const role = await findOne({ id });
if (!role) {
return ctx.notFound('role.notFound');
}
try {
if (role.code === SUPER_ADMIN_CODE) {
throw formatYupErrors(new yup.ValidationError("Super admin permissions can't be edited."));
}
await validatedUpdatePermissionsInput(input, role);
} catch (err) {
return ctx.badRequest('ValidationError', err);
}
let permissionsToAssign;
if ([EDITOR_CODE, AUTHOR_CODE].includes(role.code)) {
permissionsToAssign = input.permissions.map(permission => {
const action = actionProvider.get(permission.action);
if (action.section !== 'contentTypes') {
return permission;
}
const conditions = role.code === AUTHOR_CODE ? ['admin::is-creator'] : [];
return { ...permission, conditions };
});
} else {
permissionsToAssign = input.permissions;
}
const permissions = await assignPermissions(role.id, permissionsToAssign);
ctx.body = {
data: permissions.map(sanitizePermission),
};
},
};