mirror of
https://github.com/Unstructured-IO/unstructured.git
synced 2025-07-24 17:41:15 +00:00
Bugfix/ingest pipeline check (#3303)
### Description Using a `isinstance` on the destination registry mapping breaks when inheritance is used for the associated uploader types. This adds a connector type field to all uploaders so that the entry can be deterministically fetched when running check for associated stager in pipeline.
This commit is contained in:
parent
087adb218f
commit
137b149be8
@ -1,4 +1,4 @@
|
||||
## 0.14.9-dev7
|
||||
## 0.14.9-dev8
|
||||
|
||||
### Enhancements
|
||||
|
||||
|
@ -1 +1 @@
|
||||
__version__ = "0.14.9-dev7" # pragma: no cover
|
||||
__version__ = "0.14.9-dev8" # pragma: no cover
|
||||
|
@ -26,6 +26,7 @@ class UploadContent:
|
||||
@dataclass
|
||||
class Uploader(BaseProcess, BaseConnector, ABC):
|
||||
upload_config: UploaderConfigT
|
||||
connector_type: str
|
||||
|
||||
def is_async(self) -> bool:
|
||||
return False
|
||||
|
@ -87,17 +87,8 @@ class Pipeline:
|
||||
# Make sure that if the set destination connector expects a stager, one is also set
|
||||
if not self.uploader_step:
|
||||
return
|
||||
matching_registry_entry = [
|
||||
v
|
||||
for v in destination_registry.values()
|
||||
if isinstance(self.uploader_step.process, v.uploader)
|
||||
]
|
||||
if len(matching_registry_entry) > 1:
|
||||
raise ValueError(
|
||||
f"More than one entry found in destination registry "
|
||||
f"for uploader type: {self.uploader_step.process}"
|
||||
)
|
||||
registry_entry = matching_registry_entry[0]
|
||||
uploader_connector_type = self.uploader_step.process.connector_type
|
||||
registry_entry = destination_registry[uploader_connector_type]
|
||||
if registry_entry.upload_stager and self.stager_step is None:
|
||||
raise ValueError(
|
||||
f"pipeline with uploader type {self.uploader_step.process.__class__.__name__} "
|
||||
|
@ -92,6 +92,7 @@ class AstraUploaderConfig(UploaderConfig):
|
||||
class AstraUploader(Uploader):
|
||||
connection_config: AstraConnectionConfig
|
||||
upload_config: AstraUploaderConfig
|
||||
connector_type: str = CONNECTOR_TYPE
|
||||
|
||||
@requires_dependencies(["astrapy"], extras="astra")
|
||||
def get_collection(self) -> "AstraDBCollection":
|
||||
|
@ -114,6 +114,7 @@ class ChromaUploaderConfig(UploaderConfig):
|
||||
|
||||
@dataclass
|
||||
class ChromaUploader(Uploader):
|
||||
connector_type: str = CONNECTOR_TYPE
|
||||
upload_config: ChromaUploaderConfig
|
||||
connection_config: ChromaConnectionConfig
|
||||
client: Optional["Client"] = field(init=False)
|
||||
|
@ -327,6 +327,7 @@ class ElasticsearchUploaderConfig(UploaderConfig):
|
||||
|
||||
@dataclass
|
||||
class ElasticsearchUploader(Uploader):
|
||||
connector_type: str = CONNECTOR_TYPE
|
||||
upload_config: ElasticsearchUploaderConfig
|
||||
connection_config: ElasticsearchConnectionConfig
|
||||
|
||||
|
@ -114,6 +114,7 @@ class AzureUploaderConfig(FsspecUploaderConfig):
|
||||
|
||||
@dataclass
|
||||
class AzureUploader(FsspecUploader):
|
||||
connector_type: str = CONNECTOR_TYPE
|
||||
connection_config: AzureConnectionConfig
|
||||
upload_config: AzureUploaderConfig = field(default=None)
|
||||
|
||||
|
@ -100,7 +100,8 @@ class BoxUploaderConfig(FsspecUploaderConfig):
|
||||
|
||||
|
||||
@dataclass
|
||||
class BoxUpload(FsspecUploader):
|
||||
class BoxUploader(FsspecUploader):
|
||||
connector_type: str = CONNECTOR_TYPE
|
||||
connection_config: BoxConnectionConfig
|
||||
upload_config: BoxUploaderConfig = field(default=None)
|
||||
|
||||
@ -131,6 +132,8 @@ add_source_entry(
|
||||
add_destination_entry(
|
||||
destination_type=CONNECTOR_TYPE,
|
||||
entry=DestinationRegistryEntry(
|
||||
uploader=BoxUpload, uploader_config=BoxUploaderConfig, connection_config=BoxConnectionConfig
|
||||
uploader=BoxUploader,
|
||||
uploader_config=BoxUploaderConfig,
|
||||
connection_config=BoxConnectionConfig,
|
||||
),
|
||||
)
|
||||
|
@ -99,7 +99,8 @@ class DropboxUploaderConfig(FsspecUploaderConfig):
|
||||
|
||||
|
||||
@dataclass
|
||||
class DropboxUpload(FsspecUploader):
|
||||
class DropboxUploader(FsspecUploader):
|
||||
connector_type: str = CONNECTOR_TYPE
|
||||
connection_config: DropboxConnectionConfig
|
||||
upload_config: DropboxUploaderConfig = field(default=None)
|
||||
|
||||
@ -130,7 +131,7 @@ add_source_entry(
|
||||
add_destination_entry(
|
||||
destination_type=CONNECTOR_TYPE,
|
||||
entry=DestinationRegistryEntry(
|
||||
uploader=DropboxUpload,
|
||||
uploader=DropboxUploader,
|
||||
uploader_config=DropboxUploaderConfig,
|
||||
connection_config=DropboxConnectionConfig,
|
||||
),
|
||||
|
@ -304,6 +304,7 @@ FsspecUploaderConfigT = TypeVar("FsspecUploaderConfigT", bound=FsspecUploaderCon
|
||||
|
||||
@dataclass
|
||||
class FsspecUploader(Uploader):
|
||||
connector_type: str = CONNECTOR_TYPE
|
||||
upload_config: FsspecUploaderConfigT = field(default=None)
|
||||
|
||||
@property
|
||||
|
@ -111,6 +111,7 @@ class GcsUploaderConfig(FsspecUploaderConfig):
|
||||
|
||||
@dataclass
|
||||
class GcsUploader(FsspecUploader):
|
||||
connector_type: str = CONNECTOR_TYPE
|
||||
connection_config: GcsConnectionConfig
|
||||
upload_config: GcsUploaderConfig = field(default=None)
|
||||
|
||||
|
@ -125,7 +125,8 @@ class S3UploaderConfig(FsspecUploaderConfig):
|
||||
|
||||
|
||||
@dataclass
|
||||
class S3Upload(FsspecUploader):
|
||||
class S3Uploader(FsspecUploader):
|
||||
connector_type: str = CONNECTOR_TYPE
|
||||
connection_config: S3ConnectionConfig
|
||||
upload_config: S3UploaderConfig = field(default=None)
|
||||
|
||||
@ -156,7 +157,7 @@ add_source_entry(
|
||||
add_destination_entry(
|
||||
destination_type=CONNECTOR_TYPE,
|
||||
entry=DestinationRegistryEntry(
|
||||
uploader=S3Upload,
|
||||
uploader=S3Uploader,
|
||||
uploader_config=S3UploaderConfig,
|
||||
connection_config=S3ConnectionConfig,
|
||||
),
|
||||
|
@ -136,6 +136,7 @@ class SftpUploaderConfig(FsspecUploaderConfig):
|
||||
|
||||
@dataclass
|
||||
class SftpUploader(FsspecUploader):
|
||||
connector_type: str = CONNECTOR_TYPE
|
||||
connection_config: SftpConnectionConfig
|
||||
upload_config: SftpUploaderConfig = field(default=None)
|
||||
|
||||
|
@ -160,6 +160,7 @@ class LocalUploaderConfig(UploaderConfig):
|
||||
|
||||
@dataclass
|
||||
class LocalUploader(Uploader):
|
||||
connector_type: str = CONNECTOR_TYPE
|
||||
upload_config: LocalUploaderConfig = field(default_factory=lambda: LocalUploaderConfig())
|
||||
connection_config: LocalConnectionConfig = field(
|
||||
default_factory=lambda: LocalConnectionConfig()
|
||||
|
@ -154,6 +154,7 @@ class WeaviateUploaderConfig(UploaderConfig):
|
||||
|
||||
@dataclass
|
||||
class WeaviateUploader(Uploader):
|
||||
connector_type: str = CONNECTOR_TYPE
|
||||
upload_config: WeaviateUploaderConfig
|
||||
connection_config: WeaviateConnectionConfig
|
||||
client: Optional["Client"] = field(init=False)
|
||||
|
Loading…
x
Reference in New Issue
Block a user